From nobody Mon Feb 9 04:13:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554820080; cv=none; d=zoho.com; s=zohoarc; b=SvThb6LICrPuDP8J+WsX9R0wVvSQoviCl8y5BjhOBVCK8SGNsOPojEE8XboC+tVBlN5UI5nZOlVzAYuT6koYIlUtU4EbtCYXtm8A9STjL9fbptVNKL4rrvs+QWl92vgGvYQ3bPbfJefsNKRi3+EgFJBoABvW5WgPoYatAeIBacc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554820080; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=DTWt30AWTWeNBd/wKCbN68Yxnjmw/YzsWL9SZrPJcB0=; b=NVfmbT6fHlvCSzEctSD2Ng9bGuaiWX1xt2F2HzcA0QPDlruSfm2yKh7R/4vWLwOCfVMu/TbdDWV30fyz4/ArBxB10iuhTjhtCPs3Nr8Gd6p59XYgBtcGSDu11P93ZY3I1o64ss5COkzqMQO7dhVOKyE+qNcNYduyqn9ZJmK8V9c= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1554820080107597.0527724136681; Tue, 9 Apr 2019 07:28:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BED6C130704; Tue, 9 Apr 2019 14:27:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7586917ACF; Tue, 9 Apr 2019 14:27:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4035A181AC8F; Tue, 9 Apr 2019 14:27:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x39ERvsl024250 for ; Tue, 9 Apr 2019 10:27:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5731419C7F; Tue, 9 Apr 2019 14:27:57 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D37F319C7B for ; Tue, 9 Apr 2019 14:27:56 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 9 Apr 2019 16:27:46 +0200 Message-Id: <20190409142750.32034-4-abologna@redhat.com> In-Reply-To: <20190409142750.32034-1-abologna@redhat.com> References: <20190409142750.32034-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 3/7] m4: readline: Comment rl_completion_quote_character() check X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 09 Apr 2019 14:27:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The check was added in 74416b1d4849 without offering any explanation outside of the commit message. Introduce a comment to make digging through the git history unnecessary. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- m4/virt-readline.m4 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/m4/virt-readline.m4 b/m4/virt-readline.m4 index 4823a27788..649a52edfa 100644 --- a/m4/virt-readline.m4 +++ b/m4/virt-readline.m4 @@ -37,6 +37,12 @@ AC_DEFUN([LIBVIRT_CHECK_READLINE],[ LIBS=3D"$lv_saved_libs $extra_LIBS" fi =20 + # This function is present in all reasonable (5.0+) readline versions; + # however, the macOS base system contains a library called libedit which + # takes over the readline name despite lacking many of its features. We + # want to make sure we only enable readline support when linking against + # the actual readline library, and the availability of this specific + # functions is as good a witness for that fact as any. AC_CHECK_DECLS([rl_completion_quote_character], [], [], [[#include --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list