From nobody Tue Feb 10 03:45:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554815516; cv=none; d=zoho.com; s=zohoarc; b=my0WrODKjf61ggTbElJrF6HZD3JqmWlVNuEpjaNjXEhx61bDF/BzxmBNBSgEIZJbBi2oB3mMNt36FFpFXtpkisnJGuobnIa5ahk/KV1qexAOJeHf5gq2FEwEWkfn9kmr6d49+gqEvvUgHjktq8FJf3nP0WToRfFVCdrC2ODk4Xg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554815516; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=EAQKrC4Xq2F9wPMQNYti+la8VlUGOkEJwoN7Oxun3Oo=; b=Hjdcms3OUFHRb0HCBitUOfxoVHFy+dgrlQFrfLuL2EXz6bBxsLAuBBv7sZRs3gqQDgdttwVPl/fHe3x+uXfMMOVGtne0NiApW355FrwUxJ7Ed4s5HC/mbAzw5Pcr0FM7othf4NN/B8PZKWF+lUOGS27296mQP44Y37eSHy0uwKE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1554815516922242.61351444742616; Tue, 9 Apr 2019 06:11:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0252D13A5C; Tue, 9 Apr 2019 13:11:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB90D1001E8F; Tue, 9 Apr 2019 13:11:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8A4C5181AC8F; Tue, 9 Apr 2019 13:11:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x39DAWlp005612 for ; Tue, 9 Apr 2019 09:10:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6E7195C28D; Tue, 9 Apr 2019 13:10:32 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB7995F9C9 for ; Tue, 9 Apr 2019 13:10:31 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 9 Apr 2019 15:10:23 +0200 Message-Id: <20190409131023.20275-7-abologna@redhat.com> In-Reply-To: <20190409131023.20275-1-abologna@redhat.com> References: <20190409131023.20275-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 6/6] m4: readline: Add gross kludge for include path X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 09 Apr 2019 13:11:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Unfortunately the data reported by pkg-config is not completely accurate, so until the issue has been fixed in readline we need to work around it in libvirt. The good news is that we only need the fix to land in FreeBSD ports and macOS homebrew before we can drop the kludge, so we're talking months rather than years. Signed-off-by: Andrea Bolognani --- m4/virt-readline.m4 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/m4/virt-readline.m4 b/m4/virt-readline.m4 index 6fde47d2c8..0e83b026e0 100644 --- a/m4/virt-readline.m4 +++ b/m4/virt-readline.m4 @@ -43,6 +43,23 @@ AC_DEFUN([LIBVIRT_CHECK_READLINE],[ *) READLINE_CFLAGS=3D"-D_FUNCTION_DEF $READLINE_CFLAGS" ;; esac fi + + # Gross kludge for readline include path obtained through pkg-config. + # + # As of 8.0, upstream readline.pc has -I${includedir}/readline among + # its Cflags, which is clearly wrong. This does not affect Linux + # because ${includedir} is already part of the default include path, + # but on other platforms that's not the case and the result is that + # can't be located, causing the build to fail. + # A patch solving this issue has already been posted upstream, so once + # the fix has landed in FreeBSD ports and macOS homebrew we can safely + # drop the kludge and rely on pkg-config alone on those platforms. + # + # [1] http://lists.gnu.org/archive/html/bug-readline/2019-04/msg00007.ht= ml + case "$READLINE_CFLAGS" in + *include/readline*) READLINE_CFLAGS=3D$(echo $READLINE_CFLAGS | sed s,= include/readline,include,g) ;; + *) ;; + esac ]) =20 AC_DEFUN([LIBVIRT_RESULT_READLINE],[ --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list