From nobody Wed Apr 24 22:09:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1552555166263242.48852086489444; Thu, 14 Mar 2019 02:19:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3F7F308339D; Thu, 14 Mar 2019 09:19:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A8CA6B8ED; Thu, 14 Mar 2019 09:19:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1AA9B41F3D; Thu, 14 Mar 2019 09:19:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x2E9JLSp027557 for ; Thu, 14 Mar 2019 05:19:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id D469637D6; Thu, 14 Mar 2019 09:19:21 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 574995DD93 for ; Thu, 14 Mar 2019 09:19:18 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 14 Mar 2019 10:19:17 +0100 Message-Id: <20190314091917.3012-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] run: Don't export unnecessary paths X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 14 Mar 2019 09:19:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We're using virFileFindResourceFull() to locate resources nowadays, which makes exporting these information in the environment unnecessary: see virDriverLoadModule() for LIBVIRT_DRIVER_DIR virLockManagerPluginNew() for LIBVIRT_LOCK_MANAGER_PLUGIN_DIR virLockManagerLockDaemonConnectionNew() for VIRTLOCKD_PATH doRemoteOpen() for LIBVIRTD_PATH As further proof that we don't need to expose the information this way anymore, we're not even exporting VIRTLOGD_PATH, which would be necessary if virLogManagerConnect() didn't already take care of that for us. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- run.in | 5 ----- 1 file changed, 5 deletions(-) diff --git a/run.in b/run.in index 06ad54b62b..9a1c6ea11a 100644 --- a/run.in +++ b/run.in @@ -60,11 +60,6 @@ else fi export PKG_CONFIG_PATH =20 -export LIBVIRT_DRIVER_DIR=3D"$b/src/.libs" -export LIBVIRT_LOCK_MANAGER_PLUGIN_DIR=3D"$b/src/.libs" -export VIRTLOCKD_PATH=3D"$b/src" -export LIBVIRTD_PATH=3D"$b/src" - # This is a cheap way to find some use-after-free and uninitialized # read problems when using glibc. random_val=3D"$(awk 'BEGIN{srand(); print 1+int(255*rand())}' < /dev/null)" --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list