From nobody Mon Feb 9 21:36:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1552495926343584.540318760651; Wed, 13 Mar 2019 09:52:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D44F80E7B; Wed, 13 Mar 2019 16:52:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66D416B8D0; Wed, 13 Mar 2019 16:52:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1F98A3FB15; Wed, 13 Mar 2019 16:52:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x2DGpbi4013431 for ; Wed, 13 Mar 2019 12:51:37 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7D0FC5D73F; Wed, 13 Mar 2019 16:51:37 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0164B5D706 for ; Wed, 13 Mar 2019 16:51:36 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Wed, 13 Mar 2019 17:51:23 +0100 Message-Id: <20190313165123.23324-9-abologna@redhat.com> In-Reply-To: <20190313165123.23324-1-abologna@redhat.com> References: <20190313165123.23324-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 8/8] Don't define abs_* variables ourselves X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 13 Mar 2019 16:52:05 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Apparently this was necessary in the past because old versions of autoconf/automake didn't make them available, but these days all of the platforms we target include recent enough autotools - as evidenced by the fact that, for example, we already use abs_top_srcdir in tools/ despite the fact that tools/Makefile.am is missing the same boilerplate. Signed-off-by: Andrea Bolognani Reviewed-by: Martin Kletzander --- src/Makefile.am | 6 ------ tests/Makefile.am | 6 ------ 2 files changed, 12 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0d3d231889..4294bd1c6c 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -16,12 +16,6 @@ ## License along with this library. If not, see ## . =20 -# old automake does not provide abs_{src,build}dir variables -abs_builddir =3D $(shell pwd) -abs_top_builddir =3D $(shell cd .. && pwd) -abs_srcdir =3D $(shell cd $(srcdir) && pwd) -abs_top_srcdir =3D $(shell cd $(top_srcdir) && pwd) - # No libraries with the exception of LIBXML should be listed # here. List them against the individual XXX_la_CFLAGS targets # that actually use them. diff --git a/tests/Makefile.am b/tests/Makefile.am index 858ed047e8..7ce327c9e8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -16,12 +16,6 @@ ## License along with this library. If not, see ## . =20 -# old automake does not provide abs_{src,build}dir variables -abs_builddir =3D $(shell pwd) -abs_top_builddir =3D $(shell cd .. && pwd) -abs_srcdir =3D $(shell cd $(srcdir) && pwd) -abs_top_srcdir =3D $(shell cd $(top_srcdir) && pwd) - SHELL =3D $(PREFERABLY_POSIX_SHELL) =20 AM_CPPFLAGS =3D \ --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list