[libvirt] [PATCH 0/6] lxc: Add suport to virConnectGetAllDomainStats().

Julio Faracco posted 6 patches 9 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190311205618.6588-1-jcfaracco@gmail.com
src/lxc/lxc_driver.c | 357 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 357 insertions(+)

[libvirt] [PATCH 0/6] lxc: Add suport to virConnectGetAllDomainStats().

Posted by Julio Faracco 9 weeks ago
This series has a collection of new methods to enable support for 
virConnectGetAllDomainStats() to LXC driver. The only difference is Disk
Stats. It needs to consider only the host file system operations or any
other block device as a external disk or partition.

Julio Faracco (6):
  lxc: Introduce method lxcConnectGetAllDomainStats().
  lxc: Introduce method lxcDomainGetStats().
  lxc: Introduce method lxcDomainGetStatsCpu().
  lxc: Introduce method lxcDomainGetStatsState().
  lxc: Introduce method lxcDomainGetBlockStats().
  lxc: Introduce method lxcDomainGetBalloonStats().

 src/lxc/lxc_driver.c | 357 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 357 insertions(+)

-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/6] lxc: Add suport to virConnectGetAllDomainStats().

Posted by Peter Krempa 9 weeks ago
On Mon, Mar 11, 2019 at 17:56:12 -0300, Julio Faracco wrote:
> This series has a collection of new methods to enable support for 
> virConnectGetAllDomainStats() to LXC driver. The only difference is Disk
> Stats. It needs to consider only the host file system operations or any
> other block device as a external disk or partition.
> 
> Julio Faracco (6):
>   lxc: Introduce method lxcConnectGetAllDomainStats().
>   lxc: Introduce method lxcDomainGetStats().
>   lxc: Introduce method lxcDomainGetStatsCpu().
>   lxc: Introduce method lxcDomainGetStatsState().
>   lxc: Introduce method lxcDomainGetBlockStats().
>   lxc: Introduce method lxcDomainGetBalloonStats().

I've looked through and this series will not compile between commits,
which is a requirement for pushing it. You'll need to fix the function
calls so that they don't reference code which does not exist at given
time.

Other comments will be inline.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list