From nobody Wed Nov 27 09:42:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1552326502235599.9100694232523; Mon, 11 Mar 2019 10:48:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 07832307D84D; Mon, 11 Mar 2019 17:48:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B39C5D706; Mon, 11 Mar 2019 17:48:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 81DDA181A136; Mon, 11 Mar 2019 17:48:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x2BHmGLO025583 for ; Mon, 11 Mar 2019 13:48:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 623F95DAAF; Mon, 11 Mar 2019 17:48:16 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAAA15DA27 for ; Mon, 11 Mar 2019 17:48:13 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 11 Mar 2019 18:48:11 +0100 Message-Id: <20190311174811.28272-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH] lcitool: Raise Error instead of Exception X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 11 Mar 2019 17:48:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This results in $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt FROM debian:9 ./lcitool: Unsupported architecture ppc64el being printed on error, instead of the much nastier $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt FROM debian:9 Traceback (most recent call last): File "./lcitool", line 704, in Application().run() File "./lcitool", line 699, in run args.func(args) File "./lcitool", line 643, in _action_dockerfile deb_arch =3D Util.native_arch_to_deb_arch(args.cross_arch) File "./lcitool", line 126, in native_arch_to_deb_arch raise Exception("Unsupported architecture {}".format(native_arch)) Exception: Unsupported architecture foo Signed-off-by: Andrea Bolognani --- guests/lcitool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index d6c8105..1119aaf 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -105,7 +105,7 @@ class Util: "x86_64": "x86_64-linux-gnu", } if native_arch not in archmap: - raise Exception("Unsupported architecture {}".format(native_ar= ch)) + raise Error("Unsupported architecture {}".format(native_arch)) return archmap[native_arch] =20 @staticmethod @@ -123,7 +123,7 @@ class Util: "x86_64": "amd64", } if native_arch not in archmap: - raise Exception("Unsupported architecture {}".format(native_ar= ch)) + raise Error("Unsupported architecture {}".format(native_arch)) return archmap[native_arch] =20 =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list