From nobody Mon Feb 9 06:48:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1551973488046715.355812907027; Thu, 7 Mar 2019 07:44:48 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 230EC309265C; Thu, 7 Mar 2019 15:44:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8B9660856; Thu, 7 Mar 2019 15:44:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B0446181A136; Thu, 7 Mar 2019 15:44:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x27FiiHU018639 for ; Thu, 7 Mar 2019 10:44:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4988F19C69; Thu, 7 Mar 2019 15:44:44 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C180519C72 for ; Thu, 7 Mar 2019 15:44:43 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 7 Mar 2019 16:44:32 +0100 Message-Id: <20190307154437.1405-4-abologna@redhat.com> In-Reply-To: <20190307154437.1405-1-abologna@redhat.com> References: <20190307154437.1405-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/8] tests: Move data directories into testQemuData X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 07 Mar 2019 15:44:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This removes a little duplication right away, and more importantly will allow us to perform some interesting refactoring later on. Signed-off-by: Andrea Bolognani --- tests/qemucapabilitiestest.c | 15 +++++++++------ tests/qemucaps2xmltest.c | 13 +++++++++---- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c index 0f875f9e24..e3c6681dd4 100644 --- a/tests/qemucapabilitiestest.c +++ b/tests/qemucapabilitiestest.c @@ -35,6 +35,7 @@ typedef struct _testQemuData testQemuData; typedef testQemuData *testQemuDataPtr; struct _testQemuData { virQEMUDriver driver; + const char *dataDir; const char *archName; const char *base; int ret; @@ -47,6 +48,8 @@ testQemuDataInit(testQemuDataPtr data) if (qemuTestDriverInit(&data->driver) < 0) return -1; =20 + data->dataDir =3D abs_srcdir "/qemucapabilitiesdata"; + data->ret =3D 0; =20 return 0; @@ -73,10 +76,10 @@ testQemuCaps(const void *opaque) unsigned int fakeMicrocodeVersion =3D 0; const char *p; =20 - if (virAsprintf(&repliesFile, "%s/qemucapabilitiesdata/%s.%s.replies", - abs_srcdir, data->base, data->archName) < 0 || - virAsprintf(&capsFile, "%s/qemucapabilitiesdata/%s.%s.xml", - abs_srcdir, data->base, data->archName) < 0) + if (virAsprintf(&repliesFile, "%s/%s.%s.replies", + data->dataDir, data->base, data->archName) < 0 || + virAsprintf(&capsFile, "%s/%s.%s.xml", + data->dataDir, data->base, data->archName) < 0) goto cleanup; =20 if (!(mon =3D qemuMonitorTestNewFromFileFull(repliesFile, &data->drive= r, NULL))) @@ -141,8 +144,8 @@ testQemuCapsCopy(const void *opaque) virQEMUCapsPtr copy =3D NULL; char *actual =3D NULL; =20 - if (virAsprintf(&capsFile, "%s/qemucapabilitiesdata/%s.%s.xml", - abs_srcdir, data->base, data->archName) < 0) + if (virAsprintf(&capsFile, "%s/%s.%s.xml", + data->dataDir, data->base, data->archName) < 0) goto cleanup; =20 if (!(caps =3D virCapabilitiesNew(virArchFromString(data->archName), diff --git a/tests/qemucaps2xmltest.c b/tests/qemucaps2xmltest.c index e9b0b11e35..46d2ce8b44 100644 --- a/tests/qemucaps2xmltest.c +++ b/tests/qemucaps2xmltest.c @@ -28,6 +28,8 @@ typedef struct _testQemuData testQemuData; typedef testQemuData *testQemuDataPtr; struct _testQemuData { + const char *inputDir; + const char *outputDir; const char *base; const char *archName; int ret; @@ -36,6 +38,9 @@ struct _testQemuData { static int testQemuDataInit(testQemuDataPtr data) { + data->inputDir =3D abs_srcdir "/qemucapabilitiesdata"; + data->outputDir =3D abs_srcdir "/qemucaps2xmloutdata"; + data->ret =3D 0; =20 return 0; @@ -142,12 +147,12 @@ testQemuCapsXML(const void *opaque) char *capsXml =3D NULL; virCapsPtr capsProvided =3D NULL; =20 - if (virAsprintf(&xmlFile, "%s/qemucaps2xmloutdata/caps.%s.xml", - abs_srcdir, data->archName) < 0) + if (virAsprintf(&xmlFile, "%s/caps.%s.xml", + data->outputDir, data->archName) < 0) goto cleanup; =20 - if (virAsprintf(&capsFile, "%s/qemucapabilitiesdata/%s.%s.xml", - abs_srcdir, data->base, data->archName) < 0) + if (virAsprintf(&capsFile, "%s/%s.%s.xml", + data->inputDir, data->base, data->archName) < 0) goto cleanup; =20 if (virTestLoadFile(capsFile, &capsData) < 0) --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list