From nobody Mon Feb 9 10:47:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 155195370204012.989732072186143; Thu, 7 Mar 2019 02:15:02 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C6C03082141; Thu, 7 Mar 2019 10:15:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52703608EC; Thu, 7 Mar 2019 10:15:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0C7CB181A138; Thu, 7 Mar 2019 10:15:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x27AEvjL017123 for ; Thu, 7 Mar 2019 05:14:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id A91DE608EC; Thu, 7 Mar 2019 10:14:57 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DC00611BC for ; Thu, 7 Mar 2019 10:14:57 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 7 Mar 2019 11:14:43 +0100 Message-Id: <20190307101446.25765-5-abologna@redhat.com> In-Reply-To: <20190307101446.25765-1-abologna@redhat.com> References: <20190307101446.25765-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/7] util: Tweak virStringHasSuffix() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 07 Mar 2019 10:15:01 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Make it more similar to virStringStripSuffix(), which also results in types being more correct since STRNEQ() returns int rather than bool. Signed-off-by: Andrea Bolognani --- src/util/virstring.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index f669d59f58..a938669b63 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1245,7 +1245,10 @@ virStringHasSuffix(const char *str, if (len < suffixlen) return false; =20 - return STREQ(str + len - suffixlen, suffix); + if (STRNEQ(str + len - suffixlen, suffix)) + return false; + + return true; } =20 bool --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list