From nobody Mon Feb 9 08:55:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1551953702636371.3441825699375; Thu, 7 Mar 2019 02:15:02 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B42A9C0587C3; Thu, 7 Mar 2019 10:15:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 858D85D788; Thu, 7 Mar 2019 10:15:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 38685244F3; Thu, 7 Mar 2019 10:15:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x27AEuPA017114 for ; Thu, 7 Mar 2019 05:14:56 -0500 Received: by smtp.corp.redhat.com (Postfix) id D22596090C; Thu, 7 Mar 2019 10:14:56 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 559EA608EC for ; Thu, 7 Mar 2019 10:14:56 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 7 Mar 2019 11:14:42 +0100 Message-Id: <20190307101446.25765-4-abologna@redhat.com> In-Reply-To: <20190307101446.25765-1-abologna@redhat.com> References: <20190307101446.25765-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/7] util: Make virStringMatchesNameSuffix() return bool X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 07 Mar 2019 10:15:01 +0000 (UTC) Content-Type: text/plain; charset="utf-8" It's a predicate, so bool is the appropriate return type. Signed-off-by: Andrea Bolognani --- src/util/virstring.c | 6 +++--- src/util/virstring.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index e479d3194c..f669d59f58 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1279,7 +1279,7 @@ virStringStripSuffix(char *str, return true; } =20 -int +bool virStringMatchesNameSuffix(const char *file, const char *name, const char *suffix) @@ -1291,9 +1291,9 @@ virStringMatchesNameSuffix(const char *file, if (filelen =3D=3D (namelen + suffixlen) && STREQLEN(file, name, namelen) && STREQLEN(file + namelen, suffix, suffixlen)) - return 1; + return true; else - return 0; + return false; } =20 /** diff --git a/src/util/virstring.h b/src/util/virstring.h index f5f1ecbe1e..1e36ac459c 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -294,9 +294,9 @@ bool virStringHasCaseSuffix(const char *str, const char *suffix); bool virStringStripSuffix(char *str, const char *suffix) ATTRIBUTE_RETURN_CHECK; -int virStringMatchesNameSuffix(const char *file, - const char *name, - const char *suffix); +bool virStringMatchesNameSuffix(const char *file, + const char *name, + const char *suffix); =20 void virStringStripIPv6Brackets(char *str); bool virStringHasChars(const char *str, --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list