From nobody Mon Feb 9 13:57:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1551953696841271.7941372927137; Thu, 7 Mar 2019 02:14:56 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8D373004149; Thu, 7 Mar 2019 10:14:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 493495D719; Thu, 7 Mar 2019 10:14:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0308B41F3D; Thu, 7 Mar 2019 10:14:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x27AEqa1017094 for ; Thu, 7 Mar 2019 05:14:52 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9DE072CFAA; Thu, 7 Mar 2019 10:14:52 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22C33608EC for ; Thu, 7 Mar 2019 10:14:51 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 7 Mar 2019 11:14:40 +0100 Message-Id: <20190307101446.25765-2-abologna@redhat.com> In-Reply-To: <20190307101446.25765-1-abologna@redhat.com> References: <20190307101446.25765-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/7] util: Make virStringHasCaseSuffix() return bool X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 07 Mar 2019 10:14:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" It's a predicate, so bool is the appropriate return type. Signed-off-by: Andrea Bolognani --- src/util/virstring.c | 4 ++-- src/util/virstring.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index cf3d9c6f03..cd781a84f9 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1248,7 +1248,7 @@ virStringHasSuffix(const char *str, return STREQ(str + len - suffixlen, suffix); } =20 -int +bool virStringHasCaseSuffix(const char *str, const char *suffix) { @@ -1256,7 +1256,7 @@ virStringHasCaseSuffix(const char *str, int suffixlen =3D strlen(suffix); =20 if (len < suffixlen) - return 0; + return false; =20 return STRCASEEQ(str + len - suffixlen, suffix); } diff --git a/src/util/virstring.h b/src/util/virstring.h index 5b127cdba4..ed2db8a3dc 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -290,8 +290,8 @@ char *virStringReplace(const char *haystack, =20 bool virStringHasSuffix(const char *str, const char *suffix); -int virStringHasCaseSuffix(const char *str, - const char *suffix); +bool virStringHasCaseSuffix(const char *str, + const char *suffix); int virStringStripSuffix(char *str, const char *suffix) ATTRIBUTE_RETURN_CHECK; int virStringMatchesNameSuffix(const char *file, --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list