[libvirt] [PATCH v3 00/10] Alter domain_conf to make use of autofree

John Ferlan posted 10 patches 5 years ago
Test syntax-check passed
Failed in applying to current master (apply log)
src/conf/domain_conf.c | 2080 ++++++++++++++--------------------------
1 file changed, 731 insertions(+), 1349 deletions(-)
[libvirt] [PATCH v3 00/10] Alter domain_conf to make use of autofree
Posted by John Ferlan 5 years ago
v2: https://www.redhat.com/archives/libvir-list/2019-February/msg01201.html

Changes since v2:

Patches 1-5 are marked w/ reviewed-by

Added patch 6 to add a few more VIR_AUTOFREE on char *'s that I missed
in the first passes - these would be merged with previous after a
successful review.

Added patch 7 to add VIR_AUTOUNREF.

Patch 8 is unchanged from previous patch 6

Patch 9 is more places where cleanup could occur from code review and
from the VIR_AUTOUNREF change

Patch 10 is a change to virDomainKeyWrapDefParseXML as requested as part
of the code review

Other requests for more VIR_AUTOPTR usage should be done right and at
a later point.

Usage of VIR_XPATH_NODE_AUTORESTORE would also have to wait since
those changes aren't pushed yet, but that could lead to *a lot* more
cleanup in domain_conf.

John Ferlan (10):
  conf: Rework virDomainEmulatorPinDefParseXML
  conf: Use VIR_AUTOPTR(virBitmap) in domain_conf
  conf: Clean up some unnecessary goto paths
  conf: Remove a few unused variables in domain_conf
  conf: Use VIR_AUTOFREE in domain_conf
  conf: Merge with previous
  conf: Use VIR_AUTOUNREF in domain_conf
  conf: Clean up some unnecessary goto paths
  conf: Merge with previous
  conf: Rework virDomainKeyWrapDefParseXML

 src/conf/domain_conf.c | 2080 ++++++++++++++--------------------------
 1 file changed, 731 insertions(+), 1349 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 00/10] Alter domain_conf to make use of autofree
Posted by Erik Skultety 5 years ago
On Fri, Mar 01, 2019 at 11:26:42AM -0500, John Ferlan wrote:
> v2: https://www.redhat.com/archives/libvir-list/2019-February/msg01201.html
>
> Changes since v2:
>
> Patches 1-5 are marked w/ reviewed-by
>
> Added patch 6 to add a few more VIR_AUTOFREE on char *'s that I missed
> in the first passes - these would be merged with previous after a
> successful review.
>
> Added patch 7 to add VIR_AUTOUNREF.
>
> Patch 8 is unchanged from previous patch 6
>
> Patch 9 is more places where cleanup could occur from code review and
> from the VIR_AUTOUNREF change
>
> Patch 10 is a change to virDomainKeyWrapDefParseXML as requested as part
> of the code review
>
> Other requests for more VIR_AUTOPTR usage should be done right and at
> a later point.
>
> Usage of VIR_XPATH_NODE_AUTORESTORE would also have to wait since
> those changes aren't pushed yet, but that could lead to *a lot* more
> cleanup in domain_conf.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list