From nobody Sun May 5 02:08:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15504086791581005.2492100120119; Sun, 17 Feb 2019 05:04:39 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 971B23695F; Sun, 17 Feb 2019 13:04:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 156C95D9CA; Sun, 17 Feb 2019 13:04:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 159C7181A00B; Sun, 17 Feb 2019 13:04:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1HD4PeP016352 for ; Sun, 17 Feb 2019 08:04:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0C82A1024968; Sun, 17 Feb 2019 13:04:25 +0000 (UTC) Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03F5F101E846 for ; Sun, 17 Feb 2019 13:04:24 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A14BB7F6C5 for ; Sun, 17 Feb 2019 13:04:23 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id z25so4198401ljk.8 for ; Sun, 17 Feb 2019 05:04:23 -0800 (PST) Received: from kloomba.my.domain ([213.147.206.165]) by smtp.gmail.com with ESMTPSA id p15sm2782242lfc.88.2019.02.17.05.04.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 05:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wxjVDOhKANTM6vNTnIQxqWELb1+wvZhqiYnoG2YVh1g=; b=ON0rGA7YpmMV4uJVR6woxPcuDjb4vFlsu3ucgo0u1OigLrCJNi1rht2/qruJrAs3JB +h+ZWI3U1c6TRnOFARUHaHr4/Cql3AVubMYGBRNCcWhGHnODS4e3f5wtU1VcygAe4JL6 dDFv4nuVcS2comYoub226vNTbRVx4fDy6wu20jG/BfZ0BhUuq/ROe3LkN3g/nuzQHyDB FVX+7+j+hvBIlE70VPO46i/675VK7dJJlwhns+1N88Ho1JEVra34ULYASG68LPW/rNSf 7XOC5o+QYdHIZDTdmn38oQVTKTRigpFdxgcthtMWt1PRDfDV8Rc16+8orKSbQUKgI52X /Seg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wxjVDOhKANTM6vNTnIQxqWELb1+wvZhqiYnoG2YVh1g=; b=BqiDZaRj7b+nZFzAvtvKVh8AHUUpZRr3HxoEdI2LDagMgRtgnEGiMUpurgcLauSeDC UUUlQlBUwCxsCZXE76t0Qk9caectCsrInziw+Bs7tDKYmxDSqnV6x/baxrmy2MZUBK9B baVlTEeL/G8olWyzUZ5f3GTrA+i9+mRTNSHaOVtNztWYrGbxZx3k4kHQcMVY9CGqz77k XlHjNRhDgge9hik7kGvJ9m8xmfeb4wIIyovv97pzNRjzON/U9Ilr9+W0Hz93jDSSfr6+ VBTT1JVHY0Dx9L/oyRRY+RYg65967m/wH3aPlGdd30VpB59OZhL/yh29j7+9rp6cOj9m 8yVw== X-Gm-Message-State: AHQUAuYr+7U2Z7vRS7OZKVIyuMtsJxveWnzWmgC+wx9Xic7oJ1b8PLnC 0ac7eAqZwCC9PsG2+q6cEy9NRBBr X-Google-Smtp-Source: AHgI3IYy02/v7pN4dL0hMuXY3caVavKhwJzLL/LkasUMhB1ypK1/RphWbIAdHIoqIOWQjoThFyIdcQ== X-Received: by 2002:a2e:9786:: with SMTP id y6-v6mr11113448lji.53.1550408661673; Sun, 17 Feb 2019 05:04:21 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 17 Feb 2019 17:04:00 +0400 Message-Id: <20190217130405.4328-2-bogorodskiy@gmail.com> In-Reply-To: <20190217130405.4328-1-bogorodskiy@gmail.com> References: <20190217130405.4328-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 17 Feb 2019 13:04:24 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 17 Feb 2019 13:04:24 +0000 (UTC) for IP:'209.85.208.196' DOMAIN:'mail-lj1-f196.google.com' HELO:'mail-lj1-f196.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.208.196 mail-lj1-f196.google.com 209.85.208.196 mail-lj1-f196.google.com X-Scanned-By: MIMEDefang 2.83 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH v2 1/6] conf: add 'isa' controller type X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 17 Feb 2019 13:04:37 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Introduce 'isa' controller type. The only supported model now is 'isa-bridge'. In domain XML it looks this way: ...
... Currently, this is needed for the bhyve driver to allow choosing a specific PCI address for that. In bhyve, this controller is used to attach serial ports and a boot ROM. Signed-off-by: Roman Bogorodskiy --- docs/schemas/domaincommon.rng | 13 +++++++++++++ src/conf/domain_conf.c | 10 ++++++++++ src/conf/domain_conf.h | 9 +++++++++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c | 2 ++ src/qemu/qemu_domain_address.c | 1 + src/vbox/vbox_common.c | 1 + 7 files changed, 37 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index ba80440c72..2bf67eaa5a 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -2201,6 +2201,19 @@ + + + + isa + + + + + isa-bridge + + + + diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cd69323f28..4d5fbed6f4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -341,6 +341,7 @@ VIR_ENUM_IMPL(virDomainController, VIR_DOMAIN_CONTROLLE= R_TYPE_LAST, "ccid", "usb", "pci", + "isa", ); =20 VIR_ENUM_IMPL(virDomainControllerModelPCI, VIR_DOMAIN_CONTROLLER_MODEL_PCI= _LAST, @@ -404,6 +405,10 @@ VIR_ENUM_IMPL(virDomainControllerModelIDE, VIR_DOMAIN_= CONTROLLER_MODEL_IDE_LAST, "ich6", ); =20 +VIR_ENUM_IMPL(virDomainControllerModelISA, VIR_DOMAIN_CONTROLLER_MODEL_ISA= _LAST, + "isa-bridge", +); + VIR_ENUM_IMPL(virDomainFS, VIR_DOMAIN_FS_TYPE_LAST, "mount", "block", @@ -2041,6 +2046,7 @@ virDomainControllerDefNew(virDomainControllerType typ= e) case VIR_DOMAIN_CONTROLLER_TYPE_SCSI: case VIR_DOMAIN_CONTROLLER_TYPE_SATA: case VIR_DOMAIN_CONTROLLER_TYPE_CCID: + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: case VIR_DOMAIN_CONTROLLER_TYPE_LAST: break; } @@ -10445,6 +10451,8 @@ virDomainControllerModelTypeFromString(const virDom= ainControllerDef *def, return virDomainControllerModelPCITypeFromString(model); else if (def->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_IDE) return virDomainControllerModelIDETypeFromString(model); + else if (def->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_ISA) + return virDomainControllerModelISATypeFromString(model); =20 return -1; } @@ -10462,6 +10470,8 @@ virDomainControllerModelTypeToString(virDomainContr= ollerDefPtr def, return virDomainControllerModelPCITypeToString(model); else if (def->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_IDE) return virDomainControllerModelIDETypeToString(model); + else if (def->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_ISA) + return virDomainControllerModelISATypeToString(model); =20 return NULL; } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 2bc3f879f7..3c595aab62 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -687,6 +687,7 @@ typedef enum { VIR_DOMAIN_CONTROLLER_TYPE_CCID, VIR_DOMAIN_CONTROLLER_TYPE_USB, VIR_DOMAIN_CONTROLLER_TYPE_PCI, + VIR_DOMAIN_CONTROLLER_TYPE_ISA, =20 VIR_DOMAIN_CONTROLLER_TYPE_LAST } virDomainControllerType; @@ -767,6 +768,13 @@ typedef enum { VIR_DOMAIN_CONTROLLER_MODEL_IDE_LAST } virDomainControllerModelIDE; =20 +typedef enum { + VIR_DOMAIN_CONTROLLER_MODEL_ISA_DEFAULT =3D -1, + VIR_DOMAIN_CONTROLLER_MODEL_ISA_BRIDGE, + + VIR_DOMAIN_CONTROLLER_MODEL_ISA_LAST +} virDomainControllerModelISA; + # define IS_USB2_CONTROLLER(ctrl) \ (((ctrl)->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_USB) && \ ((ctrl)->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_USB_ICH9_EHCI1 || \ @@ -3423,6 +3431,7 @@ VIR_ENUM_DECL(virDomainControllerPCIModelName); VIR_ENUM_DECL(virDomainControllerModelSCSI); VIR_ENUM_DECL(virDomainControllerModelUSB); VIR_ENUM_DECL(virDomainControllerModelIDE); +VIR_ENUM_DECL(virDomainControllerModelISA); VIR_ENUM_DECL(virDomainFS); VIR_ENUM_DECL(virDomainFSDriver); VIR_ENUM_DECL(virDomainFSAccessMode); diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f511193fca..7203a2762c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3024,6 +3024,7 @@ qemuBuildControllerDevStr(const virDomainDef *domainD= ef, =20 case VIR_DOMAIN_CONTROLLER_TYPE_IDE: case VIR_DOMAIN_CONTROLLER_TYPE_FDC: + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: case VIR_DOMAIN_CONTROLLER_TYPE_LAST: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Unsupported controller type: %s"), diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ac01e861f7..306f957eb7 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5851,6 +5851,7 @@ qemuDomainDeviceDefValidateController(const virDomain= ControllerDef *controller, case VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL: case VIR_DOMAIN_CONTROLLER_TYPE_CCID: case VIR_DOMAIN_CONTROLLER_TYPE_USB: + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: case VIR_DOMAIN_CONTROLLER_TYPE_LAST: break; } @@ -6469,6 +6470,7 @@ qemuDomainControllerDefPostParse(virDomainControllerD= efPtr cont, case VIR_DOMAIN_CONTROLLER_TYPE_CCID: case VIR_DOMAIN_CONTROLLER_TYPE_IDE: case VIR_DOMAIN_CONTROLLER_TYPE_FDC: + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: case VIR_DOMAIN_CONTROLLER_TYPE_LAST: break; } diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 32fdd59566..3e072ee8fd 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -669,6 +669,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDevic= eDefPtr dev, =20 case VIR_DOMAIN_CONTROLLER_TYPE_FDC: case VIR_DOMAIN_CONTROLLER_TYPE_CCID: + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: case VIR_DOMAIN_CONTROLLER_TYPE_LAST: /* should be 0 */ return pciFlags; diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 664650f217..6b75a127f8 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -377,6 +377,7 @@ vboxSetStorageController(virDomainControllerDefPtr cont= roller, case VIR_DOMAIN_CONTROLLER_TYPE_CCID: case VIR_DOMAIN_CONTROLLER_TYPE_USB: case VIR_DOMAIN_CONTROLLER_TYPE_PCI: + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: case VIR_DOMAIN_CONTROLLER_TYPE_LAST: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("The vbox driver does not support %s controller t= ype"), --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 02:08:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1550408825233112.64315882325218; Sun, 17 Feb 2019 05:07:05 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A43FC059B88; Sun, 17 Feb 2019 13:07:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD6B5608C1; Sun, 17 Feb 2019 13:07:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7EDEF181A00A; Sun, 17 Feb 2019 13:07:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1HD4Qsp016357 for ; Sun, 17 Feb 2019 08:04:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id 90304608C1; Sun, 17 Feb 2019 13:04:26 +0000 (UTC) Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 878EB60A9A for ; Sun, 17 Feb 2019 13:04:26 +0000 (UTC) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2F45C05AA51 for ; Sun, 17 Feb 2019 13:04:24 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id n23so10342286lfl.4 for ; Sun, 17 Feb 2019 05:04:24 -0800 (PST) Received: from kloomba.my.domain ([213.147.206.165]) by smtp.gmail.com with ESMTPSA id p15sm2782242lfc.88.2019.02.17.05.04.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 05:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NXsK8tZS7VwQfjLx5UwU9haiJ67l+2f66Jj0i6qsrhg=; b=FIHGzsXSoZs8wX0TukR8l8pM3f4psFkeyExScoaPclSxOzfdcO+N32qVEEnSeWEpRG aJSjDUjy8FXJU1hfhLqCdjCi282KeIcfoOu/PR94s25zCc9DUsTy4f9i0hE2cfhebXxI KMAvZRdl0wBtB+KFaboDvMQx+UZGCmuHzZY0E2/iNvaZVS4mV2sVARyUbvHEpQVDHFPR RZ2RyENc9FYc7pxP5LP2/I8WYKioKBWkemFn1qVxcVVRPk/LhK3Qo/3JWGWYRvEHWt4n bw6qEL6SjwW6pRhLokDf0mJ0YJI9lEQ0kIm9pkBmueLR05824ZH8I/lDVnKjAjTxYHsK ScXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NXsK8tZS7VwQfjLx5UwU9haiJ67l+2f66Jj0i6qsrhg=; b=lnK12GQ6z35oz0IUQ6FA0WjOS5kxv9/+p0BRfMezQqrmgzQz45RxrcKUjoe9lanpl2 qL7Ga5g1xmXRkPqbaEtJspuu6+tczPOIxaaxoqQqWZZ+uFQIix3g7UkGXHea99mRHkcp YIzDJP/PTNxzKMWz1Uuv+NakSo5+EL/GexP1+qbtl/AT9Glv6c0dHR2FJZn5xbDKu685 Oqwn5N2kDPo7Lh0ff9zxMmqS/Tg3XLlighSZU62bX/1MENryAyW8fCPNOB55ZhaxanqX ekiHerr4o+WzbdM6+371E7UVIq4q1f9T4CUaNJo7HM2Ma5gXCiWM/9hocplxTU+BTRrI dO6Q== X-Gm-Message-State: AHQUAuZG3sp3vdFViIZr5h6PhCZokaj75SflK1uHW00XOV/0cv6f91Ud bC/GoMkS5kJ88BQ6F6Zmpe1sMEJe X-Google-Smtp-Source: AHgI3IalYogqBczS4+MoHAWHESuiA+EPxXT2zEOb1z4nVeoUu5XZex1krqx547ZFh6lbNQzsRp9aiQ== X-Received: by 2002:a19:f704:: with SMTP id z4mr11028990lfe.10.1550408663074; Sun, 17 Feb 2019 05:04:23 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 17 Feb 2019 17:04:01 +0400 Message-Id: <20190217130405.4328-3-bogorodskiy@gmail.com> In-Reply-To: <20190217130405.4328-1-bogorodskiy@gmail.com> References: <20190217130405.4328-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 17 Feb 2019 13:04:25 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 17 Feb 2019 13:04:25 +0000 (UTC) for IP:'209.85.167.66' DOMAIN:'mail-lf1-f66.google.com' HELO:'mail-lf1-f66.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.167.66 mail-lf1-f66.google.com 209.85.167.66 mail-lf1-f66.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH v2 2/6] bhyve: add bhyveDomainDefNeedsISAController helper X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 17 Feb 2019 13:07:03 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add a bhyveDomainDefNeedsISAController() helper function which by domain configuration determines whether LPC controller is required or not. Signed-off-by: Roman Bogorodskiy Reviewed-by: J=C3=A1n Tomko --- src/bhyve/bhyve_command.c | 5 +---- src/bhyve/bhyve_domain.c | 10 ++++++++++ src/bhyve/bhyve_domain.h | 2 ++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 1f215dac08..f49dc77118 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -460,7 +460,6 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, * vm0 */ size_t i; - bool add_lpc =3D false; int nusbcontrollers =3D 0; unsigned int nvcpus =3D virDomainDefGetVcpus(def); =20 @@ -549,7 +548,6 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, if ((bhyveDriverGetCaps(conn) & BHYVE_CAP_LPC_BOOTROM)) { virCommandAddArg(cmd, "-l"); virCommandAddArgFormat(cmd, "bootrom,%s", def->os.loader->path= ); - add_lpc =3D true; } else { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Installed bhyve binary does not support " @@ -613,7 +611,6 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, if (bhyveBuildGraphicsArgStr(def, def->graphics[0], def->video= s[0], conn, cmd, dryRun) < 0) goto error; - add_lpc =3D true; } else { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Multiple graphics devices are not supported"= )); @@ -621,7 +618,7 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, } } =20 - if (add_lpc || def->nserials) + if (bhyveDomainDefNeedsISAController(def)) bhyveBuildLPCArgStr(def, cmd); =20 if (bhyveBuildConsoleArgStr(def, cmd) < 0) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 79cf103d28..e476ef7e7d 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -61,6 +61,16 @@ virDomainXMLPrivateDataCallbacks virBhyveDriverPrivateDa= taCallbacks =3D { .free =3D bhyveDomainObjPrivateFree, }; =20 +bool +bhyveDomainDefNeedsISAController(virDomainDefPtr def) +{ + if ((def->os.bootloader =3D=3D NULL && def->os.loader) || + (def->nconsoles || def->nserials) || (def->ngraphics && def->nvide= os)) + return true; + else + return false; +} + static int bhyveDomainDefPostParse(virDomainDefPtr def, virCapsPtr caps ATTRIBUTE_UNUSED, diff --git a/src/bhyve/bhyve_domain.h b/src/bhyve/bhyve_domain.h index 5f94038e89..03a2b369d9 100644 --- a/src/bhyve/bhyve_domain.h +++ b/src/bhyve/bhyve_domain.h @@ -41,4 +41,6 @@ extern virDomainXMLPrivateDataCallbacks virBhyveDriverPri= vateDataCallbacks; extern virDomainDefParserConfig virBhyveDriverDomainDefParserConfig; extern virDomainXMLNamespace virBhyveDriverDomainXMLNamespace; =20 +bool bhyveDomainDefNeedsISAController(virDomainDefPtr def); + #endif /* LIBVIRT_BHYVE_DOMAIN_H */ --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 02:08:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1550408703204766.2353249753628; Sun, 17 Feb 2019 05:05:03 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D42878EB1; Sun, 17 Feb 2019 13:05:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4E40608C6; Sun, 17 Feb 2019 13:05:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8C84F181A010; Sun, 17 Feb 2019 13:05:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1HD4XDF016406 for ; Sun, 17 Feb 2019 08:04:33 -0500 Received: by smtp.corp.redhat.com (Postfix) id DF2495D9CA; Sun, 17 Feb 2019 13:04:33 +0000 (UTC) Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FE185DF28 for ; Sun, 17 Feb 2019 13:04:29 +0000 (UTC) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACDED11DBA9 for ; Sun, 17 Feb 2019 13:04:26 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id r10-v6so12048121ljj.4 for ; Sun, 17 Feb 2019 05:04:26 -0800 (PST) Received: from kloomba.my.domain ([213.147.206.165]) by smtp.gmail.com with ESMTPSA id p15sm2782242lfc.88.2019.02.17.05.04.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 05:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SiYwo/fHJpsbeYgqQo9A1GluZc9sZARw9UOjuTnDQG8=; b=DcdXNXd+/NBbyMfQ6tEWxDVB5oJeYowJwdb9Tur2eooSBcfM8oYzqqnMi/j6GvWigD BCDh5WwAUG4M+V5shCH/leWuz5U262zTos/hDK9/6hS+i1R1h9p+w6i23BR5Tz+hIgU9 Cg/VpodEqOv25zcYpmERVCjqW9KCczEKzucE7J++WOvgcZs0ADSGwC/bnYEdCQeBuG4s qQBu4OXR1iPvqw6beXEftKPDe2IwiiIeJD/g1FtnyZkPLVoZ0Gnpu73MtYh866n7bzu8 0aH6Iaso/Px/MXldhM5TYTKGVFlAQpw2j0aeMas+vKwPodgqSGNQRneDqW9HgNAlWtl9 j/rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SiYwo/fHJpsbeYgqQo9A1GluZc9sZARw9UOjuTnDQG8=; b=b1znffAS3PjoTaxJL9TpI+Bu9p1ySxHxE2U33tSWf3D+v0euEXgfPv+8H3TtzEfbkY RxBHg0CgRRxi2945lu8FxuG0bd2OcUD39QESZxaID7VF3hjBCNF0K/bx3ZMNDltjBXX9 0HsWso9tuR5Hw7GIZ1ct+LJRDR2peX99AZT7S8UvOVHAooX96tTiWdRD/hV5GkuIQpQj pC7xSkugFxQDVsmlO+r1OPe17z6Lj2Ikx8fy/Uwn7TUdKMf6+eFcIC3xbon3xY0E+NxR uUt/Qq8H7e8NAL0uDkhhChgple4MlzxTanJuy/owFrQZU1YqjzGvJ/Se6EB4S9txM5/M s19A== X-Gm-Message-State: AHQUAubub8S3suaVm6s1IAW94zRvUrqtHo+6/odkoOTZWNqhdgWjBxc4 Z3QmghwOlb7WvlCvqq9jZOpd/5UF X-Google-Smtp-Source: AHgI3IYVj/zFyo4oePqZ6ygoEfod27iSfGbRbt0xO7n/uyyoUmbEiKufKpbWeVf0m80zSQUUlv2yEA== X-Received: by 2002:a2e:9cc7:: with SMTP id g7mr2196562ljj.33.1550408664387; Sun, 17 Feb 2019 05:04:24 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 17 Feb 2019 17:04:02 +0400 Message-Id: <20190217130405.4328-4-bogorodskiy@gmail.com> In-Reply-To: <20190217130405.4328-1-bogorodskiy@gmail.com> References: <20190217130405.4328-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 17 Feb 2019 13:04:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 17 Feb 2019 13:04:27 +0000 (UTC) for IP:'209.85.208.195' DOMAIN:'mail-lj1-f195.google.com' HELO:'mail-lj1-f195.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.11 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS) 209.85.208.195 mail-lj1-f195.google.com 209.85.208.195 mail-lj1-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH v2 3/6] bhyve: support 'isa' controller for LPC X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 17 Feb 2019 13:05:01 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Support modeling of the 'isa' controller for bhyve. When controller is not present in the domain XML, but domain requires it to be there (e.g. because bootrom is used), implicitly add addition of this controller to the command line arguments, and bind it to PCI slot 1. PCI slot 1 is always reserved still. User can manually define any PCI slot for the 'isa' controller, including PCI slot 1, but other devices are not allowed to use this address. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 18 +++++++++- src/bhyve/bhyve_device.c | 25 ++++++++++--- ...ml2argv-addr-isa-controller-on-slot-1.args | 10 ++++++ ...2argv-addr-isa-controller-on-slot-1.ldargs | 3 ++ ...xml2argv-addr-isa-controller-on-slot-1.xml | 26 ++++++++++++++ ...l2argv-addr-isa-controller-on-slot-31.args | 10 ++++++ ...argv-addr-isa-controller-on-slot-31.ldargs | 3 ++ ...ml2argv-addr-isa-controller-on-slot-31.xml | 26 ++++++++++++++ ...argv-addr-non-isa-controller-on-slot-1.xml | 23 ++++++++++++ .../bhyvexml2argv-isa-controller.args | 10 ++++++ .../bhyvexml2argv-isa-controller.ldargs | 3 ++ .../bhyvexml2argv-isa-controller.xml | 24 +++++++++++++ ...bhyvexml2argv-isa-multiple-controllers.xml | 25 +++++++++++++ tests/bhyvexml2argvtest.c | 5 +++ ...l2xmlout-addr-isa-controller-on-slot-1.xml | 36 +++++++++++++++++++ ...2xmlout-addr-isa-controller-on-slot-31.xml | 36 +++++++++++++++++++ .../bhyvexml2xmlout-isa-controller.xml | 36 +++++++++++++++++++ tests/bhyvexml2xmltest.c | 3 ++ 18 files changed, 317 insertions(+), 5 deletions(-) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controll= er-on-slot-1.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controll= er-on-slot-1.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controll= er-on-slot-1.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controll= er-on-slot-31.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controll= er-on-slot-31.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controll= er-on-slot-31.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-addr-non-isa-cont= roller-on-slot-1.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ar= gs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ld= args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-isa-multiple-cont= rollers.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-cont= roller-on-slot-1.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-cont= roller-on-slot-31.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-isa-controlle= r.xml diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index f49dc77118..2c90265a93 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -461,6 +461,7 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, */ size_t i; int nusbcontrollers =3D 0; + int nisacontrollers =3D 0; unsigned int nvcpus =3D virDomainDefGetVcpus(def); =20 virCommandPtr cmd =3D virCommandNew(BHYVE); @@ -581,6 +582,21 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, if (bhyveBuildUSBControllerArgStr(def, controller, cmd) < = 0) goto error; break; + case VIR_DOMAIN_CONTROLLER_TYPE_ISA: + if (controller->model !=3D VIR_DOMAIN_CONTROLLER_MODEL_ISA= _BRIDGE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", _("unsupported ISA controller= model: only ISA bridge supported")); + goto error; + } + if (++nisacontrollers > 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", _("only single ISA controller= is supported")); + goto error; + } + virCommandAddArg(cmd, "-s"); + virCommandAddArgFormat(cmd, "%d:0,lpc", + controller->info.addr.pci.slot); + break; } } for (i =3D 0; i < def->nnets; i++) { @@ -618,7 +634,7 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, } } =20 - if (bhyveDomainDefNeedsISAController(def)) + if (nisacontrollers =3D=3D 0 && bhyveDomainDefNeedsISAController(def)) bhyveBuildLPCArgStr(def, cmd); =20 if (bhyveBuildConsoleArgStr(def, cmd) < 0) diff --git a/src/bhyve/bhyve_device.c b/src/bhyve/bhyve_device.c index 201044d9e6..42093afb7b 100644 --- a/src/bhyve/bhyve_device.c +++ b/src/bhyve/bhyve_device.c @@ -47,10 +47,17 @@ bhyveCollectPCIAddress(virDomainDefPtr def ATTRIBUTE_UN= USED, if (addr->slot =3D=3D 0) { return 0; } else if (addr->slot =3D=3D 1) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("PCI bus 0 slot 1 is reserved for the implici= t " - "LPC PCI-ISA bridge")); - return -1; + if (!((device->type =3D=3D VIR_DOMAIN_DEVICE_CONTROLLER) && + (device->data.controller->type =3D=3D VIR_DOMAIN_CONTROLL= ER_TYPE_ISA) && + (device->data.controller->model =3D=3D VIR_DOMAIN_CONTROL= LER_MODEL_ISA_BRIDGE))) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("PCI bus 0 slot 1 is reserved for the imp= licit " + "LPC PCI-ISA bridge")); + return -1; + } else { + /* We reserve slot 1 for LPC in bhyveAssignDevicePCISlots(= ), so exit early */ + return 0; + } } } =20 @@ -103,6 +110,16 @@ bhyveAssignDevicePCISlots(virDomainDefPtr def, goto error; } =20 + for (i =3D 0; i < def->ncontrollers; i++) { + if ((def->controllers[i]->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_= ISA) && + (def->controllers[i]->model =3D=3D VIR_DOMAIN_CONTROLLER_MODE= L_ISA_BRIDGE) && + virDeviceInfoPCIAddressIsWanted(&def->controllers[i]->info))= { + def->controllers[i]->info.type =3D VIR_DOMAIN_DEVICE_ADDRESS_= TYPE_PCI; + def->controllers[i]->info.addr.pci =3D lpc_addr; + break; + } + } + for (i =3D 0; i < def->ncontrollers; i++) { if ((def->controllers[i]->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_P= CI) || (def->controllers[i]->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_S= ATA) || diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-1.args b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-1.args new file mode 100644 index 0000000000..910d1bbcfa --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.a= rgs @@ -0,0 +1,10 @@ +/usr/sbin/bhyve \ +-c 1 \ +-m 214 \ +-u \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 1:0,lpc \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 3:0,virtio-net,faketapdev,mac=3D52:54:00:b9:94:02 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-1.ldargs b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on= -slot-1.ldargs new file mode 100644 index 0000000000..32538b558e --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.l= dargs @@ -0,0 +1,3 @@ +/usr/sbin/bhyveload \ +-m 214 \ +-d /tmp/freebsd.img bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-1.xml b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-sl= ot-1.xml new file mode 100644 index 0000000000..796903a9fa --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.x= ml @@ -0,0 +1,26 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 1 + + hvm + + + +
+ + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-31.args b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-= slot-31.args new file mode 100644 index 0000000000..ee833eb460 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.= args @@ -0,0 +1,10 @@ +/usr/sbin/bhyve \ +-c 1 \ +-m 214 \ +-u \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 31:0,lpc \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 3:0,virtio-net,faketapdev,mac=3D52:54:00:b9:94:02 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-31.ldargs b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-o= n-slot-31.ldargs new file mode 100644 index 0000000000..32538b558e --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.= ldargs @@ -0,0 +1,3 @@ +/usr/sbin/bhyveload \ +-m 214 \ +-d /tmp/freebsd.img bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-31.xml b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-s= lot-31.xml new file mode 100644 index 0000000000..65d7480db6 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.= xml @@ -0,0 +1,26 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 1 + + hvm + + + +
+ + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-addr-non-isa-controller-= on-slot-1.xml b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-non-isa-controll= er-on-slot-1.xml new file mode 100644 index 0000000000..88ad9aebb7 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-addr-non-isa-controller-on-slot= -1.xml @@ -0,0 +1,23 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 1 + + hvm + + + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.args b/te= sts/bhyvexml2argvdata/bhyvexml2argv-isa-controller.args new file mode 100644 index 0000000000..910d1bbcfa --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.args @@ -0,0 +1,10 @@ +/usr/sbin/bhyve \ +-c 1 \ +-m 214 \ +-u \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 1:0,lpc \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 3:0,virtio-net,faketapdev,mac=3D52:54:00:b9:94:02 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ldargs b/= tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ldargs new file mode 100644 index 0000000000..32538b558e --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ldargs @@ -0,0 +1,3 @@ +/usr/sbin/bhyveload \ +-m 214 \ +-d /tmp/freebsd.img bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.xml b/tes= ts/bhyvexml2argvdata/bhyvexml2argv-isa-controller.xml new file mode 100644 index 0000000000..71265ea32c --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.xml @@ -0,0 +1,24 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 1 + + hvm + + + + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-isa-multiple-controllers= .xml b/tests/bhyvexml2argvdata/bhyvexml2argv-isa-multiple-controllers.xml new file mode 100644 index 0000000000..25622ce78a --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-isa-multiple-controllers.xml @@ -0,0 +1,25 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 1 + + hvm + + + + + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 4a7f65a8e2..d120bd43ca 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -211,6 +211,8 @@ mymain(void) DO_TEST("cputopology"); DO_TEST_FAILURE("cputopology-nvcpu-mismatch"); DO_TEST("commandline"); + DO_TEST("isa-controller"); + DO_TEST_FAILURE("isa-multiple-controllers"); =20 /* Address allocation tests */ DO_TEST("addr-single-sata-disk"); @@ -218,6 +220,9 @@ mymain(void) DO_TEST("addr-more-than-32-sata-disks"); DO_TEST("addr-single-virtio-disk"); DO_TEST("addr-multiple-virtio-disks"); + DO_TEST("addr-isa-controller-on-slot-1"); + DO_TEST("addr-isa-controller-on-slot-31"); + DO_TEST_FAILURE("addr-non-isa-controller-on-slot-1"); =20 /* The same without 32 devs per controller support */ driver.bhyvecaps ^=3D BHYVE_CAP_AHCI32SLOT; diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-= on-slot-1.xml b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controll= er-on-slot-1.xml new file mode 100644 index 0000000000..db84185fe6 --- /dev/null +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-on-slot= -1.xml @@ -0,0 +1,36 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 219136 + 1 + + hvm + + + + destroy + restart + destroy + + + + + +
+ + +
+ + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-= on-slot-31.xml b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-control= ler-on-slot-31.xml new file mode 100644 index 0000000000..6ab5e6ad1a --- /dev/null +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-on-slot= -31.xml @@ -0,0 +1,36 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 219136 + 1 + + hvm + + + + destroy + restart + destroy + + + + + +
+ + +
+ + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-isa-controller.xml b= /tests/bhyvexml2xmloutdata/bhyvexml2xmlout-isa-controller.xml new file mode 100644 index 0000000000..db84185fe6 --- /dev/null +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-isa-controller.xml @@ -0,0 +1,36 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 219136 + 1 + + hvm + + + + destroy + restart + destroy + + + + + +
+ + +
+ + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2xmltest.c b/tests/bhyvexml2xmltest.c index ed421b8839..4b7f59ea29 100644 --- a/tests/bhyvexml2xmltest.c +++ b/tests/bhyvexml2xmltest.c @@ -111,6 +111,7 @@ mymain(void) DO_TEST_DIFFERENT("vnc-vgaconf-io"); DO_TEST_DIFFERENT("vnc-autoport"); DO_TEST_DIFFERENT("commandline"); + DO_TEST_DIFFERENT("isa-controller"); =20 /* Address allocation tests */ DO_TEST_DIFFERENT("addr-single-sata-disk"); @@ -118,6 +119,8 @@ mymain(void) DO_TEST_DIFFERENT("addr-more-than-32-sata-disks"); DO_TEST_DIFFERENT("addr-single-virtio-disk"); DO_TEST_DIFFERENT("addr-multiple-virtio-disks"); + DO_TEST_DIFFERENT("addr-isa-controller-on-slot-1"); + DO_TEST_DIFFERENT("addr-isa-controller-on-slot-31"); =20 /* The same without 32 devs per controller support */ driver.bhyvecaps ^=3D BHYVE_CAP_AHCI32SLOT; --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 02:08:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1550408834325107.66453569819487; Sun, 17 Feb 2019 05:07:14 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C267F11DB9C; Sun, 17 Feb 2019 13:07:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DB9A16D3C; Sun, 17 Feb 2019 13:07:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 45E903F605; Sun, 17 Feb 2019 13:07:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1HD4Xxh016401 for ; Sun, 17 Feb 2019 08:04:33 -0500 Received: by smtp.corp.redhat.com (Postfix) id BC7AD60C4C; Sun, 17 Feb 2019 13:04:33 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4A2C60C47 for ; Sun, 17 Feb 2019 13:04:30 +0000 (UTC) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF103A4536 for ; Sun, 17 Feb 2019 13:04:27 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id n15so10327879lfe.5 for ; Sun, 17 Feb 2019 05:04:27 -0800 (PST) Received: from kloomba.my.domain ([213.147.206.165]) by smtp.gmail.com with ESMTPSA id p15sm2782242lfc.88.2019.02.17.05.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 05:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=92IAs6urhhUmpm1TiVGiUEYppyDT2gjhemEP7npZiIc=; b=FR6SMXAuaB/CWdx91NclYxf7KxeFjyWxsWU1cA6GRnk+MZaKVR68+2f/e2sJ3lt9d1 20GlM68T3Z/rN+IbjvokD4oGBb2xcu7IpPdQpBNs14BIwEZZbkTB8n0GTgGBNgoHN4J/ FPGYaWBKDkNRqkElRHc1nvujH356JrLk841lT2rT8/Vnd4tfdh+4cauv4Or9p9hF/nse rRMtcsrZO67FFGpnrxmfz2ow8aKmKinRlm3wAIHIjOOSeYhdJuY64e+ZkoeMItn7E+2U N3UaffiVthknxzAykVkLcsSV32YN58j7WRpt0Ppxsi8/Vhdj5jViqhasGfwKih3gM5Ix obTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=92IAs6urhhUmpm1TiVGiUEYppyDT2gjhemEP7npZiIc=; b=Nyhh82031tqenh1Zs4ijYmSbuc9I6pZeSo77Bk4bJH4/Z9MGaEAQacWo1yr/WIP7Kv m8dWu8pvyXEY5OpsxMo0MHguXg3nWYt9vPaFpAZR6GBx2OWLlKEEyjETZ0ACP6eyBTOv jCWB2A1S+X6+ZCgRzDHQttNyUnjhHqFYb3sfPuQXZn1AKPBWCvFfyuau1QdYDtKFe/HN Oe0+n10NhbMZx59mCuCfNj1cfndli9RqdYBY6T9SGUV+FFgbwuiVSdzi4EJGDZhlgx7V ga+zJXWrHozwDvPhMbREk9sJBo5sNMsl/5ftebgSOodF+gcIjSp0B0olJ0WctPQejFX7 37/w== X-Gm-Message-State: AHQUAuaxMDLcMlvdiAp3JU/w4/bHH0ZYjXwFxhtbvm1t0aOKe0Ia7GgR KT7WRaWos7m5uR4rjGo9H2oL8DZa X-Google-Smtp-Source: AHgI3IYzYqHrD6h4JV7QIXeawbPBAPZB150v9AR89k43bc0ZYJUIKIorrToiaKQKMru564chLfUYPA== X-Received: by 2002:a19:2242:: with SMTP id i63mr10785613lfi.39.1550408665714; Sun, 17 Feb 2019 05:04:25 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 17 Feb 2019 17:04:03 +0400 Message-Id: <20190217130405.4328-5-bogorodskiy@gmail.com> In-Reply-To: <20190217130405.4328-1-bogorodskiy@gmail.com> References: <20190217130405.4328-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sun, 17 Feb 2019 13:04:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sun, 17 Feb 2019 13:04:28 +0000 (UTC) for IP:'209.85.167.65' DOMAIN:'mail-lf1-f65.google.com' HELO:'mail-lf1-f65.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.167.65 mail-lf1-f65.google.com 209.85.167.65 mail-lf1-f65.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH v2 4/6] bhyve: automatically add 'isa' controller X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 17 Feb 2019 13:07:13 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When domain configuration requires the 'isa' controller to be present, automatically add it on domain post-parse stage. Now, as this controller is always available when needed, it's not necessary to implicitly add it to the bhyve command line, so remove bhyveBuildLPCArgStr(). Also, make bhyveDomainDefNeedsISAController() static as it's no longer used outside of bhyve_domain.c. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 11 ----------- src/bhyve/bhyve_domain.c | 7 ++++++- src/bhyve/bhyve_domain.h | 2 -- tests/bhyvexml2argvdata/bhyvexml2argv-console.args | 2 +- .../bhyvexml2argv-serial-grub-nocons.args | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-serial-grub.args | 2 +- tests/bhyvexml2argvdata/bhyvexml2argv-serial.args | 2 +- tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args | 4 ++-- .../bhyvexml2argvdata/bhyvexml2argv-vnc-autoport.args | 4 ++-- .../bhyvexml2argv-vnc-vgaconf-io.args | 4 ++-- .../bhyvexml2argv-vnc-vgaconf-off.args | 4 ++-- .../bhyvexml2argv-vnc-vgaconf-on.args | 4 ++-- tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args | 4 ++-- tests/bhyvexml2xmloutdata/bhyvexml2xmlout-console.xml | 3 +++ .../bhyvexml2xmlout-serial-grub-nocons.xml | 3 +++ .../bhyvexml2xmlout-serial-grub.xml | 3 +++ tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial.xml | 3 +++ .../bhyvexml2xmlout-vnc-autoport.xml | 3 +++ .../bhyvexml2xmlout-vnc-vgaconf-io.xml | 3 +++ .../bhyvexml2xmlout-vnc-vgaconf-off.xml | 3 +++ .../bhyvexml2xmlout-vnc-vgaconf-on.xml | 3 +++ tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml | 3 +++ 22 files changed, 49 insertions(+), 30 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 2c90265a93..6e0af3892e 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -325,14 +325,6 @@ bhyveBuildVirtIODiskArgStr(const virDomainDef *def ATT= RIBUTE_UNUSED, return 0; } =20 -static int -bhyveBuildLPCArgStr(const virDomainDef *def ATTRIBUTE_UNUSED, - virCommandPtr cmd) -{ - virCommandAddArgList(cmd, "-s", "1,lpc", NULL); - return 0; -} - static int bhyveBuildGraphicsArgStr(const virDomainDef *def, virDomainGraphicsDefPtr graphics, @@ -634,9 +626,6 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, } } =20 - if (nisacontrollers =3D=3D 0 && bhyveDomainDefNeedsISAController(def)) - bhyveBuildLPCArgStr(def, cmd); - if (bhyveBuildConsoleArgStr(def, cmd) < 0) goto error; =20 diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index e476ef7e7d..68f66904a3 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -61,7 +61,7 @@ virDomainXMLPrivateDataCallbacks virBhyveDriverPrivateDat= aCallbacks =3D { .free =3D bhyveDomainObjPrivateFree, }; =20 -bool +static bool bhyveDomainDefNeedsISAController(virDomainDefPtr def) { if ((def->os.bootloader =3D=3D NULL && def->os.loader) || @@ -83,6 +83,11 @@ bhyveDomainDefPostParse(virDomainDefPtr def, VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROO= T) < 0) return -1; =20 + if (bhyveDomainDefNeedsISAController(def)) + if (virDomainDefMaybeAddController(def, VIR_DOMAIN_CONTROLLER_TYPE= _ISA, 1, + VIR_DOMAIN_CONTROLLER_MODEL_ISA= _BRIDGE) < 0) + return -1; + return 0; } =20 diff --git a/src/bhyve/bhyve_domain.h b/src/bhyve/bhyve_domain.h index 03a2b369d9..5f94038e89 100644 --- a/src/bhyve/bhyve_domain.h +++ b/src/bhyve/bhyve_domain.h @@ -41,6 +41,4 @@ extern virDomainXMLPrivateDataCallbacks virBhyveDriverPri= vateDataCallbacks; extern virDomainDefParserConfig virBhyveDriverDomainDefParserConfig; extern virDomainXMLNamespace virBhyveDriverDomainXMLNamespace; =20 -bool bhyveDomainDefNeedsISAController(virDomainDefPtr def); - #endif /* LIBVIRT_BHYVE_DOMAIN_H */ diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-console.args b/tests/bhy= vexml2argvdata/bhyvexml2argv-console.args index 6ab91ae7e4..25fbd4727e 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-console.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-console.args @@ -5,7 +5,7 @@ -H \ -P \ -s 0:0,hostbridge \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:b1:42:eb \ --s 1,lpc \ -l com1,/dev/nmdm0A bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub-nocons.args = b/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub-nocons.args index 42a278208d..02846cb893 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub-nocons.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub-nocons.args @@ -5,7 +5,7 @@ -H \ -P \ -s 0:0,hostbridge \ +-s 1:0,lpc \ -s 2:0,ahci-hd,/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:a7:cd:5b \ --s 1,lpc \ -l com1,/dev/nmdm0A bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub.args b/tests= /bhyvexml2argvdata/bhyvexml2argv-serial-grub.args index 313724dc90..e4712b448c 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub.args @@ -5,7 +5,7 @@ -H \ -P \ -s 0:0,hostbridge \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:f0:72:11 \ --s 1,lpc \ -l com1,/dev/nmdm0A bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-serial.args b/tests/bhyv= exml2argvdata/bhyvexml2argv-serial.args index 059e457072..f45a190137 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-serial.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-serial.args @@ -5,7 +5,7 @@ -H \ -P \ -s 0:0,hostbridge \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:4f:f3:5b \ --s 1,lpc \ -l com1,/dev/nmdm0A bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args b/tests/bhyvex= ml2argvdata/bhyvexml2argv-uefi.args index 8ff8673ed4..937b066e8c 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args @@ -6,6 +6,6 @@ -P \ -s 0:0,hostbridge \ -l bootrom,/path/to/test.fd \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ --s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 \ --s 1,lpc bhyve +-s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-autoport.args b/test= s/bhyvexml2argvdata/bhyvexml2argv-vnc-autoport.args index 039526ff35..551469dabe 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-autoport.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-autoport.args @@ -6,7 +6,7 @@ -P \ -s 0:0,hostbridge \ -l bootrom,/path/to/test.fd \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 \ --s 4:0,fbuf,tcp=3D127.0.0.1:5900 \ --s 1,lpc bhyve +-s 4:0,fbuf,tcp=3D127.0.0.1:5900 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-io.args b/te= sts/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-io.args index da37971009..47022e84cf 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-io.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-io.args @@ -6,7 +6,7 @@ -P \ -s 0:0,hostbridge \ -l bootrom,/path/to/test.fd \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 \ --s 4:0,fbuf,tcp=3D127.0.0.1:5904,vga=3Dio \ --s 1,lpc bhyve +-s 4:0,fbuf,tcp=3D127.0.0.1:5904,vga=3Dio bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-off.args b/t= ests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-off.args index 70347ee0b6..923098f3db 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-off.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-off.args @@ -6,7 +6,7 @@ -P \ -s 0:0,hostbridge \ -l bootrom,/path/to/test.fd \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 \ --s 4:0,fbuf,tcp=3D127.0.0.1:5904,vga=3Doff \ --s 1,lpc bhyve +-s 4:0,fbuf,tcp=3D127.0.0.1:5904,vga=3Doff bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-on.args b/te= sts/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-on.args index d0e1d81e2a..9225f5d133 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-on.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-on.args @@ -6,7 +6,7 @@ -P \ -s 0:0,hostbridge \ -l bootrom,/path/to/test.fd \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 \ --s 4:0,fbuf,tcp=3D127.0.0.1:5904,vga=3Don \ --s 1,lpc bhyve +-s 4:0,fbuf,tcp=3D127.0.0.1:5904,vga=3Don bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args b/tests/bhyvexm= l2argvdata/bhyvexml2argv-vnc.args index 90889b8f39..cd7a543265 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args @@ -6,7 +6,7 @@ -P \ -s 0:0,hostbridge \ -l bootrom,/path/to/test.fd \ +-s 1:0,lpc \ -s 2:0,ahci,hd:/tmp/freebsd.img \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:00:00:00 \ --s 4:0,fbuf,tcp=3D127.0.0.1:5904 \ --s 1,lpc bhyve +-s 4:0,fbuf,tcp=3D127.0.0.1:5904 bhyve diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-console.xml b/tests/= bhyvexml2xmloutdata/bhyvexml2xmlout-console.xml index 78d4d30016..2b453ee640 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-console.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-console.xml @@ -20,6 +20,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub-nocons.x= ml b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub-nocons.xml index 845cb09e9f..e012d586c8 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub-nocons.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub-nocons.xml @@ -20,6 +20,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub.xml b/te= sts/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub.xml index 6c8fda32af..ecb13907df 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub.xml @@ -20,6 +20,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial.xml b/tests/b= hyvexml2xmloutdata/bhyvexml2xmlout-serial.xml index eb50cc05ad..6dd2b94be7 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial.xml @@ -20,6 +20,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-autoport.xml b/t= ests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-autoport.xml index d6cfe76b70..2c99dc6233 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-autoport.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-autoport.xml @@ -21,6 +21,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-io.xml b= /tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-io.xml index 9e470e432e..9d152e4079 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-io.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-io.xml @@ -21,6 +21,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-off.xml = b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-off.xml index 89c4ceac57..ece20ddbab 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-off.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-off.xml @@ -21,6 +21,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-on.xml b= /tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-on.xml index 86d8939364..f2942c91aa 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-on.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-on.xml @@ -21,6 +21,9 @@
+ +
+
diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml b/tests/bhyv= exml2xmloutdata/bhyvexml2xmlout-vnc.xml index 9e470e432e..9d152e4079 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml @@ -21,6 +21,9 @@
+ +
+
--=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 02:08:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1550408679244152.07881264789864; Sun, 17 Feb 2019 05:04:39 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0165EAFC36; Sun, 17 Feb 2019 13:04:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65A8C608C1; Sun, 17 Feb 2019 13:04:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D3874108D; Sun, 17 Feb 2019 13:04:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1HD4UsT016385 for ; Sun, 17 Feb 2019 08:04:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9A7D51024968; Sun, 17 Feb 2019 13:04:30 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90190101E846 for ; Sun, 17 Feb 2019 13:04:30 +0000 (UTC) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39ED05944F for ; Sun, 17 Feb 2019 13:04:29 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id m11so10318511lfc.6 for ; Sun, 17 Feb 2019 05:04:29 -0800 (PST) Received: from kloomba.my.domain ([213.147.206.165]) by smtp.gmail.com with ESMTPSA id p15sm2782242lfc.88.2019.02.17.05.04.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 05:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=57bJ9iBF7+eiqKZ1DmtFP9XhORlgRZ7VZs72Q1IteJ4=; b=HQ4JFPo7Mp7jP7/K/RHX7dux8q64JmQ+OVO+9adMxdG6pRs9LgmGxX/1e3DmAHvEZ0 yochUc/WGgnY93LpaYFdTW76nJC4L3Uixst70Azq6xVgTcYxPHT3Y/YVNQoYOLcqjsJY 0k9HZ/thnpJ89xJxq2GBK/JEpRaDjYA6nfQu3EtPXhXzcwNinNh7wVHtbQyp+JYA7mms WNNWD6dM7hDjj0ZAfv56ad9K+maIfTFmebLBQNF4Cj41IFW7yuUuxHqC0DZ+i2YOSS8U uY2oaJhaTGZwqU8ZnQ0SfkVa1gIimlDMJbaNNnGQoGZMTNl2NGW6y7YjhYAkWAWCklQ0 DGYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=57bJ9iBF7+eiqKZ1DmtFP9XhORlgRZ7VZs72Q1IteJ4=; b=McSdZuOjH0iL5xzfnyI1xVQ0AkoY45wGjhyW4u9oKTMumKwYZiXmnnmzBzopsB0oZ0 gU71InbRU5URk2ISmtNcYpj9UEJXdrrOn7d5kfUVqp1gmiubki/HfSkg+4WJz0mfhydN kUSsCuXihSdtTV5ym6bqAH3MyHeBhcIH1eJWtU6GrDdxONNCgtK3rLraov1h3+De0A09 wa8ST1Vo0myAVBId2HvKSUXwYZSfS8kDVbUHACkMpQoqtit06facMycWgeUld/lsFryj fNqx4njPpnm/RtvxWtm7bVCIwg171LF4NBsNmDdZ3/11BEercQmZiM+5KDUgx+IVxtju 7Eyw== X-Gm-Message-State: AHQUAuYul4ZgOaNVn6+59oy8mVtbCFc5TjRmv0q2Im98axuMvJ2lJcHD F73iJU4XWt0ONWmBQXo6Re6ov76o X-Google-Smtp-Source: AHgI3IapFjrOn7ntfnXHSuVlvYrN1pjR3VbKcZ7cmNY0nezur7Aq9yBY5AlKx5jr9wHQGTw5WN9SRw== X-Received: by 2002:a19:e305:: with SMTP id a5mr1957264lfh.69.1550408667287; Sun, 17 Feb 2019 05:04:27 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 17 Feb 2019 17:04:04 +0400 Message-Id: <20190217130405.4328-6-bogorodskiy@gmail.com> In-Reply-To: <20190217130405.4328-1-bogorodskiy@gmail.com> References: <20190217130405.4328-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 17 Feb 2019 13:04:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 17 Feb 2019 13:04:29 +0000 (UTC) for IP:'209.85.167.65' DOMAIN:'mail-lf1-f65.google.com' HELO:'mail-lf1-f65.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.167.65 mail-lf1-f65.google.com 209.85.167.65 mail-lf1-f65.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH v2 5/6] docs: bhyve: document isa-bridge addressing X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sun, 17 Feb 2019 13:04:37 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Document ability to specify LCP PCI-ISA bridge PCI address. Signed-off-by: Roman Bogorodskiy Reviewed-by: J=C3=A1n Tomko --- docs/drvbhyve.html.in | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index 2e9cf5551b..d31ce781cf 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -462,6 +462,28 @@ Example:

</domain> =20 +

LPC PCI-ISA bridge address

+ +

LPC PCI-ISA bridge is used in bhyve to attach serial ports and a boot R= OM. +By default, the bhyve driver assigns PCI slot 1 for it. +However, sometimes it may be necessary to use other slot for it. +For example, placing it on slot 31 instead of slot 1 will look like this:<= /p> + +

+<domain type=3D"bhyve">
+  ...
+  <devices>
+    ...
+    <controller type=3D'isa' index=3D'1' model=3D'isa-bridge'>
+      <address type=3D'pci' domain=3D'0x0000' bus=3D'0x00' slot=3D'0x1f=
' function=3D'0x0'/>
+    </controller>
+    ...
+  </devices>
+</domain>
+
+ +

This is supported since 5.1.0.

+

Pass-through of arbitrary bhyve commands =20

Since 5.1.0, it's possible to pass additio= nal command-line --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun May 5 02:08:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1550408829962373.54396277458613; Sun, 17 Feb 2019 05:07:09 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9EE023B73B; Sun, 17 Feb 2019 13:07:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 699686013C; Sun, 17 Feb 2019 13:07:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 19B413F602; Sun, 17 Feb 2019 13:07:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1HD4XlJ016395 for ; Sun, 17 Feb 2019 08:04:33 -0500 Received: by smtp.corp.redhat.com (Postfix) id 654C55D9CA; Sun, 17 Feb 2019 13:04:33 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F70D5DEFC for ; Sun, 17 Feb 2019 13:04:31 +0000 (UTC) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 860AC5944C for ; Sun, 17 Feb 2019 13:04:30 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id e27so10317844lfj.8 for ; Sun, 17 Feb 2019 05:04:30 -0800 (PST) Received: from kloomba.my.domain ([213.147.206.165]) by smtp.gmail.com with ESMTPSA id p15sm2782242lfc.88.2019.02.17.05.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 05:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4ur9S9w5pbhLUw5/jqciLSDKIVUVEuJ7vca8BYt+28o=; b=e+jSUSj4Sb9t8se/uBZPvwjMNOKVIEO4vj9xrFJnInvO2trqg/eBHA7k74NVfr2YdL Do+ScGqF1JHjazvhANc0pXiaAfgLQy8f/25sEfxA5Fu5sMvueKK1qjgAyptOYxvtWSne Dlm1Yx1lzdvPFGIbaqDds98f7Wu/+RSaBTX8E/rPflWHeuHTQfncbOvS4jfInehiqabB LFCq5+VZ3nvbUcGlqmKJ2Qejr91OIiWQ79NKHDHd64h8OBnjRsQJl2ol2qFb6JCfIUbt /6pAyP4ClkF0ydtvSLWCjBH0JIttXCpQ/txT7/B6tB3bmic4y1Mh1DzAEU3z3g+hkfDF b6CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4ur9S9w5pbhLUw5/jqciLSDKIVUVEuJ7vca8BYt+28o=; b=lD1i8mTw0bL+jwvDUYapRbNCwmTj7n3gA8qBe+BZUASU0spya6GT9+AqwvZeMpyi6o N7nptJPj1Ho3pYQyUjXqfIKXhfjrDk6NiwkFRGNv4NyuuaE/LpSNLF2e/ff0Be5oIs+E PkUHJlLrU+HHm/ri+r64ktot73rpa+fpleMKx2BMeY93qA1B//IsTu18QHac1py5CFKR 0n9TQMXvAH88kuA6zsN8QB/Fl/oXGOIHcOvJ+TE61jEBGbw/skQEwTObhNuNB8lztDqE QQawxu2Eq0ff291+pliA4RkWE6gEGrQo91mrsaI2Yn3lBtkL5AUyLQyl8lFhi4/SxntL 2TTA== X-Gm-Message-State: AHQUAuZ+qZPNtjVQX/jzWetBlBXq6Gn8WthBFQRjcGMdSSLrRJcoFzP+ Pg3D4g0gCtqoSuE2ilE4thPkh+n4 X-Google-Smtp-Source: AHgI3IYcpqdz1Nuygw9Y4njP8/U0b0W+aXVyCVlphgZfBFXchsQ+9tpl2KyACy25B/U3foJ65ExDGQ== X-Received: by 2002:a19:4284:: with SMTP id p126mr11443571lfa.139.1550408668702; Sun, 17 Feb 2019 05:04:28 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 17 Feb 2019 17:04:05 +0400 Message-Id: <20190217130405.4328-7-bogorodskiy@gmail.com> In-Reply-To: <20190217130405.4328-1-bogorodskiy@gmail.com> References: <20190217130405.4328-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 17 Feb 2019 13:04:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 17 Feb 2019 13:04:30 +0000 (UTC) for IP:'209.85.167.66' DOMAIN:'mail-lf1-f66.google.com' HELO:'mail-lf1-f66.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.167.66 mail-lf1-f66.google.com 209.85.167.66 mail-lf1-f66.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH v2 6/6] news: document bhyve isa-bridge changes X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 17 Feb 2019 13:07:08 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Roman Bogorodskiy Reviewed-by: J=C3=A1n Tomko --- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 8d6d58ae6a..e0c9c3590f 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -59,6 +59,16 @@ of the network's bridge element. + +

+ bhyve: allow to configure LPC PCI address + + + The bhyve driver now explicty models LPC PCI-ISA bridge, thus + allowing to specify PCI address for it instead of using + the default PCI slot 1. + +
--=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list