From nobody Wed May 8 16:27:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1550073682693634.7786190091457; Wed, 13 Feb 2019 08:01:22 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95C2A653C7; Wed, 13 Feb 2019 16:01:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C93960856; Wed, 13 Feb 2019 16:01:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 817D9181A00C; Wed, 13 Feb 2019 16:01:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1DG1Buh008289 for ; Wed, 13 Feb 2019 11:01:11 -0500 Received: by smtp.corp.redhat.com (Postfix) id 668A360856; Wed, 13 Feb 2019 16:01:11 +0000 (UTC) Received: from vhost2.laine.org (ovpn-118-13.phx2.redhat.com [10.3.118.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2303360863 for ; Wed, 13 Feb 2019 16:01:11 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Wed, 13 Feb 2019 11:01:06 -0500 Message-Id: <20190213160107.8501-1-laine@laine.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] util: fix memory leak in virFirewallDInterfaceSetZone() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 13 Feb 2019 16:01:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" commit 3bba4825 added the new function virFirewallDInterfaceSetZone() which calledsends virDBUSCallMethod a DBusMessage** for the reply message, but doesn't use the reply, and also doesn't free it. Since this arg is allowed to be NULL, this patch simply sets it to NULL so we don't have to deal with it. Signed-off-by: Laine Stump Reviewed-by: Andrea Bolognani --- src/util/virfirewalld.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 47bacdcf4a..f8965eea09 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -351,13 +351,12 @@ virFirewallDInterfaceSetZone(const char *iface, const char *zone) { DBusConnection *sysbus =3D virDBusGetSystemBus(); - DBusMessage *reply =3D NULL; =20 if (!sysbus) return -1; =20 return virDBusCallMethod(sysbus, - &reply, + NULL, NULL, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list