From nobody Tue Feb 10 17:07:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1549595351001891.1014724152719; Thu, 7 Feb 2019 19:09:11 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA645C057F3A; Fri, 8 Feb 2019 03:09:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E6E016BFF; Fri, 8 Feb 2019 03:09:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2D2C141F8A; Fri, 8 Feb 2019 03:09:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1838daF007793 for ; Thu, 7 Feb 2019 22:08:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id EA4EE16BFF; Fri, 8 Feb 2019 03:08:39 +0000 (UTC) Received: from vhost2.laine.org (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FC0F18E22; Fri, 8 Feb 2019 03:08:39 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Thu, 7 Feb 2019 22:08:30 -0500 Message-Id: <20190208030831.6790-4-laine@laine.org> In-Reply-To: <20190208030831.6790-1-laine@laine.org> References: <20190208030831.6790-1-laine@laine.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH 3/4] networks: remove stray use of brctl command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 08 Feb 2019 03:09:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" brctl has been deprecated for a long time, and distros are starting to remove it. "ip link blah type bridge" should be used instead. Signed-off-by: Laine Stump Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/networks/340-guest-network-bridge.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/networks/340-guest-network-bridge.t b/scripts/networks= /340-guest-network-bridge.t index e5db0ff..498bcb6 100644 --- a/scripts/networks/340-guest-network-bridge.t +++ b/scripts/networks/340-guest-network-bridge.t @@ -36,9 +36,9 @@ my $conn =3D eval { $tck->setup(); }; BAIL_OUT "failed to setup test harness: $@" if $@; END { $tck->cleanup if $tck; } =20 -((system "brctl addbr tck") =3D=3D 0) or die "cannot create bridge 'tck'"; +((system "ip link add name tck type bridge") =3D=3D 0) or die "cannot crea= te bridge 'tck'"; =20 -END { system "brctl delbr tck" } +END { system "ip link del tck" } =20 my $b =3D Sys::Virt::TCK::NetworkBuilder->new(name =3D> "tck"); $b->bridge("tck"); --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list