From nobody Tue Feb 10 08:27:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15495953511591016.1748354485354; Thu, 7 Feb 2019 19:09:11 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 342A1356D3; Fri, 8 Feb 2019 03:09:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E48F65C6A6; Fri, 8 Feb 2019 03:09:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 75F2518033A6; Fri, 8 Feb 2019 03:09:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x1838dQZ007783 for ; Thu, 7 Feb 2019 22:08:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id 64D241701C; Fri, 8 Feb 2019 03:08:39 +0000 (UTC) Received: from vhost2.laine.org (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B5EE450B; Fri, 8 Feb 2019 03:08:38 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Thu, 7 Feb 2019 22:08:29 -0500 Message-Id: <20190208030831.6790-3-laine@laine.org> In-Reply-To: <20190208030831.6790-1-laine@laine.org> References: <20190208030831.6790-1-laine@laine.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH 2/4] storage: fix/improve diagnostic messages X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Feb 2019 03:09:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Due to copy/paste, the tests for several other formats were described as "qcow". Also, a couple of messages didn't give the image format. Signed-off-by: Laine Stump Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/storage/100-create-vol-dir.t | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/storage/100-create-vol-dir.t b/scripts/storage/100-cre= ate-vol-dir.t index 6262d69..9663d28 100644 --- a/scripts/storage/100-create-vol-dir.t +++ b/scripts/storage/100-create-vol-dir.t @@ -94,7 +94,7 @@ is($st->size, 1024*1024*50, "size is 50M"); # overhead for a file ok($st->blocks >=3D (1024*1024*50/512), "alot of blocks allocated"); =20 -lives_ok(sub { $vol->delete(0) }, "deleted volume"); +lives_ok(sub { $vol->delete(0) }, "deleted raw volume"); =20 =20 =20 @@ -104,7 +104,7 @@ SKIP: { skip "qcow1 format not supported", 4; } =20 - ok_volume(sub { $vol =3D $pool->create_volume($volqcow1xml) }, "create= qcow volume"); + ok_volume(sub { $vol =3D $pool->create_volume($volqcow1xml) }, "create= qcow1 volume"); =20 $path =3D xpath($vol, "string(/volume/target/path)"); $st =3D stat($path); @@ -121,7 +121,7 @@ SKIP: { =20 =20 =20 -ok_volume(sub { $vol =3D $pool->create_volume($volqcow2xml) }, "create qco= w volume"); +ok_volume(sub { $vol =3D $pool->create_volume($volqcow2xml) }, "create qco= w2 volume"); =20 $path =3D xpath($vol, "string(/volume/target/path)"); $st =3D stat($path); @@ -132,12 +132,12 @@ ok($st, "path $path exists"); # should be quite small :-) ok($st->size < 1024*1024, "basic qcow2 header is allocated"); =20 -lives_ok(sub { $vol->delete(0) }, "deleted volume"); +lives_ok(sub { $vol->delete(0) }, "deleted qcow2 volume"); =20 =20 =20 =20 -ok_volume(sub { $vol =3D $pool->create_volume($volvmdkxml) }, "create qcow= volume"); +ok_volume(sub { $vol =3D $pool->create_volume($volvmdkxml) }, "create vmdk= volume"); =20 $path =3D xpath($vol, "string(/volume/target/path)"); $st =3D stat($path); @@ -148,12 +148,12 @@ ok($st, "path $path exists"); # should be quite small :-) ok($st->size < 1024*1024, "basic vmdk header is allocated"); =20 -lives_ok(sub { $vol->delete(0) }, "deleted volume"); +lives_ok(sub { $vol->delete(0) }, "deleted vmdk volume"); =20 =20 =20 =20 -ok_volume(sub { $vol =3D $pool->create_volume($volvpcxml) }, "create qcow = volume"); +ok_volume(sub { $vol =3D $pool->create_volume($volvpcxml) }, "create vpc v= olume"); =20 $path =3D xpath($vol, "string(/volume/target/path)"); $st =3D stat($path); @@ -164,5 +164,5 @@ ok($st, "path $path exists"); # should be quite small :-) ok($st->size < 1024*1024, "basic vpc header is allocated"); =20 -lives_ok(sub { $vol->delete(0) }, "deleted volume"); +lives_ok(sub { $vol->delete(0) }, "deleted vpc volume"); =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list