[libvirt] [PATCH 0/9] qemu: Make qemu_domain more organized and consistent

Andrea Bolognani posted 9 patches 2 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190206134655.10457-1-abologna@redhat.com
src/qemu/qemu_capabilities.c   |  10 +-
src/qemu/qemu_domain.c         | 250 +++++++++++++++++++++------------
src/qemu/qemu_domain.h         |  29 ++--
src/qemu/qemu_domain_address.c |  22 ---
4 files changed, 175 insertions(+), 136 deletions(-)

[libvirt] [PATCH 0/9] qemu: Make qemu_domain more organized and consistent

Posted by Andrea Bolognani 2 weeks ago
A while ago I was looking at the code and got annoyed by the lack
of consistency, both internal and external. This series addresses
most of it.

Andrea Bolognani (9):
  qemu: Remove redundant condition
  qemu: Use more specific prefixes
  qemu: Move functions around
  qemu: Add arch parameter to qemuDomainMachine*()
  qemu: Add arch checks to qemuDomainMachine*()
  qemu: Remove useless ARCH_IS_X86() call
  qemu: Make most qemuDomainMachine*() functions static
  qemu: Move qemuDomainSupportsPCI() to qemu_domain
  qemu: Unify style for qemuDomain*()

 src/qemu/qemu_capabilities.c   |  10 +-
 src/qemu/qemu_domain.c         | 250 +++++++++++++++++++++------------
 src/qemu/qemu_domain.h         |  29 ++--
 src/qemu/qemu_domain_address.c |  22 ---
 4 files changed, 175 insertions(+), 136 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/9] qemu: Make qemu_domain more organized and consistent

Posted by Michal Privoznik 1 week ago
On 2/6/19 2:46 PM, Andrea Bolognani wrote:
> A while ago I was looking at the code and got annoyed by the lack
> of consistency, both internal and external. This series addresses
> most of it.
> 
> Andrea Bolognani (9):
>    qemu: Remove redundant condition
>    qemu: Use more specific prefixes
>    qemu: Move functions around
>    qemu: Add arch parameter to qemuDomainMachine*()
>    qemu: Add arch checks to qemuDomainMachine*()
>    qemu: Remove useless ARCH_IS_X86() call
>    qemu: Make most qemuDomainMachine*() functions static
>    qemu: Move qemuDomainSupportsPCI() to qemu_domain
>    qemu: Unify style for qemuDomain*()
> 
>   src/qemu/qemu_capabilities.c   |  10 +-
>   src/qemu/qemu_domain.c         | 250 +++++++++++++++++++++------------
>   src/qemu/qemu_domain.h         |  29 ++--
>   src/qemu/qemu_domain_address.c |  22 ---
>   4 files changed, 175 insertions(+), 136 deletions(-)
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list