From nobody Mon Feb 9 03:13:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1548938512824922.9803364028259; Thu, 31 Jan 2019 04:41:52 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80BBDC070460; Thu, 31 Jan 2019 12:41:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 49978600C6; Thu, 31 Jan 2019 12:41:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A5DAF3F7CD; Thu, 31 Jan 2019 12:41:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0VCfl5N006828 for ; Thu, 31 Jan 2019 07:41:48 -0500 Received: by smtp.corp.redhat.com (Postfix) id EDDDB5D97E; Thu, 31 Jan 2019 12:41:47 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E45335D97A for ; Thu, 31 Jan 2019 12:41:47 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6FF2804FF for ; Thu, 31 Jan 2019 12:41:46 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id k15-v6so2530643ljc.8 for ; Thu, 31 Jan 2019 04:41:46 -0800 (PST) Received: from kloomba.my.domain ([95.104.143.231]) by smtp.gmail.com with ESMTPSA id c20sm795240lfj.67.2019.01.31.04.41.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 04:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+YLjFfAzIY7l/B4JZPRCpcaKfMI8lgIw2lpptm5Znss=; b=VEo0nzzK+CwRBBn6DR8ODoUYF2q99ZA3IkkE0sxx28E/2Oxl/Ke6uWg1JUy1WSGg6T VxmiDXV1XQagspg8ZkLQc3CcE8CfMlaZDpdXZyxUa62XWiT49Tj4ZCOhIhCEo+EXlD0z 0W1irewNy6tPKrKBpb7Y6RdckykDwZKvGOb3Tu6yvNXQDk5oiPK0MzkuKDYQm/asfTdT wATgVSCwhpH5z/Sqj9MU+pYr8XHY1MRa4NYu1wemj5kLfkrzWw0Oqfj4S1n3kY8hfFIP tDegkh47IGrr/31TeUKLK33UeegJKIovm4C7NSFworWcFCve4hRDMQRFrNppjI/YYQH6 51mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+YLjFfAzIY7l/B4JZPRCpcaKfMI8lgIw2lpptm5Znss=; b=ZpYuPqJL5WHpWHWy+kA8xLbtzygwlxAtPni8E+lATWXYRCPxpqzk67kJvgcrD7/Zu6 +0EbqN3dW5+nuF6zs9i8DBaBQRyPpN0wknvMcdae/vDiK/3+XcXnq7f+EofX7q9bYBA6 KhSFlB/Iq2ofkp6vVPOqKFWY6ZEnSn2ceLFR/r9sdy4Yjor95V/EcM9cm4MOhmpZU+/H XXXFb28yh74gWXd0XA8TOhuJPXxf/u/4op7UWJPajVmiqLIf0aAO0wdxUKA3n8pIll7h QS6f9mqZw42K7LK+SwcSAf8H5lPYWmpp1bzl/3cM0eKN0/Q0cXRoOkKEyh7/G1IHk5ui jpbg== X-Gm-Message-State: AJcUukd6J4zt7nSvJvIaaWttGaztQXh9REMfQv1BFUdU7np/MoraeR66 Li4bqAqLwO3Bljg4t0+u2vw2Dc7b X-Google-Smtp-Source: ALg8bN5n02ttb91Dqh0RKQNLelPBG2zeCVFP0FV8pmALcXjDX9KxVAwJCPZ75NsvCSpdJIjcHu4T5Q== X-Received: by 2002:a2e:908b:: with SMTP id l11-v6mr27584657ljg.150.1548938504686; Thu, 31 Jan 2019 04:41:44 -0800 (PST) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Thu, 31 Jan 2019 16:41:25 +0400 Message-Id: <20190131124126.65560-3-bogorodskiy@gmail.com> In-Reply-To: <20190131124126.65560-1-bogorodskiy@gmail.com> References: <20190131124126.65560-1-bogorodskiy@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 31 Jan 2019 12:41:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 31 Jan 2019 12:41:46 +0000 (UTC) for IP:'209.85.208.196' DOMAIN:'mail-lj1-f196.google.com' HELO:'mail-lj1-f196.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.208.196 mail-lj1-f196.google.com 209.85.208.196 mail-lj1-f196.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH 2/3] bhyve: emit warning when using bhyve:commandline X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 31 Jan 2019 12:41:51 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When using custom command line arguments, warn that this configuration is not fully supported. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index a1ae2026a0..1f215dac08 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -630,6 +630,10 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, if (def->namespaceData) { bhyveDomainCmdlineDefPtr bhyvecmd; =20 + VIR_WARN("Booting the guest using command line pass-through featur= e, " + "which could potentially cause inconsistent state and " + "upgrade issues"); + bhyvecmd =3D def->namespaceData; for (i =3D 0; i < bhyvecmd->num_args; i++) virCommandAddArg(cmd, bhyvecmd->args[i]); --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list