From nobody Sun Apr 28 22:32:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1548860751542175.72025704207283; Wed, 30 Jan 2019 07:05:51 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C27B4806B5; Wed, 30 Jan 2019 15:05:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E893960462; Wed, 30 Jan 2019 15:05:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 77CC13F602; Wed, 30 Jan 2019 15:05:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0UEebwi012228 for ; Wed, 30 Jan 2019 09:40:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9BF90608C6; Wed, 30 Jan 2019 14:40:37 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.net.com (ovpn-116-45.phx2.redhat.com [10.3.116.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58AC3608C1 for ; Wed, 30 Jan 2019 14:40:37 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Wed, 30 Jan 2019 09:40:29 -0500 Message-Id: <20190130144030.13145-2-jferlan@redhat.com> In-Reply-To: <20190130144030.13145-1-jferlan@redhat.com> References: <20190130144030.13145-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] tests: Fix build issue with storagevolxml2xmltest X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 30 Jan 2019 15:05:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit 7a227688a caused a build failure on mingw. Following other uses of including ../src/libvirt_driver_storage_impl.la I moved to under the WITH_STORAGE conditional. Signed-off-by: John Ferlan --- tests/Makefile.am | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index ab4c716529..c034fe0bf3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -368,6 +368,7 @@ if WITH_STORAGE test_programs +=3D storagevolxml2argvtest test_programs +=3D storagepoolxml2argvtest test_programs +=3D virstorageutiltest +test_programs +=3D storagepoolxml2xmltest endif WITH_STORAGE =20 if WITH_STORAGE_FS @@ -384,7 +385,7 @@ test_programs +=3D nsstest nssguesttest test_libraries +=3D nssmock.la endif WITH_NSS =20 -test_programs +=3D storagevolxml2xmltest storagepoolxml2xmltest +test_programs +=3D storagevolxml2xmltest =20 test_programs +=3D nodedevxml2xmltest =20 @@ -924,9 +925,17 @@ storagepoolxml2argvtest_LDADD =3D \ ../src/libvirt_util.la \ $(LDADDS) =20 +storagepoolxml2xmltest_SOURCES =3D \ + storagepoolxml2xmltest.c \ + testutils.c testutils.h +storagepoolxml2xmltest_LDADD =3D $(LDADDS) \ + ../src/libvirt_driver_storage_impl.la \ + $(GNULIB_LIBS) + else ! WITH_STORAGE EXTRA_DIST +=3D storagevolxml2argvtest.c EXTRA_DIST +=3D virstorageutiltest.c +EXTRA_DIST +=3D storagepoolxml2xmltest.c endif ! WITH_STORAGE =20 storagevolxml2xmltest_SOURCES =3D \ @@ -934,13 +943,6 @@ storagevolxml2xmltest_SOURCES =3D \ testutils.c testutils.h storagevolxml2xmltest_LDADD =3D $(LDADDS) =20 -storagepoolxml2xmltest_SOURCES =3D \ - storagepoolxml2xmltest.c \ - testutils.c testutils.h -storagepoolxml2xmltest_LDADD =3D $(LDADDS) \ - ../src/libvirt_driver_storage_impl.la \ - $(GNULIB_LIBS) - nodedevxml2xmltest_SOURCES =3D \ nodedevxml2xmltest.c \ testutils.c testutils.h --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun Apr 28 22:32:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1548860763443886.184544014246; Wed, 30 Jan 2019 07:06:03 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE65CC0528BD; Wed, 30 Jan 2019 15:05:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A748718807; Wed, 30 Jan 2019 15:05:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 30CC23F608; Wed, 30 Jan 2019 15:05:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0UEecJE012233 for ; Wed, 30 Jan 2019 09:40:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id 125CD608C6; Wed, 30 Jan 2019 14:40:38 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.net.com (ovpn-116-45.phx2.redhat.com [10.3.116.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4B8C608C1 for ; Wed, 30 Jan 2019 14:40:37 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Wed, 30 Jan 2019 09:40:30 -0500 Message-Id: <20190130144030.13145-3-jferlan@redhat.com> In-Reply-To: <20190130144030.13145-1-jferlan@redhat.com> References: <20190130144030.13145-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] tests: Add storagepoolxml2argvtest source to EXTRA_DIST X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 30 Jan 2019 15:06:01 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit f2f84b4d4 added storagepoolxml2argvtest processing; however, it didn't follow alter the else to !WITH_STORAGE and add the source itself to the EXTRA_DIST like the other WITH_STORAGE options for virstorageutiltest and storagevolxml2argvtest. Signed-off-by: John Ferlan --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index c034fe0bf3..bdf7154fd5 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -935,6 +935,7 @@ storagepoolxml2xmltest_LDADD =3D $(LDADDS) \ else ! WITH_STORAGE EXTRA_DIST +=3D storagevolxml2argvtest.c EXTRA_DIST +=3D virstorageutiltest.c +EXTRA_DIST +=3D storagepoolxml2argvtest.c EXTRA_DIST +=3D storagepoolxml2xmltest.c endif ! WITH_STORAGE =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list