On 1/30/19 3:40 PM, John Ferlan wrote:
> Recent adjustment to add XML namespace processing for storage pool
> XML processing broke the mingw* builds:
>
> CC storagevolxml2xmltest.o
> gmake[2]: *** No rule to make target '../src/libvirt_driver_storage_impl.la', needed by 'storagepoolxml2xmltest.exe'. Stop.
> gmake[2]: *** Waiting for unfinished jobs....
> CC storagepoolxml2xmltest.o
>
> So looking at things again, I see that other options that include
> ../src/libvirt_driver_storage_impl.la would be inside a WITH_STORAGE
> conditional. So move the build to that and alter the ! WITH_STORAGE
> as well.
>
> Seeing this, I also see that I didn't add storagepoolxml2argv.c to
> the ! WITH_STORAGE either, so that's the second patch.
>
> Build works for me, but I have no idea if it'll work for mingw* -
> I am assuming so based on other examples. Another alternative is
> to not test the XML namespace processing for storagepoolxml2xml -
> although given that it seems mingw* doesn't build/support storage
> anyway, perhaps not the correct alternative.
>
> John Ferlan (2):
> tests: Fix build issue with storagevolxml2xmltest
> tests: Add storagepoolxml2argvtest source to EXTRA_DIST
>
> tests/Makefile.am | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
ACK
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list