[libvirt] [PATCH 0/2] virjson improvements [incremental backup saga]

Eric Blake posted 2 patches 5 years, 2 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190125040555.14382-1-eblake@redhat.com
src/util/virjson.h       |  2 ++
src/libvirt_private.syms |  1 +
src/util/virjson.c       | 28 +++++++++++++++++++++++++---
3 files changed, 28 insertions(+), 3 deletions(-)
[libvirt] [PATCH 0/2] virjson improvements [incremental backup saga]
Posted by Eric Blake 5 years, 2 months ago
Upstream qemu stabilized the QMP command block-dirty-bitmap-merge
to take an array of strings as the sources to merge into a destination
bitmap; this is a lot nicer for libvirt, compared to the alternative
where qemu 3.1 x-block-dirty-bitmap-merge had to be called multiple
times with the potential for some odd cleanup after partial failure
scenarios.

This series prepares virjson for use in my incremental backup work.

Eric Blake (2):
  virjson: always raise vir error on append failures
  virjson: add convenience wrapper for appending string to array

 src/util/virjson.h       |  2 ++
 src/libvirt_private.syms |  1 +
 src/util/virjson.c       | 28 +++++++++++++++++++++++++---
 3 files changed, 28 insertions(+), 3 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] virjson improvements [incremental backup saga]
Posted by Ján Tomko 5 years, 2 months ago
On Thu, Jan 24, 2019 at 10:05:53PM -0600, Eric Blake wrote:
>Upstream qemu stabilized the QMP command block-dirty-bitmap-merge
>to take an array of strings as the sources to merge into a destination
>bitmap; this is a lot nicer for libvirt, compared to the alternative
>where qemu 3.1 x-block-dirty-bitmap-merge had to be called multiple
>times with the potential for some odd cleanup after partial failure
>scenarios.
>
>This series prepares virjson for use in my incremental backup work.
>
>Eric Blake (2):
>  virjson: always raise vir error on append failures
>  virjson: add convenience wrapper for appending string to array
>
> src/util/virjson.h       |  2 ++
> src/libvirt_private.syms |  1 +
> src/util/virjson.c       | 28 +++++++++++++++++++++++++---
> 3 files changed, 28 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list