[libvirt] [PATCH v3 00/11] Allow adding mountOpts to the storage pool mount command

John Ferlan posted 11 patches 5 years, 2 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190116010922.28250-1-jferlan@redhat.com
There is a newer version of this series
docs/formatstorage.html.in                    | 137 +++++++++++++++
docs/schemas/storagepool.rng                  |  70 ++++++++
src/conf/storage_conf.c                       | 120 ++++++++++++-
src/conf/storage_conf.h                       |  40 +++++
src/libvirt_private.syms                      |   1 +
src/storage/storage_backend_fs.c              | 128 ++++++++++++++
src/storage/storage_backend_rbd.c             | 166 +++++++++++++++++-
src/storage/storage_util.c                    |  47 +++++
src/storage/storage_util.h                    |  14 ++
tests/Makefile.am                             |   4 +-
.../pool-netfs-mountopts.argv                 |   1 +
.../pool-netfs-ns-mountopts.argv              |   2 +
.../pool-netfs-protocol-ver.argv              |   1 +
tests/storagepoolxml2argvtest.c               |   6 +
.../pool-netfs-mountopts.xml                  |  24 +++
.../pool-netfs-ns-mountopts.xml               |  29 +++
.../pool-netfs-protocol-ver.xml               |  21 +++
.../pool-rbd-ns-configopts.xml                |  17 ++
.../pool-netfs-mountopts.xml                  |  24 +++
.../pool-netfs-ns-mountopts.xml               |  29 +++
.../pool-netfs-protocol-ver.xml               |  21 +++
.../pool-rbd-ns-configopts.xml                |  20 +++
tests/storagepoolxml2xmltest.c                |   9 +
tools/virsh-pool.c                            |  44 ++++-
tools/virsh.pod                               |  10 ++
25 files changed, 977 insertions(+), 8 deletions(-)
create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-mountopts.argv
create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts.argv
create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-mountopts.xml
create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-ns-mountopts.xml
create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-protocol-ver.xml
create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ns-configopts.xml
create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-mountopts.xml
create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-ns-mountopts.xml
create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-protocol-ver.xml
create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ns-configopts.xml
[libvirt] [PATCH v3 00/11] Allow adding mountOpts to the storage pool mount command
Posted by John Ferlan 5 years, 2 months ago
v2: https://www.redhat.com/archives/libvir-list/2019-January/msg00164.html

Changes since v2:

 * Split out the noexec, nodev, nosuid, and (new) ro into the first
   3 patches as "known" or "supported" mount options that can be added.
   I avoided just adding them noexec, nodev, and nosuid by default.

 * Add patches 4-6 to essentially support the nfsvers option

 * The rest of the patches are reworked to add support for namespace
   at the pool level (as opposed to the v2 at the source level).

John Ferlan (11):
  conf: Add some defined NFS Storage Pool mount options
  storage: Add mountOpts to the storage pool mount command line
  virsh: Add source-mount-opts for pool commands
  conf: Add optional NFS Source Pool <protocol ver='n'/> option
  storage: Add the nfsvers to the command line
  virsh: Add source-protocol-ver for pool commands
  conf: Introduce virStoragePoolXMLNamespace
  nfs: Add infrastructure to manage XML namespace options
  docs,tests: Add schema, description, and tests for NFS namespace
  storage: Add NFS storage pool namespace options to command line
  rbd: Utilize storage pool namespace to manage config options

 docs/formatstorage.html.in                    | 137 +++++++++++++++
 docs/schemas/storagepool.rng                  |  70 ++++++++
 src/conf/storage_conf.c                       | 120 ++++++++++++-
 src/conf/storage_conf.h                       |  40 +++++
 src/libvirt_private.syms                      |   1 +
 src/storage/storage_backend_fs.c              | 128 ++++++++++++++
 src/storage/storage_backend_rbd.c             | 166 +++++++++++++++++-
 src/storage/storage_util.c                    |  47 +++++
 src/storage/storage_util.h                    |  14 ++
 tests/Makefile.am                             |   4 +-
 .../pool-netfs-mountopts.argv                 |   1 +
 .../pool-netfs-ns-mountopts.argv              |   2 +
 .../pool-netfs-protocol-ver.argv              |   1 +
 tests/storagepoolxml2argvtest.c               |   6 +
 .../pool-netfs-mountopts.xml                  |  24 +++
 .../pool-netfs-ns-mountopts.xml               |  29 +++
 .../pool-netfs-protocol-ver.xml               |  21 +++
 .../pool-rbd-ns-configopts.xml                |  17 ++
 .../pool-netfs-mountopts.xml                  |  24 +++
 .../pool-netfs-ns-mountopts.xml               |  29 +++
 .../pool-netfs-protocol-ver.xml               |  21 +++
 .../pool-rbd-ns-configopts.xml                |  20 +++
 tests/storagepoolxml2xmltest.c                |   9 +
 tools/virsh-pool.c                            |  44 ++++-
 tools/virsh.pod                               |  10 ++
 25 files changed, 977 insertions(+), 8 deletions(-)
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-mountopts.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-ns-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-protocol-ver.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ns-configopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-ns-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-protocol-ver.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ns-configopts.xml

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list