From nobody Sun Feb 8 21:18:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1547202230816387.46967530266056; Fri, 11 Jan 2019 02:23:50 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AECA23D473; Fri, 11 Jan 2019 10:23:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 740DB5C6C1; Fri, 11 Jan 2019 10:23:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4B455C584; Fri, 11 Jan 2019 10:23:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0BANc8S025036 for ; Fri, 11 Jan 2019 05:23:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id F17683818A; Fri, 11 Jan 2019 10:23:37 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7841C601A9 for ; Fri, 11 Jan 2019 10:23:35 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 11 Jan 2019 11:23:33 +0100 Message-Id: <20190111102333.20448-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] src: Don't use double-colon rules X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 11 Jan 2019 10:23:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" According to the GNU Make manual, "double-colon rules are somewhat obscure and not often very useful". Looking at the few instances we have in libvirt, that certainly seems to be the case, so just drop them. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- src/Makefile.am | 6 +++--- src/remote/Makefile.inc.am | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index cd386297ed..8c8dfe3dcf 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -816,14 +816,14 @@ if WITH_LIBVIRTD if LIBVIRT_INIT_SCRIPT_RED_HAT initdir =3D $(sysconfdir)/rc.d/init.d =20 -install-init:: $(SYSVINIT_FILES) install-sysconfig +install-init: $(SYSVINIT_FILES) install-sysconfig $(MKDIR_P) $(DESTDIR)$(initdir) for f in $(SYSVINIT_FILES:%.init=3D%) ; \ do \ $(INSTALL_SCRIPT) $$f.init $(DESTDIR)$(initdir)/$$f; \ done =20 -uninstall-init:: uninstall-sysconfig +uninstall-init: uninstall-sysconfig rm -f $(SYSVINIT_FILES:%.init=3D$(DESTDIR)$(initdir)/%) rmdir $(DESTDIR)$(initdir) || : =20 @@ -1010,7 +1010,7 @@ install-data-local: $(INSTALL_DATA_LOCAL) \ $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/filesystems" $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/boot" =20 -uninstall-local:: $(UNINSTALL_LOCAL) \ +uninstall-local: $(UNINSTALL_LOCAL) \ $(INSTALL_DATA_DIRS:%=3Duninstall-data-%) rmdir "$(DESTDIR)$(localstatedir)/cache/libvirt" ||: rmdir "$(DESTDIR)$(localstatedir)/lib/libvirt/images" ||: diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 0988435eed..3d0ff29548 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -213,7 +213,7 @@ polkitdir =3D $(datadir)/polkit-1 polkitactionsdir =3D $(polkitdir)/actions polkitrulesdir =3D $(polkitdir)/rules.d =20 -install-polkit:: +install-polkit: $(MKDIR_P) $(DESTDIR)$(polkitactionsdir) $(INSTALL_DATA) $(srcdir)/remote/libvirtd.policy \ $(DESTDIR)$(polkitactionsdir)/org.libvirt.unix.policy @@ -221,7 +221,7 @@ install-polkit:: $(INSTALL_DATA) $(srcdir)/remote/libvirtd.rules \ $(DESTDIR)$(polkitrulesdir)/50-libvirt.rules =20 -uninstall-polkit:: +uninstall-polkit: rm -f $(DESTDIR)$(polkitactionsdir)/org.libvirt.unix.policy rmdir $(DESTDIR)$(polkitactionsdir) || : rm -f $(DESTDIR)$(polkitrulesdir)/50-libvirt.rules --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list