From nobody Mon Feb 9 21:19:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545381403368411.2431841151399; Fri, 21 Dec 2018 00:36:43 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA167C0221; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83D7E100194B; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 26CC53F7D0; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8aapf032588 for ; Fri, 21 Dec 2018 03:36:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 59AD3608E8; Fri, 21 Dec 2018 08:36:36 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 693B01823E for ; Fri, 21 Dec 2018 08:36:35 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:22 +0100 Message-Id: <20181221083627.21819-3-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 2/7] guests: Remove casts for OS details X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 21 Dec 2018 08:36:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We're always storing os_version as string now, so casting it before use has become unnecessary. Signed-off-by: Andrea Bolognani --- guests/lcitool | 2 +- guests/playbooks/update/tasks/packages.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index f63122d..759eff6 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -498,7 +498,7 @@ class Application: facts =3D self._inventory.get_facts(host) package_format =3D facts["package_format"] os_name =3D facts["os_name"] - os_version =3D str(facts["os_version"]) + os_version =3D facts["os_version"] os_full =3D os_name + os_version =20 if package_format not in ["deb", "rpm"]: diff --git a/guests/playbooks/update/tasks/packages.yml b/guests/playbooks/= update/tasks/packages.yml index 8cebb5f..7fdfc45 100644 --- a/guests/playbooks/update/tasks/packages.yml +++ b/guests/playbooks/update/tasks/packages.yml @@ -46,11 +46,11 @@ =20 - name: '{{ project }}: Look up mappings (OS version)' set_fact: - temp: '{{ temp|combine({ item: mappings[item][os_name + os_version|str= ing] }) }}' + temp: '{{ temp|combine({ item: mappings[item][os_name + os_version] })= }}' with_items: '{{ packages }}' when: - - mappings[item][os_name + os_version|string] is defined + - mappings[item][os_name + os_version] is defined =20 - set_fact: flattened: [] --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list