From nobody Mon Feb 9 12:24:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545381400858544.8113099465652; Fri, 21 Dec 2018 00:36:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C0DC420A4; Fri, 21 Dec 2018 08:36:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1275C17249; Fri, 21 Dec 2018 08:36:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1B32C181B9EB; Fri, 21 Dec 2018 08:36:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8aYVf032526 for ; Fri, 21 Dec 2018 03:36:34 -0500 Received: by smtp.corp.redhat.com (Postfix) id E42661823E; Fri, 21 Dec 2018 08:36:34 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8EB6B608E8 for ; Fri, 21 Dec 2018 08:36:33 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:21 +0100 Message-Id: <20181221083627.21819-2-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 1/7] guests: Store OS details as strings X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 21 Dec 2018 08:36:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" When parsing something like os_version: 9 YAML will, somewhat reasonably, decide that os_version is a number rather than a string. This would be okay if not for the fact that in-development versions of operating systems are usually assigned a codename rather than a version number (Debian sid, Fedora Rawhide, FreeBSD -CURRENT) and so we will always need to convert the version to string before comparison to account for that. Quote all details about the OS to make sure they're stored as strings to begin with. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml | 6 +++--- guests/host_vars/libvirt-debian-8/main.yml | 6 +++--- guests/host_vars/libvirt-debian-9/main.yml | 6 +++--- guests/host_vars/libvirt-debian-sid/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-28/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-29/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-rawhide/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-11/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-12/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-current/main.yml | 6 +++--- guests/host_vars/libvirt-ubuntu-16/main.yml | 6 +++--- guests/host_vars/libvirt-ubuntu-18/main.yml | 6 +++--- 12 files changed, 36 insertions(+), 36 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/= libvirt-centos-7/main.yml index 8be54b6..4e3692f 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -14,6 +14,6 @@ projects: - osinfo-db-tools - virt-viewer =20 -package_format: rpm -os_name: CentOS -os_version: 7 +package_format: 'rpm' +os_name: 'CentOS' +os_version: '7' diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/= libvirt-debian-8/main.yml index fb37205..0ac5130 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -13,6 +13,6 @@ projects: - osinfo-db-tools - virt-viewer =20 -package_format: deb -os_name: Debian -os_version: 8 +package_format: 'deb' +os_name: 'Debian' +os_version: '8' diff --git a/guests/host_vars/libvirt-debian-9/main.yml b/guests/host_vars/= libvirt-debian-9/main.yml index 33476ad..4a1b197 100644 --- a/guests/host_vars/libvirt-debian-9/main.yml +++ b/guests/host_vars/libvirt-debian-9/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: deb -os_name: Debian -os_version: 9 +package_format: 'deb' +os_name: 'Debian' +os_version: '9' diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_var= s/libvirt-debian-sid/main.yml index f2594e7..911b491 100644 --- a/guests/host_vars/libvirt-debian-sid/main.yml +++ b/guests/host_vars/libvirt-debian-sid/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: deb -os_name: Debian -os_version: Sid +package_format: 'deb' +os_name: 'Debian' +os_version: 'Sid' diff --git a/guests/host_vars/libvirt-fedora-28/main.yml b/guests/host_vars= /libvirt-fedora-28/main.yml index 13555af..dc1b3f3 100644 --- a/guests/host_vars/libvirt-fedora-28/main.yml +++ b/guests/host_vars/libvirt-fedora-28/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: rpm -os_name: Fedora -os_version: 28 +package_format: 'rpm' +os_name: 'Fedora' +os_version: '28' diff --git a/guests/host_vars/libvirt-fedora-29/main.yml b/guests/host_vars= /libvirt-fedora-29/main.yml index b6140ed..aba292d 100644 --- a/guests/host_vars/libvirt-fedora-29/main.yml +++ b/guests/host_vars/libvirt-fedora-29/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: rpm -os_name: Fedora -os_version: 29 +package_format: 'rpm' +os_name: 'Fedora' +os_version: '29' diff --git a/guests/host_vars/libvirt-fedora-rawhide/main.yml b/guests/host= _vars/libvirt-fedora-rawhide/main.yml index 604f57f..d8d5dbc 100644 --- a/guests/host_vars/libvirt-fedora-rawhide/main.yml +++ b/guests/host_vars/libvirt-fedora-rawhide/main.yml @@ -27,6 +27,6 @@ projects: - virt-viewer+mingw32 - virt-viewer+mingw64 =20 -package_format: rpm -os_name: Fedora -os_version: Rawhide +package_format: 'rpm' +os_name: 'Fedora' +os_version: 'Rawhide' diff --git a/guests/host_vars/libvirt-freebsd-11/main.yml b/guests/host_var= s/libvirt-freebsd-11/main.yml index 887c9e6..ca32329 100644 --- a/guests/host_vars/libvirt-freebsd-11/main.yml +++ b/guests/host_vars/libvirt-freebsd-11/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: pkg -os_name: FreeBSD -os_version: 11 +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: '11' diff --git a/guests/host_vars/libvirt-freebsd-12/main.yml b/guests/host_var= s/libvirt-freebsd-12/main.yml index ac50271..e8d6a49 100644 --- a/guests/host_vars/libvirt-freebsd-12/main.yml +++ b/guests/host_vars/libvirt-freebsd-12/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: pkg -os_name: FreeBSD -os_version: 12 +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: '12' diff --git a/guests/host_vars/libvirt-freebsd-current/main.yml b/guests/hos= t_vars/libvirt-freebsd-current/main.yml index 1f3e911..3609ddb 100644 --- a/guests/host_vars/libvirt-freebsd-current/main.yml +++ b/guests/host_vars/libvirt-freebsd-current/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: pkg -os_name: FreeBSD -os_version: Current +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: 'Current' diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars= /libvirt-ubuntu-16/main.yml index 6ec1df8..11cd095 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -15,6 +15,6 @@ projects: - osinfo-db-tools - virt-viewer =20 -package_format: deb -os_name: Ubuntu -os_version: 16 +package_format: 'deb' +os_name: 'Ubuntu' +os_version: '16' diff --git a/guests/host_vars/libvirt-ubuntu-18/main.yml b/guests/host_vars= /libvirt-ubuntu-18/main.yml index 61c7384..166d0e3 100644 --- a/guests/host_vars/libvirt-ubuntu-18/main.yml +++ b/guests/host_vars/libvirt-ubuntu-18/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: deb -os_name: Ubuntu -os_version: 18 +package_format: 'deb' +os_name: 'Ubuntu' +os_version: '18' --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list