From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545381400858544.8113099465652; Fri, 21 Dec 2018 00:36:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C0DC420A4; Fri, 21 Dec 2018 08:36:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1275C17249; Fri, 21 Dec 2018 08:36:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1B32C181B9EB; Fri, 21 Dec 2018 08:36:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8aYVf032526 for ; Fri, 21 Dec 2018 03:36:34 -0500 Received: by smtp.corp.redhat.com (Postfix) id E42661823E; Fri, 21 Dec 2018 08:36:34 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8EB6B608E8 for ; Fri, 21 Dec 2018 08:36:33 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:21 +0100 Message-Id: <20181221083627.21819-2-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 1/7] guests: Store OS details as strings X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 21 Dec 2018 08:36:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" When parsing something like os_version: 9 YAML will, somewhat reasonably, decide that os_version is a number rather than a string. This would be okay if not for the fact that in-development versions of operating systems are usually assigned a codename rather than a version number (Debian sid, Fedora Rawhide, FreeBSD -CURRENT) and so we will always need to convert the version to string before comparison to account for that. Quote all details about the OS to make sure they're stored as strings to begin with. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/host_vars/libvirt-centos-7/main.yml | 6 +++--- guests/host_vars/libvirt-debian-8/main.yml | 6 +++--- guests/host_vars/libvirt-debian-9/main.yml | 6 +++--- guests/host_vars/libvirt-debian-sid/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-28/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-29/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-rawhide/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-11/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-12/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-current/main.yml | 6 +++--- guests/host_vars/libvirt-ubuntu-16/main.yml | 6 +++--- guests/host_vars/libvirt-ubuntu-18/main.yml | 6 +++--- 12 files changed, 36 insertions(+), 36 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/= libvirt-centos-7/main.yml index 8be54b6..4e3692f 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -14,6 +14,6 @@ projects: - osinfo-db-tools - virt-viewer =20 -package_format: rpm -os_name: CentOS -os_version: 7 +package_format: 'rpm' +os_name: 'CentOS' +os_version: '7' diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/= libvirt-debian-8/main.yml index fb37205..0ac5130 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -13,6 +13,6 @@ projects: - osinfo-db-tools - virt-viewer =20 -package_format: deb -os_name: Debian -os_version: 8 +package_format: 'deb' +os_name: 'Debian' +os_version: '8' diff --git a/guests/host_vars/libvirt-debian-9/main.yml b/guests/host_vars/= libvirt-debian-9/main.yml index 33476ad..4a1b197 100644 --- a/guests/host_vars/libvirt-debian-9/main.yml +++ b/guests/host_vars/libvirt-debian-9/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: deb -os_name: Debian -os_version: 9 +package_format: 'deb' +os_name: 'Debian' +os_version: '9' diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_var= s/libvirt-debian-sid/main.yml index f2594e7..911b491 100644 --- a/guests/host_vars/libvirt-debian-sid/main.yml +++ b/guests/host_vars/libvirt-debian-sid/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: deb -os_name: Debian -os_version: Sid +package_format: 'deb' +os_name: 'Debian' +os_version: 'Sid' diff --git a/guests/host_vars/libvirt-fedora-28/main.yml b/guests/host_vars= /libvirt-fedora-28/main.yml index 13555af..dc1b3f3 100644 --- a/guests/host_vars/libvirt-fedora-28/main.yml +++ b/guests/host_vars/libvirt-fedora-28/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: rpm -os_name: Fedora -os_version: 28 +package_format: 'rpm' +os_name: 'Fedora' +os_version: '28' diff --git a/guests/host_vars/libvirt-fedora-29/main.yml b/guests/host_vars= /libvirt-fedora-29/main.yml index b6140ed..aba292d 100644 --- a/guests/host_vars/libvirt-fedora-29/main.yml +++ b/guests/host_vars/libvirt-fedora-29/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: rpm -os_name: Fedora -os_version: 29 +package_format: 'rpm' +os_name: 'Fedora' +os_version: '29' diff --git a/guests/host_vars/libvirt-fedora-rawhide/main.yml b/guests/host= _vars/libvirt-fedora-rawhide/main.yml index 604f57f..d8d5dbc 100644 --- a/guests/host_vars/libvirt-fedora-rawhide/main.yml +++ b/guests/host_vars/libvirt-fedora-rawhide/main.yml @@ -27,6 +27,6 @@ projects: - virt-viewer+mingw32 - virt-viewer+mingw64 =20 -package_format: rpm -os_name: Fedora -os_version: Rawhide +package_format: 'rpm' +os_name: 'Fedora' +os_version: 'Rawhide' diff --git a/guests/host_vars/libvirt-freebsd-11/main.yml b/guests/host_var= s/libvirt-freebsd-11/main.yml index 887c9e6..ca32329 100644 --- a/guests/host_vars/libvirt-freebsd-11/main.yml +++ b/guests/host_vars/libvirt-freebsd-11/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: pkg -os_name: FreeBSD -os_version: 11 +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: '11' diff --git a/guests/host_vars/libvirt-freebsd-12/main.yml b/guests/host_var= s/libvirt-freebsd-12/main.yml index ac50271..e8d6a49 100644 --- a/guests/host_vars/libvirt-freebsd-12/main.yml +++ b/guests/host_vars/libvirt-freebsd-12/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: pkg -os_name: FreeBSD -os_version: 12 +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: '12' diff --git a/guests/host_vars/libvirt-freebsd-current/main.yml b/guests/hos= t_vars/libvirt-freebsd-current/main.yml index 1f3e911..3609ddb 100644 --- a/guests/host_vars/libvirt-freebsd-current/main.yml +++ b/guests/host_vars/libvirt-freebsd-current/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: pkg -os_name: FreeBSD -os_version: Current +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: 'Current' diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars= /libvirt-ubuntu-16/main.yml index 6ec1df8..11cd095 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -15,6 +15,6 @@ projects: - osinfo-db-tools - virt-viewer =20 -package_format: deb -os_name: Ubuntu -os_version: 16 +package_format: 'deb' +os_name: 'Ubuntu' +os_version: '16' diff --git a/guests/host_vars/libvirt-ubuntu-18/main.yml b/guests/host_vars= /libvirt-ubuntu-18/main.yml index 61c7384..166d0e3 100644 --- a/guests/host_vars/libvirt-ubuntu-18/main.yml +++ b/guests/host_vars/libvirt-ubuntu-18/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer =20 -package_format: deb -os_name: Ubuntu -os_version: 18 +package_format: 'deb' +os_name: 'Ubuntu' +os_version: '18' --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545381403368411.2431841151399; Fri, 21 Dec 2018 00:36:43 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA167C0221; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83D7E100194B; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 26CC53F7D0; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8aapf032588 for ; Fri, 21 Dec 2018 03:36:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 59AD3608E8; Fri, 21 Dec 2018 08:36:36 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 693B01823E for ; Fri, 21 Dec 2018 08:36:35 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:22 +0100 Message-Id: <20181221083627.21819-3-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 2/7] guests: Remove casts for OS details X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 21 Dec 2018 08:36:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We're always storing os_version as string now, so casting it before use has become unnecessary. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/lcitool | 2 +- guests/playbooks/update/tasks/packages.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index f63122d..759eff6 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -498,7 +498,7 @@ class Application: facts =3D self._inventory.get_facts(host) package_format =3D facts["package_format"] os_name =3D facts["os_name"] - os_version =3D str(facts["os_version"]) + os_version =3D facts["os_version"] os_full =3D os_name + os_version =20 if package_format not in ["deb", "rpm"]: diff --git a/guests/playbooks/update/tasks/packages.yml b/guests/playbooks/= update/tasks/packages.yml index 8cebb5f..7fdfc45 100644 --- a/guests/playbooks/update/tasks/packages.yml +++ b/guests/playbooks/update/tasks/packages.yml @@ -46,11 +46,11 @@ =20 - name: '{{ project }}: Look up mappings (OS version)' set_fact: - temp: '{{ temp|combine({ item: mappings[item][os_name + os_version|str= ing] }) }}' + temp: '{{ temp|combine({ item: mappings[item][os_name + os_version] })= }}' with_items: '{{ packages }}' when: - - mappings[item][os_name + os_version|string] is defined + - mappings[item][os_name + os_version] is defined =20 - set_fact: flattened: [] --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545381408814531.8179621861466; Fri, 21 Dec 2018 00:36:48 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5786112B9F; Fri, 21 Dec 2018 08:36:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 128DD70114; Fri, 21 Dec 2018 08:36:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AA5163F6E4; Fri, 21 Dec 2018 08:36:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8ab4l032655 for ; Fri, 21 Dec 2018 03:36:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id DAEE118250; Fri, 21 Dec 2018 08:36:37 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAC2A608E8 for ; Fri, 21 Dec 2018 08:36:36 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:23 +0100 Message-Id: <20181221083627.21819-4-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 3/7] guests: Install Python 3 during bootstrap X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 21 Dec 2018 08:36:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Almost all our target operating systems have a version of Python 3 which is recent enough (>=3D 3.5) to be used by Ansible available. In fact, almost all of them have it pre-installed, which makes installing Python 2 in addition to it just to use Ansible, when Ansible itself would be absolutely happy running on Python 3, quite silly. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/playbooks/update/tasks/bootstrap.yml | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/guests/playbooks/update/tasks/bootstrap.yml b/guests/playbooks= /update/tasks/bootstrap.yml index d7abb86..f2b40e0 100644 --- a/guests/playbooks/update/tasks/bootstrap.yml +++ b/guests/playbooks/update/tasks/bootstrap.yml @@ -4,17 +4,32 @@ when: - package_format =3D=3D 'pkg' =20 +- set_fact: + python: python3 + +- set_fact: + python: python2 + when: + - os_name =3D=3D 'CentOS' + - os_version =3D=3D '7' + +- set_fact: + python: python + when: + - os_name =3D=3D 'Debian' + - os_version =3D=3D '8' + - name: Bootstrap Ansible - raw: yum install -y python2 + raw: 'yum install -y {{ python }}' when: - package_format =3D=3D 'rpm' =20 - name: Bootstrap Ansible - raw: apt-get install -y python + raw: 'apt-get install -y {{ python }}' when: - package_format =3D=3D 'deb' =20 - name: Bootstrap Ansible - raw: pkg install -y python2 + raw: 'pkg install -y {{ python }}' when: - package_format =3D=3D 'pkg' --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545381413619922.6913958585532; Fri, 21 Dec 2018 00:36:53 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A47EB16974D; Fri, 21 Dec 2018 08:36:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E81A1001F40; Fri, 21 Dec 2018 08:36:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 29000181BA17; Fri, 21 Dec 2018 08:36:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8ado1032723 for ; Fri, 21 Dec 2018 03:36:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6A599608E8; Fri, 21 Dec 2018 08:36:39 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AB1818250 for ; Fri, 21 Dec 2018 08:36:38 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:24 +0100 Message-Id: <20181221083627.21819-5-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 4/7] guests: Use ansible_python_interpreter everywhere X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 21 Dec 2018 08:36:52 +0000 (UTC) Content-Type: text/plain; charset="utf-8" So far we've only needed to use ansible_python_interpreter for FreeBSD, where Ansible is unable to locate the Python binary itself; nowever, now that we want to use Python 3 instead of the default Python 2 almost everywhere, we need to make sure we always point Ansible to the appropriate Python binary. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/host_vars/libvirt-centos-7/main.yml | 2 ++ guests/host_vars/libvirt-debian-8/main.yml | 2 ++ guests/host_vars/libvirt-debian-9/main.yml | 2 ++ guests/host_vars/libvirt-debian-sid/main.yml | 2 ++ guests/host_vars/libvirt-fedora-28/main.yml | 2 ++ guests/host_vars/libvirt-fedora-29/main.yml | 2 ++ guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ guests/host_vars/libvirt-freebsd-11/main.yml | 4 ++-- guests/host_vars/libvirt-freebsd-12/main.yml | 4 ++-- guests/host_vars/libvirt-freebsd-current/main.yml | 4 ++-- guests/host_vars/libvirt-ubuntu-16/main.yml | 2 ++ guests/host_vars/libvirt-ubuntu-18/main.yml | 2 ++ 12 files changed, 24 insertions(+), 6 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/= libvirt-centos-7/main.yml index 4e3692f..da05935 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -17,3 +17,5 @@ projects: package_format: 'rpm' os_name: 'CentOS' os_version: '7' + +ansible_python_interpreter: /usr/bin/python2 diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/= libvirt-debian-8/main.yml index 0ac5130..c5b82b3 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -16,3 +16,5 @@ projects: package_format: 'deb' os_name: 'Debian' os_version: '8' + +ansible_python_interpreter: /usr/bin/python2 diff --git a/guests/host_vars/libvirt-debian-9/main.yml b/guests/host_vars/= libvirt-debian-9/main.yml index 4a1b197..ec7e6b4 100644 --- a/guests/host_vars/libvirt-debian-9/main.yml +++ b/guests/host_vars/libvirt-debian-9/main.yml @@ -19,3 +19,5 @@ projects: package_format: 'deb' os_name: 'Debian' os_version: '9' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_var= s/libvirt-debian-sid/main.yml index 911b491..1c7a29b 100644 --- a/guests/host_vars/libvirt-debian-sid/main.yml +++ b/guests/host_vars/libvirt-debian-sid/main.yml @@ -19,3 +19,5 @@ projects: package_format: 'deb' os_name: 'Debian' os_version: 'Sid' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-fedora-28/main.yml b/guests/host_vars= /libvirt-fedora-28/main.yml index dc1b3f3..b12a670 100644 --- a/guests/host_vars/libvirt-fedora-28/main.yml +++ b/guests/host_vars/libvirt-fedora-28/main.yml @@ -20,3 +20,5 @@ projects: package_format: 'rpm' os_name: 'Fedora' os_version: '28' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-fedora-29/main.yml b/guests/host_vars= /libvirt-fedora-29/main.yml index aba292d..bebf171 100644 --- a/guests/host_vars/libvirt-fedora-29/main.yml +++ b/guests/host_vars/libvirt-fedora-29/main.yml @@ -20,3 +20,5 @@ projects: package_format: 'rpm' os_name: 'Fedora' os_version: '29' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-fedora-rawhide/main.yml b/guests/host= _vars/libvirt-fedora-rawhide/main.yml index d8d5dbc..ed0a3fa 100644 --- a/guests/host_vars/libvirt-fedora-rawhide/main.yml +++ b/guests/host_vars/libvirt-fedora-rawhide/main.yml @@ -30,3 +30,5 @@ projects: package_format: 'rpm' os_name: 'Fedora' os_version: 'Rawhide' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-freebsd-11/main.yml b/guests/host_var= s/libvirt-freebsd-11/main.yml index ca32329..ed805c9 100644 --- a/guests/host_vars/libvirt-freebsd-11/main.yml +++ b/guests/host_vars/libvirt-freebsd-11/main.yml @@ -1,6 +1,4 @@ --- -ansible_python_interpreter: /usr/local/bin/python2 - projects: - libosinfo - libvirt @@ -20,3 +18,5 @@ projects: package_format: 'pkg' os_name: 'FreeBSD' os_version: '11' + +ansible_python_interpreter: /usr/local/bin/python3 diff --git a/guests/host_vars/libvirt-freebsd-12/main.yml b/guests/host_var= s/libvirt-freebsd-12/main.yml index e8d6a49..8bbe158 100644 --- a/guests/host_vars/libvirt-freebsd-12/main.yml +++ b/guests/host_vars/libvirt-freebsd-12/main.yml @@ -1,6 +1,4 @@ --- -ansible_python_interpreter: /usr/local/bin/python2 - projects: - libosinfo - libvirt @@ -20,3 +18,5 @@ projects: package_format: 'pkg' os_name: 'FreeBSD' os_version: '12' + +ansible_python_interpreter: /usr/local/bin/python3 diff --git a/guests/host_vars/libvirt-freebsd-current/main.yml b/guests/hos= t_vars/libvirt-freebsd-current/main.yml index 3609ddb..62498fd 100644 --- a/guests/host_vars/libvirt-freebsd-current/main.yml +++ b/guests/host_vars/libvirt-freebsd-current/main.yml @@ -1,6 +1,4 @@ --- -ansible_python_interpreter: /usr/local/bin/python2 - projects: - libosinfo - libvirt @@ -20,3 +18,5 @@ projects: package_format: 'pkg' os_name: 'FreeBSD' os_version: 'Current' + +ansible_python_interpreter: /usr/local/bin/python3 diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars= /libvirt-ubuntu-16/main.yml index 11cd095..0e38128 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -18,3 +18,5 @@ projects: package_format: 'deb' os_name: 'Ubuntu' os_version: '16' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-ubuntu-18/main.yml b/guests/host_vars= /libvirt-ubuntu-18/main.yml index 166d0e3..bb465e8 100644 --- a/guests/host_vars/libvirt-ubuntu-18/main.yml +++ b/guests/host_vars/libvirt-ubuntu-18/main.yml @@ -19,3 +19,5 @@ projects: package_format: 'deb' os_name: 'Ubuntu' os_version: '18' + +ansible_python_interpreter: /usr/bin/python3 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 154538140825677.33164488142529; Fri, 21 Dec 2018 00:36:48 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 651BD8AE77; Fri, 21 Dec 2018 08:36:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19AF86152F; Fri, 21 Dec 2018 08:36:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B60533F600; Fri, 21 Dec 2018 08:36:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8aesX000319 for ; Fri, 21 Dec 2018 03:36:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id D4ECB1823E; Fri, 21 Dec 2018 08:36:40 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3A10608E8 for ; Fri, 21 Dec 2018 08:36:39 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:25 +0100 Message-Id: <20181221083627.21819-6-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 5/7] guests: Don't dynamically look for Python binary X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 21 Dec 2018 08:36:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Now that we need to point Ansible to the Python binary explicitly and we prefer Python 3 to Python 2 while doing so, we might as well just re-use the path stored in the inventory instead of looking for it dynamically. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/playbooks/update/tasks/paths.yml | 15 --------------- guests/playbooks/update/templates/bashrc.j2 | 2 +- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/guests/playbooks/update/tasks/paths.yml b/guests/playbooks/upd= ate/tasks/paths.yml index 00decc9..08717ba 100644 --- a/guests/playbooks/update/tasks/paths.yml +++ b/guests/playbooks/update/tasks/paths.yml @@ -12,8 +12,6 @@ - gmake - java - make - - python2 - - python3 - su =20 - name: 'Look for files' @@ -54,16 +52,3 @@ make: '{{ commands["make"] }}' when: - make is undefined - -# Prefer python3, fall back to python2 -- name: 'Export paths' - set_fact: - python: '{{ commands["python3"] }}' - when: - - commands["python3"] !=3D '' - -- name: 'Export paths' - set_fact: - python: '{{ commands["python2"] }}' - when: - - python is undefined diff --git a/guests/playbooks/update/templates/bashrc.j2 b/guests/playbooks= /update/templates/bashrc.j2 index f0ab23e..1f39cf2 100644 --- a/guests/playbooks/update/templates/bashrc.j2 +++ b/guests/playbooks/update/templates/bashrc.j2 @@ -1,7 +1,7 @@ export PS1=3D"[\u@\h \w]\$ " =20 export MAKE=3D"{{ make }}" -export PYTHON=3D"{{ python }}" +export PYTHON=3D"{{ ansible_python_interpreter }}" =20 export MAKEFLAGS=3D"-j{{ install_vcpus|int + 1 }}" =20 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 154538141766950.626793112135374; Fri, 21 Dec 2018 00:36:57 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B7CE2AB417; Fri, 21 Dec 2018 08:36:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73E9463B9F; Fri, 21 Dec 2018 08:36:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 201AB18327E8; Fri, 21 Dec 2018 08:36:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8agBa000381 for ; Fri, 21 Dec 2018 03:36:42 -0500 Received: by smtp.corp.redhat.com (Postfix) id 64B021824E; Fri, 21 Dec 2018 08:36:42 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72C571823E for ; Fri, 21 Dec 2018 08:36:41 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:26 +0100 Message-Id: <20181221083627.21819-7-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 6/7] guests: Drop package module bootstrap step X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 21 Dec 2018 08:36:56 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Modern Ansible versions can take care of this step automatically the first time the package module is used, which is nice because it means we don't have to worry about whether we're using Python 3 or Python 2 on the managed host. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/playbooks/update/tasks/base.yml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/upda= te/tasks/base.yml index cc16eb0..2899382 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -1,20 +1,4 @@ --- -- name: Bootstrap the package module - command: apt-get install -y python-apt - args: - creates: /usr/lib/python2*/*-packages/apt - warn: no - when: - - package_format =3D=3D 'deb' - -- name: Bootstrap the package module - command: dnf install -y python2-dnf - args: - creates: /usr/lib*/python2*/*-packages/dnf - warn: no - when: - - os_name =3D=3D 'Fedora' - - name: Permit file editing on SELinux-enabled systems package: name: libselinux-python --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 07:36:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 154538142343970.4179898035162; Fri, 21 Dec 2018 00:37:03 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4099887620; Fri, 21 Dec 2018 08:37:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02428100194B; Fri, 21 Dec 2018 08:37:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ABFA918433AF; Fri, 21 Dec 2018 08:37:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBL8ahSb000447 for ; Fri, 21 Dec 2018 03:36:43 -0500 Received: by smtp.corp.redhat.com (Postfix) id E71D1608E8; Fri, 21 Dec 2018 08:36:43 +0000 (UTC) Received: from kinshicho.redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0024018248 for ; Fri, 21 Dec 2018 08:36:42 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 21 Dec 2018 09:36:27 +0100 Message-Id: <20181221083627.21819-8-abologna@redhat.com> In-Reply-To: <20181221083627.21819-1-abologna@redhat.com> References: <20181221083627.21819-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 7/7] guests: Drop SELinux file editing enablement X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 21 Dec 2018 08:37:02 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Modern Ansible versions do this automatically. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/playbooks/update/tasks/base.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/upda= te/tasks/base.yml index 2899382..5cffbeb 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -1,12 +1,4 @@ --- -- name: Permit file editing on SELinux-enabled systems - package: - name: libselinux-python - state: present - when: - - ( os_name =3D=3D 'CentOS' or - os_name =3D=3D 'Fedora' ) - - name: Enable jessie-backports repository template: src: '{{ playbook_base }}/templates/jessie-backports.sources.j2' --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list