From nobody Thu Apr 25 14:37:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545298021869567.1095565055695; Thu, 20 Dec 2018 01:27:01 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C75FBD3C2B; Thu, 20 Dec 2018 09:26:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BF8468D57; Thu, 20 Dec 2018 09:26:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4669E181B9F6; Thu, 20 Dec 2018 09:26:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBK9O68s001348 for ; Thu, 20 Dec 2018 04:24:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id 692096FEC7; Thu, 20 Dec 2018 09:24:06 +0000 (UTC) Received: from thyrus.usersys.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 795DE6EE3C for ; Thu, 20 Dec 2018 09:24:05 +0000 (UTC) From: Pino Toscano To: libvir-list@redhat.com Date: Thu, 20 Dec 2018 10:23:47 +0100 Message-Id: <20181220092352.1191-2-ptoscano@redhat.com> In-Reply-To: <20181220092352.1191-1-ptoscano@redhat.com> References: <20181220092352.1191-1-ptoscano@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [designer PATCH 1/6] Fix typo in autogen.sh X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 20 Dec 2018 09:27:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Mention the right project name. Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrang=C3=A9 --- autogen.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/autogen.sh b/autogen.sh index 72ce2c0..59fa0c7 100755 --- a/autogen.sh +++ b/autogen.sh @@ -12,7 +12,7 @@ DIE=3D0 =20 (autoconf --version) < /dev/null > /dev/null 2>&1 || { echo - echo "You must have autoconf installed to compile virt-viewer." + echo "You must have autoconf installed to compile libvirt-designer= ." echo "Download the appropriate package for your distribution," echo "or see http://www.gnu.org/software/autoconf" DIE=3D1 @@ -21,7 +21,7 @@ DIE=3D0 (automake --version) < /dev/null > /dev/null 2>&1 || { echo DIE=3D1 - echo "You must have automake installed to compile virt-viewer." + echo "You must have automake installed to compile libvirt-designer= ." echo "Download the appropriate package for your distribution," echo "or see http://www.gnu.org/software/automake" } --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 14:37:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545297851810985.7460339055535; Thu, 20 Dec 2018 01:24:11 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6369C7194; Thu, 20 Dec 2018 09:24:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F21D60BE5; Thu, 20 Dec 2018 09:24:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2764D3F602; Thu, 20 Dec 2018 09:24:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBK9O8o4001358 for ; Thu, 20 Dec 2018 04:24:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 288626EE3C; Thu, 20 Dec 2018 09:24:08 +0000 (UTC) Received: from thyrus.usersys.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 13C966FECC for ; Thu, 20 Dec 2018 09:24:06 +0000 (UTC) From: Pino Toscano To: libvir-list@redhat.com Date: Thu, 20 Dec 2018 10:23:48 +0100 Message-Id: <20181220092352.1191-3-ptoscano@redhat.com> In-Reply-To: <20181220092352.1191-1-ptoscano@redhat.com> References: <20181220092352.1191-1-ptoscano@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [designer PATCH 2/6] Bump libvirt-config & libvirt-gobject requirements to 0.1.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 20 Dec 2018 09:24:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This version bumps the glib version required to >=3D 2.36.0, so using these more recent versions we can assume a more recent glib too. Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrang=C3=A9 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index db99eae..70c7dd4 100644 --- a/configure.ac +++ b/configure.ac @@ -11,8 +11,8 @@ AC_CANONICAL_HOST AM_SILENT_RULES([yes]) =20 LIBOSINFO_REQUIRED=3D0.2.7 -LIBVIRT_GCONFIG_REQUIRED=3D0.1.7 -LIBVIRT_GOBJECT_REQUIRED=3D0.1.3 +LIBVIRT_GCONFIG_REQUIRED=3D0.1.9 +LIBVIRT_GOBJECT_REQUIRED=3D0.1.9 GOBJECT_INTROSPECTION_REQUIRED=3D0.10.8 =20 AC_SUBST(LIBOSINFO_REQUIRED) --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 14:37:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545297982664276.95780757658065; Thu, 20 Dec 2018 01:26:22 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D53909B309; Thu, 20 Dec 2018 09:26:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 818F917AAA; Thu, 20 Dec 2018 09:26:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CEB283F602; Thu, 20 Dec 2018 09:26:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBK9OAj7001376 for ; Thu, 20 Dec 2018 04:24:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 108FD6FEC7; Thu, 20 Dec 2018 09:24:10 +0000 (UTC) Received: from thyrus.usersys.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D18CC6EE3C for ; Thu, 20 Dec 2018 09:24:08 +0000 (UTC) From: Pino Toscano To: libvir-list@redhat.com Date: Thu, 20 Dec 2018 10:23:49 +0100 Message-Id: <20181220092352.1191-4-ptoscano@redhat.com> In-Reply-To: <20181220092352.1191-1-ptoscano@redhat.com> References: <20181220092352.1191-1-ptoscano@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [designer PATCH 3/6] Add missing break in gvir_designer_domain_add_graphics X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 20 Dec 2018 09:26:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" For a GVIR_DESIGNER_DOMAIN_GRAPHICS_DESKTOP graphics type, do not fallback on the code handling GVIR_DESIGNER_DOMAIN_GRAPHICS_RDP. Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt-designer/libvirt-designer-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/= libvirt-designer-domain.c index adca733..cd9349f 100644 --- a/libvirt-designer/libvirt-designer-domain.c +++ b/libvirt-designer/libvirt-designer-domain.c @@ -543,6 +543,8 @@ gvir_designer_domain_add_graphics(GVirDesignerDomain *d= esign, graphics =3D gvir_designer_domain_create_graphics_desktop(design, = error); if (graphics =3D=3D NULL) return NULL; + + break; } =20 case GVIR_DESIGNER_DOMAIN_GRAPHICS_RDP: { --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 14:37:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 154529800674570.1549367647267; Thu, 20 Dec 2018 01:26:46 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D12C5C070E19; Thu, 20 Dec 2018 09:26:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48F66104C529; Thu, 20 Dec 2018 09:26:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E0538181B9E7; Thu, 20 Dec 2018 09:26:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBK9OBxG001388 for ; Thu, 20 Dec 2018 04:24:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id F0BD66EE3C; Thu, 20 Dec 2018 09:24:11 +0000 (UTC) Received: from thyrus.usersys.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD43560BE5 for ; Thu, 20 Dec 2018 09:24:10 +0000 (UTC) From: Pino Toscano To: libvir-list@redhat.com Date: Thu, 20 Dec 2018 10:23:50 +0100 Message-Id: <20181220092352.1191-5-ptoscano@redhat.com> In-Reply-To: <20181220092352.1191-1-ptoscano@redhat.com> References: <20181220092352.1191-1-ptoscano@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [designer PATCH 4/6] Use g_list_free_full X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 20 Dec 2018 09:26:45 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Use g_list_free_full instead of g_list_foreach + g_list_free, so the lists are cleared with a single call. This also avoids cast-function-type warnings because of the different signature of GFunc and g_object_unref. Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt-designer/libvirt-designer-domain.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/= libvirt-designer-domain.c index cd9349f..9ca6832 100644 --- a/libvirt-designer/libvirt-designer-domain.c +++ b/libvirt-designer/libvirt-designer-domain.c @@ -993,8 +993,7 @@ gvir_designer_domain_get_guest(GVirDesignerDomain *desi= gn, tmp =3D tmp->next; } =20 - g_list_foreach(guests, (GFunc)g_object_unref, NULL); - g_list_free(guests); + g_list_free_full(guests, g_object_unref); return ret; } =20 @@ -1031,8 +1030,7 @@ gvir_designer_domain_get_guest_full(GVirDesignerDomai= n *design, } =20 cleanup: - g_list_foreach(guests, (GFunc)g_object_unref, NULL); - g_list_free(guests); + g_list_free_full(guests, g_object_unref); return ret; } =20 @@ -1150,8 +1148,7 @@ gvir_designer_domain_best_guest_domain(GVirConfigCapa= bilitiesGuestArch *arch, gvir_config_capabilities_guest_arch_get_name(arch)); =20 cleanup: - g_list_foreach(domains, (GFunc)g_object_unref, NULL); - g_list_free(domains); + g_list_free_full(domains, g_object_unref); return ret; } =20 --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 14:37:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545298044694590.4189625511473; Thu, 20 Dec 2018 01:27:24 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 941C1C077535; Thu, 20 Dec 2018 09:27:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56B6A4521; Thu, 20 Dec 2018 09:27:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0418E3F603; Thu, 20 Dec 2018 09:27:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBK9ODvI001399 for ; Thu, 20 Dec 2018 04:24:13 -0500 Received: by smtp.corp.redhat.com (Postfix) id A15806FECD; Thu, 20 Dec 2018 09:24:13 +0000 (UTC) Received: from thyrus.usersys.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A79886FECA for ; Thu, 20 Dec 2018 09:24:12 +0000 (UTC) From: Pino Toscano To: libvir-list@redhat.com Date: Thu, 20 Dec 2018 10:23:51 +0100 Message-Id: <20181220092352.1191-6-ptoscano@redhat.com> In-Reply-To: <20181220092352.1191-1-ptoscano@redhat.com> References: <20181220092352.1191-1-ptoscano@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [designer PATCH 5/6] Update .gitignore X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 20 Dec 2018 09:27:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" - move general glob patterns to the top, adding entries for generated files no matter their location - tie path-specific entries with a leading '/' - add mssing entries - sort all the sections Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrang=C3=A9 --- .gitignore | 64 +++++++++++++++++++++++++++++------------------------- 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/.gitignore b/.gitignore index 09e15a5..6187fda 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,22 @@ -/INSTALL +*.gir +*.la +*.lo +*.log +*.o +*.trs +*.typelib +*.vapi +*~ + +.deps/ +.libs/ Makefile Makefile.in + +/AUTHORS +/ChangeLog +/INSTALL +/README /aclocal.m4 /autom4te.cache/ /build-aux/compile @@ -10,48 +26,38 @@ Makefile.in /build-aux/install-sh /build-aux/ltmain.sh /build-aux/missing +/build-aux/test-driver /config.h /config.h.in -/config.log /config.status /configure +/docs/*-decl-list.txt +/docs/*-decl.txt +/docs/*-overrides.txt +/docs/*-sections.txt +/docs/*-undeclared.txt +/docs/*-undocumented.txt +/docs/*-unused.txt +/docs/*.args +/docs/*.hierarchy +/docs/*.interfaces +/docs/*.prerequisites +/docs/*.signals +/docs/*.stamp +/docs/*.types +/docs/html/ +/docs/xml/ +/examples/*.1 /examples/virt-designer /libtool /libvirt-designer-1.0.pc /libvirt-designer.spec -.deps/ -.libs/ -/libvirt-designer/LibvirtDesigner-1.0.gir -/libvirt-designer/LibvirtDesigner-1.0.typelib -/libvirt-designer/libvirt-designer-1.0.la /libvirt-designer/libvirt-designer-enum-types.c /libvirt-designer/libvirt-designer-enum-types.h /libvirt-designer/test-designer-domain -*~ -*.o -*.lo /m4/libtool.m4 /m4/ltoptions.m4 /m4/ltsugar.m4 /m4/ltversion.m4 /m4/lt~obsolete.m4 /stamp-h1 -docs/xml/ -docs/html/ -docs/*.stamp -docs/*-decl-list.txt -docs/*-decl.txt -docs/*-overrides.txt -docs/*-sections.txt -docs/*-undeclared.txt -docs/*-undocumented.txt -docs/*-unused.txt -docs/*.args -docs/*.hierarchy -docs/*.interfaces -docs/*.prerequisites -docs/*.signals -docs/*.types -examples/*.1 -AUTHORS -ChangeLog --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 14:37:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545298067554586.9454841305432; Thu, 20 Dec 2018 01:27:47 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A078389ADD; Thu, 20 Dec 2018 09:27:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71AC9101F94C; Thu, 20 Dec 2018 09:27:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2E9253F605; Thu, 20 Dec 2018 09:27:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBK9OFIt001407 for ; Thu, 20 Dec 2018 04:24:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5CDD66EE3C; Thu, 20 Dec 2018 09:24:15 +0000 (UTC) Received: from thyrus.usersys.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 663A16FECA for ; Thu, 20 Dec 2018 09:24:13 +0000 (UTC) From: Pino Toscano To: libvir-list@redhat.com Date: Thu, 20 Dec 2018 10:23:52 +0100 Message-Id: <20181220092352.1191-7-ptoscano@redhat.com> In-Reply-To: <20181220092352.1191-1-ptoscano@redhat.com> References: <20181220092352.1191-1-ptoscano@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [designer PATCH 6/6] Switch away from osinfo_entity_get_param_value X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 20 Dec 2018 09:27:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" While osinfo_entity_get_param_value is certainly not deprecated, make use of the direct methods to get the needed properties. Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrang=C3=A9 --- examples/virt-designer.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/virt-designer.c b/examples/virt-designer.c index f134b98..eab744e 100644 --- a/examples/virt-designer.c +++ b/examples/virt-designer.c @@ -86,10 +86,8 @@ load_osinfo(void) static gint entity_compare(gconstpointer a, gconstpointer b) { - const gchar *id_a =3D osinfo_entity_get_param_value(OSINFO_ENTITY(a), - OSINFO_ENTITY_PROP_I= D); - const gchar *id_b =3D osinfo_entity_get_param_value(OSINFO_ENTITY(b), - OSINFO_ENTITY_PROP_I= D); + const gchar *id_a =3D osinfo_entity_get_id(OSINFO_ENTITY(a)); + const gchar *id_b =3D osinfo_entity_get_id(OSINFO_ENTITY(b)); return g_strcmp0(id_a, id_b); } =20 @@ -117,8 +115,7 @@ print_oses(const gchar *option_name, oses =3D g_list_sort(oses, entity_compare); for (os_iter =3D oses; os_iter; os_iter =3D os_iter->next) { OsinfoOs *os =3D OSINFO_OS(os_iter->data); - const char *id =3D osinfo_entity_get_param_value(OSINFO_ENTITY(os), - OSINFO_ENTITY_PROP_= ID); + const char *id =3D osinfo_entity_get_id(OSINFO_ENTITY(os)); =20 printf("%s\n", id); } @@ -158,8 +155,7 @@ print_platforms(const gchar *option_name, platforms =3D g_list_sort(platforms, entity_compare); for (platform_iter =3D platforms; platform_iter; platform_iter =3D pla= tform_iter->next) { OsinfoPlatform *platform =3D OSINFO_PLATFORM(platform_iter->data); - const char *id =3D osinfo_entity_get_param_value(OSINFO_ENTITY(pla= tform), - OSINFO_ENTITY_PROP_= ID); + const char *id =3D osinfo_entity_get_id(OSINFO_ENTITY(platform)); =20 printf("%s\n", id); } @@ -372,8 +368,7 @@ find_entity_by_short_id(OsinfoList *ent_list, =20 list =3D osinfo_list_get_elements(ent_list); for (list_iterator =3D list; list_iterator; list_iterator =3D list_ite= rator->next) { - const char *id =3D osinfo_entity_get_param_value(list_iterator->da= ta, - OSINFO_PRODUCT_PROP= _SHORT_ID); + const char *id =3D osinfo_product_get_short_id(OSINFO_PRODUCT(list= _iterator->data)); =20 if (!g_strcmp0(id, short_id)) { ret =3D list_iterator->data; --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list