From nobody Sun Feb 8 22:06:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545054880168439.0034032276686; Mon, 17 Dec 2018 05:54:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06603811DB; Mon, 17 Dec 2018 13:54:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C163E17D69; Mon, 17 Dec 2018 13:54:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6813C3F603; Mon, 17 Dec 2018 13:54:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBHDsa8s030482 for ; Mon, 17 Dec 2018 08:54:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6F436608F3; Mon, 17 Dec 2018 13:54:36 +0000 (UTC) Received: from kinshicho.redhat.com (unknown [10.40.205.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98285608DA for ; Mon, 17 Dec 2018 13:54:35 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 17 Dec 2018 14:54:23 +0100 Message-Id: <20181217135428.18924-2-abologna@redhat.com> In-Reply-To: <20181217135428.18924-1-abologna@redhat.com> References: <20181217135428.18924-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 1/6] guests: Fix FreeBSD symlink kludge X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 17 Dec 2018 13:54:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The version check was not written in a future-proof manner, as all versions of FreeBSD after 10 need the kludge. Signed-off-by: Andrea Bolognani --- guests/playbooks/update/tasks/kludges.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/u= pdate/tasks/kludges.yml index 0ad61a7..f9127ac 100644 --- a/guests/playbooks/update/tasks/kludges.yml +++ b/guests/playbooks/update/tasks/kludges.yml @@ -15,8 +15,8 @@ when: - os_name =3D=3D 'FreeBSD' =20 -# Same as above, except we only need to do it on FreeBSD 11 because -# FreeBSD 10 shipped (an old version of) readline in the base system +# Same as above, except we should skip it on FreeBSD 10 because it +# shipped (an old version of) readline in the base system - name: Create compatibility symlinks file: src: '/usr/local/{{ item }}' @@ -28,7 +28,7 @@ - lib/libreadline.so when: - os_name =3D=3D 'FreeBSD' - - os_version =3D=3D '11' + - os_version !=3D '10' =20 # FreeBSD compiles bash without defining SSH_SOURCE_BASHRC, which means # it won't try to detect when it's spawned by ssh and source ~/.bashrc --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list