From nobody Fri Apr 26 00:22:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1543581862153682.9171314964718; Fri, 30 Nov 2018 04:44:22 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2626D3001955; Fri, 30 Nov 2018 12:44:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDD4760CD1; Fri, 30 Nov 2018 12:44:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2CA6518005B1; Fri, 30 Nov 2018 12:44:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAUChtJa020078 for ; Fri, 30 Nov 2018 07:43:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id 041741F8; Fri, 30 Nov 2018 12:43:55 +0000 (UTC) Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EECF15D9CD for ; Fri, 30 Nov 2018 12:43:52 +0000 (UTC) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BE46C0BF2A5 for ; Fri, 30 Nov 2018 12:43:51 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id y20so5670093qtm.13 for ; Fri, 30 Nov 2018 04:43:51 -0800 (PST) Received: from localhost.localdomain ([2804:431:b704:6c2f:1c94:bb75:e1cf:4f59]) by smtp.gmail.com with ESMTPSA id j95sm2458159qtb.74.2018.11.30.04.43.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 04:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=LgYb+13XLZcKdaBhrzMlq3zsrS/QsZXmYFnJQQ4zGmQ=; b=L9QfB0azZIjKtTjr3Ej8FuFKwwGQ7RvocqaH5GTIgeUDrJyHyfUpdD1aS5NHaRQ+Lg K58+4S+UeVVf+840zUlPRhINbGk5duXFnyDVPEf2rAjovrpnu4bvwCAea6M/1yw4KoTW 4Eb8XPieCIu30aY0p711qOFk3wVOvWnase88Nv3Wh0FkdUTgmInsQ7oCjV+6NXymKP5c EKBq6XY918SCPX4abEgP4Jnt33lyrrBf355lgu9R+/T7OZDTpJiFbHsrpsAt2LEgNhqZ JDJ34PCCgoPB8VziG0v+FgC1tjfMI2oIb90ead0pcAfys0JEPWyhXqq0CLxfesyqNEv6 Hpqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LgYb+13XLZcKdaBhrzMlq3zsrS/QsZXmYFnJQQ4zGmQ=; b=HAMV0Fg8emDBc+u9BsKTj3RTisAj0InrVKUKd8dmJkRzEcmvEAbXOGNHzUOqUo9eXj u1qCy6coFvgFcg0tl2R6f+wiLbK1cWorancJeuxtP02s+tF1qZT5GM6eOSFIeh8UB3qP iYPddnhSB4tOniIMgcfAgMa9KdFsgerrBbQoJfkxnX+xHZMIxmvKK3D+7PADrqqT8Vkz 2I9BUnqCqbsJvhpd4F2wql/KpalpvYDoNKIuuMz9aT8bKTA24WSdbDYqVBURYAace4iI 5/phtWpjH0hmnQ4zVAZmVRYNa420onRzdeAvzExGMb4bLYRDYr49wdTKHRNR26rYN0FF O7lQ== X-Gm-Message-State: AA+aEWbe16aYVSNAlPuUJ3Vgz13yanmBeEals4zGyYlc6RATH+dWz4Tx Wr8oUAsvS499ZwRWqjMpUgKNY+F5nxI= X-Google-Smtp-Source: AFSGD/UtmxuiNALil+0yggtwEsvQOaheKYC58wG38J/20bc4mi/qygMjcywzj/Yugv52BebDOb+8ig== X-Received: by 2002:a0c:8425:: with SMTP id l34mr5407860qva.101.1543581829852; Fri, 30 Nov 2018 04:43:49 -0800 (PST) From: Julio Faracco To: libvir-list@redhat.com Date: Fri, 30 Nov 2018 20:43:36 +0800 Message-Id: <20181130124337.25391-2-jcfaracco@gmail.com> In-Reply-To: <20181130124337.25391-1-jcfaracco@gmail.com> References: <20181130124337.25391-1-jcfaracco@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 30 Nov 2018 12:43:51 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 30 Nov 2018 12:43:51 +0000 (UTC) for IP:'209.85.160.194' DOMAIN:'mail-qt1-f194.google.com' HELO:'mail-qt1-f194.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.108 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.160.194 mail-qt1-f194.google.com 209.85.160.194 mail-qt1-f194.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v3 1/2] lxc: Initializing IPv6 and IPv4 gateway to overwrite old settings. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 30 Nov 2018 12:44:20 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This commit fixes a bug when you have multiple network settings defined. Basically, if you set an IPv6 or IPv4 gateway, it carries on next network settings. It is happening because the data is not being initialized when a new network type is defined. So, the old data still persists into the pointer. Another way to initialized the data was introduced using memset() to avoid missing attributes from the struct. Signed-off-by: Julio Faracco Reviewed-by: John Ferlan --- src/lxc/lxc_native.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 9f6d4b3de8..0d21d9fb2b 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -561,27 +561,26 @@ lxcNetworkWalkCallback(const char *name, virConfValue= Ptr value, void *data) int status; =20 if (STREQ(name, "lxc.network.type")) { + virDomainDefPtr def =3D parseData->def; + size_t networks =3D parseData->networks; + bool privnet =3D parseData->privnet; + /* Store the previous NIC */ status =3D lxcAddNetworkDefinition(parseData); =20 if (status < 0) return -1; else if (status > 0) - parseData->networks++; + networks++; else if (parseData->type !=3D NULL && STREQ(parseData->type, "none= ")) - parseData->privnet =3D false; - - /* Start a new network interface config */ - parseData->type =3D NULL; - parseData->link =3D NULL; - parseData->mac =3D NULL; - parseData->flag =3D NULL; - parseData->macvlanmode =3D NULL; - parseData->vlanid =3D NULL; - parseData->name =3D NULL; - - parseData->ips =3D NULL; - parseData->nips =3D 0; + privnet =3D false; + + /* clean NIC to store a new one */ + memset(parseData, 0, sizeof(*parseData)); + + parseData->def =3D def; + parseData->networks =3D networks; + parseData->privnet =3D privnet; =20 /* Keep the new value */ parseData->type =3D value->str; --=20 2.19.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 26 00:22:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1543581868505801.2813965353146; Fri, 30 Nov 2018 04:44:28 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 482FC811DC; Fri, 30 Nov 2018 12:44:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 13E9E5F724; Fri, 30 Nov 2018 12:44:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C1F523F7CD; Fri, 30 Nov 2018 12:44:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAUChtk8020083 for ; Fri, 30 Nov 2018 07:43:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id B1B6760123; Fri, 30 Nov 2018 12:43:55 +0000 (UTC) Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA868600CC for ; Fri, 30 Nov 2018 12:43:53 +0000 (UTC) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 646FCC049D7C for ; Fri, 30 Nov 2018 12:43:52 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id v11so5720490qtc.2 for ; Fri, 30 Nov 2018 04:43:52 -0800 (PST) Received: from localhost.localdomain ([2804:431:b704:6c2f:1c94:bb75:e1cf:4f59]) by smtp.gmail.com with ESMTPSA id j95sm2458159qtb.74.2018.11.30.04.43.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 04:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=MyN5L70z8qPmOayhNd8iLdamZ+r5+EZjwpk8dZXMWzw=; b=nv4255an9qNDtv5YRX1TwcJyJGCIxveHXTsI8E9GoJ2fwU5D891jD5ZQ/RKs8cmmRV p08DuuM7JH0rUHnk/DdqElaR+LKsV1U97OEes3uQ7NI1on5colF8a2Jiun4Pytp8YuXV E/iI4OfQ1FY3ogj2CL2PtUfnaW3px9FpZTvN0fkbZN8VUVuQj2FHShY4sl1uLWLuYBXr mInm4nEtNSl1Xqf3Gw/wram21Z2RIQf2fEyNl8mGCOt2+tqhWHbV/nGUGy6ZohvXb+qh DJMUUuOpPWp/tABAoRCebbm5UBUcFdQww2RPT7qXlRlv+58gVYqctrwrOD+LV4JP3sOc lIoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MyN5L70z8qPmOayhNd8iLdamZ+r5+EZjwpk8dZXMWzw=; b=I0szN/gDOpHL2WaPZ3a8PJJYUOmbWx80v1l//QJriU7PtC0Lp55hdc2lqNomxYikzt JEmTW025SIWYwr/twtQulMGmEMv8AInRjAMFS78uuK3v54AhJYkK6TTb7s5mgw1wHKqO t9xZfGp1QXIWVL1KAxzPxG7QeWSS+Cn2xG7utfr2xQCRgl1WtgdB/mf1IKZWuNhhkAs8 Y9YCBPR7PeQl8x7N1/b+kL1fGvdvnbcLFzqn50TJ/uP+Fef+fwe9PbDXoycPepLZEkyq IBTCEBy3l8OGs6qomixIbll8GRKvZbaKYIi+rXUtnDG/sqoiqV4rnWEQvh6Rz843zION Fs2A== X-Gm-Message-State: AA+aEWbya7EFAHeV5pDa/UBxTKsVMT2N/Kcy5SIbnwskyfZ+KVrCrIjJ 9xoe4v+VHZ1wS9r93AA67p1h8VYv8tw= X-Google-Smtp-Source: AFSGD/W2P7LkrJnP77jMmBpOu5x0p3bgJZa5jDs2gClQxCPdeRfhho0csL2QJPMf7lKGEvyqGpp6cg== X-Received: by 2002:a0c:e610:: with SMTP id z16mr5402961qvm.81.1543581831327; Fri, 30 Nov 2018 04:43:51 -0800 (PST) From: Julio Faracco To: libvir-list@redhat.com Date: Fri, 30 Nov 2018 20:43:37 +0800 Message-Id: <20181130124337.25391-3-jcfaracco@gmail.com> In-Reply-To: <20181130124337.25391-1-jcfaracco@gmail.com> References: <20181130124337.25391-1-jcfaracco@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 30 Nov 2018 12:43:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 30 Nov 2018 12:43:52 +0000 (UTC) for IP:'209.85.160.178' DOMAIN:'mail-qt1-f178.google.com' HELO:'mail-qt1-f178.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.11 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS) 209.85.160.178 mail-qt1-f178.google.com 209.85.160.178 mail-qt1-f178.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v3 2/2] tests: Adding test case to include multiple network definitions. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 30 Nov 2018 12:44:27 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This commit includes a test case for multiple network definitions. It is useful right now, but it will be more useful when the index used by LXC version 3.X is implemented to support this new settings. The version 3.X is using indexes to specify each network settings. Signed-off-by: Julio Faracco Reviewed-by: John Ferlan --- .../lxcconf2xml-miscnetwork-v3.config | 23 ++++++++++ .../lxcconf2xml-miscnetwork.config | 23 ++++++++++ .../lxcconf2xml-miscnetwork.xml | 45 +++++++++++++++++++ tests/lxcconf2xmltest.c | 2 + 4 files changed, 93 insertions(+) create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-miscnetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.xml diff --git a/tests/lxcconf2xmldata/lxcconf2xml-miscnetwork-v3.config b/test= s/lxcconf2xmldata/lxcconf2xml-miscnetwork-v3.config new file mode 100644 index 0000000000..b46cb3ee7d --- /dev/null +++ b/tests/lxcconf2xmldata/lxcconf2xml-miscnetwork-v3.config @@ -0,0 +1,23 @@ +lxc.network.type =3D phys +lxc.network.link =3D eth0 +lxc.network.name =3D eth1 +lxc.network.ipv4 =3D 192.168.122.2/24 +lxc.network.ipv4.gateway =3D 192.168.122.1 +lxc.network.ipv6 =3D 2003:db8:1:0:214:1234:fe0b:3596/64 +lxc.network.ipv6.gateway =3D 2003:db8:1:0:214:1234:fe0b:3595 + +lxc.network.type =3D vlan +lxc.network.flags =3D up +lxc.network.link =3D eth0 +lxc.network.hwaddr =3D 02:00:15:8f:05:c1 +lxc.network.vlan.id =3D 2 + +lxc.network.type =3D macvlan +lxc.network.flags =3D up +lxc.network.link =3D eth0 +lxc.network.hwaddr =3D 02:00:15:8f:05:c1 +lxc.network.macvlan.mode =3D vepa + +lxc.rootfs =3D /var/lib/lxc/migrate_test/rootfs +lxc.utsname =3D migrate_test +lxc.autodev=3D1 diff --git a/tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.config b/tests/l= xcconf2xmldata/lxcconf2xml-miscnetwork.config new file mode 100644 index 0000000000..b46cb3ee7d --- /dev/null +++ b/tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.config @@ -0,0 +1,23 @@ +lxc.network.type =3D phys +lxc.network.link =3D eth0 +lxc.network.name =3D eth1 +lxc.network.ipv4 =3D 192.168.122.2/24 +lxc.network.ipv4.gateway =3D 192.168.122.1 +lxc.network.ipv6 =3D 2003:db8:1:0:214:1234:fe0b:3596/64 +lxc.network.ipv6.gateway =3D 2003:db8:1:0:214:1234:fe0b:3595 + +lxc.network.type =3D vlan +lxc.network.flags =3D up +lxc.network.link =3D eth0 +lxc.network.hwaddr =3D 02:00:15:8f:05:c1 +lxc.network.vlan.id =3D 2 + +lxc.network.type =3D macvlan +lxc.network.flags =3D up +lxc.network.link =3D eth0 +lxc.network.hwaddr =3D 02:00:15:8f:05:c1 +lxc.network.macvlan.mode =3D vepa + +lxc.rootfs =3D /var/lib/lxc/migrate_test/rootfs +lxc.utsname =3D migrate_test +lxc.autodev=3D1 diff --git a/tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.xml b/tests/lxcc= onf2xmldata/lxcconf2xml-miscnetwork.xml new file mode 100644 index 0000000000..63189cfaec --- /dev/null +++ b/tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.xml @@ -0,0 +1,45 @@ + + migrate_test + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 65536 + 65536 + 1 + + exe + /sbin/init + + + + + + + destroy + restart + destroy + + /usr/libexec/libvirt_lxc + + + + + + + + + + + + eth0 + + + + + + + + + eth0.2 + + + + diff --git a/tests/lxcconf2xmltest.c b/tests/lxcconf2xmltest.c index 0766239ec4..2a277042ce 100644 --- a/tests/lxcconf2xmltest.c +++ b/tests/lxcconf2xmltest.c @@ -137,6 +137,7 @@ mymain(void) DO_TEST("physnetwork", false); DO_TEST("macvlannetwork", false); DO_TEST("vlannetwork", false); + DO_TEST("miscnetwork", false); DO_TEST("idmap", false); DO_TEST("memtune", false); DO_TEST("cputune", false); @@ -161,6 +162,7 @@ mymain(void) DO_TEST3("physnetwork", false); DO_TEST3("macvlannetwork", false); DO_TEST3("vlannetwork", false); + DO_TEST3("miscnetwork", false); DO_TEST3("idmap", false); DO_TEST3("memtune", false); DO_TEST3("cputune", false); --=20 2.19.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list