From nobody Fri Apr 19 00:13:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1543235021121114.28545267295101; Mon, 26 Nov 2018 04:23:41 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D423307D964; Mon, 26 Nov 2018 12:23:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 356201057079; Mon, 26 Nov 2018 12:23:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E1EB33F7CD; Mon, 26 Nov 2018 12:23:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAQCLhJ6011035 for ; Mon, 26 Nov 2018 07:21:43 -0500 Received: by smtp.corp.redhat.com (Postfix) id 09BBE5C229; Mon, 26 Nov 2018 12:21:43 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3375C5C21D; Mon, 26 Nov 2018 12:21:39 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 26 Nov 2018 13:21:32 +0100 Message-Id: <20181126122132.15490-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: Arm architectures don't have a default machine type X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 26 Nov 2018 12:23:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit 26cfb1a3cd39 introduced a list of preferred machine types, which are meant to reflect QEMU's per-architecture historical defaults and shield libvirt users from any changes in that area. Arm architectures, however, never had a default machine type associated with them, so if no machine type is requested by the user we should just go through the usual path of picking the first one reported by the 'query-machines' QMP command instead of using integratorcp straight away. Reported-by: Kashyap Chamarthy Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index fde27010e4..09980467b1 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2200,10 +2200,10 @@ static const char *preferredMachines[] =3D NULL, /* VIR_ARCH_NONE (not a real arch :) */ "clipper", /* VIR_ARCH_ALPHA */ NULL, /* VIR_ARCH_ARMV6L (no QEMU impl) */ - "integratorcp", /* VIR_ARCH_ARMV7L */ - "integratorcp", /* VIR_ARCH_ARMV7B */ + NULL, /* VIR_ARCH_ARMV7L (no default machine type) */ + NULL, /* VIR_ARCH_ARMV7B (no default machine type) */ =20 - "integratorcp", /* VIR_ARCH_AARCH64 */ + NULL, /* VIR_ARCH_AARCH64 (no default machine type) */ "axis-dev88", /* VIR_ARCH_CRIS */ "pc", /* VIR_ARCH_I686 */ NULL, /* VIR_ARCH_ITANIUM (doesn't exist in QEMU any more) */ --=20 2.19.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list