[libvirt] [jenkins-ci PATCH] Revert "Enable {media, tree}uri tests for libosinfo"

Andrea Bolognani posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
guests/playbooks/build/projects/libosinfo.yml | 4 ----
projects/libosinfo.yaml                       | 3 ---
2 files changed, 7 deletions(-)

[libvirt] [jenkins-ci PATCH] Revert "Enable {media, tree}uri tests for libosinfo"

Posted by Andrea Bolognani 2 weeks ago
While a very good idea in theory, it turns out that running
these tests on CI results in a lot of false positives due to
issues on the remote side, which are of course entirely out
of our control.

This reverts commit ad8cdcf7a1e0e293e3cea19f36187b943bb881dd.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/build/projects/libosinfo.yml | 4 ----
 projects/libosinfo.yaml                       | 3 ---
 2 files changed, 7 deletions(-)

diff --git a/guests/playbooks/build/projects/libosinfo.yml b/guests/playbooks/build/projects/libosinfo.yml
index dce1333..311a52b 100644
--- a/guests/playbooks/build/projects/libosinfo.yml
+++ b/guests/playbooks/build/projects/libosinfo.yml
@@ -9,10 +9,6 @@
 - include: '{{ playbook_base }}/jobs/autotools-build-job.yml'
 - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
 - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
-  vars:
-    local_env: |
-      # Run tests that require network connectivity
-      export LIBOSINFO_NETWORK_TESTS=1
 - include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml'
   vars:
     machines: '{{ rpm_machines }}'
diff --git a/projects/libosinfo.yaml b/projects/libosinfo.yaml
index bf9ea6b..0376d0c 100644
--- a/projects/libosinfo.yaml
+++ b/projects/libosinfo.yaml
@@ -12,9 +12,6 @@
           parent_jobs: 'libosinfo-build'
       - autotools-check-job:
           parent_jobs: 'libosinfo-syntax-check'
-          local_env: |
-            # Run tests that require network connectivity
-            export LIBOSINFO_NETWORK_TESTS=1
       - autotools-rpm-job:
           parent_jobs: 'libosinfo-check'
           machines: '{rpm_machines}'
-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] Revert "Enable {media, tree}uri tests for libosinfo"

Posted by Fabiano Fidêncio 2 weeks ago
On Fri, 2018-11-23 at 10:14 +0100, Andrea Bolognani wrote:
> While a very good idea in theory, it turns out that running
> these tests on CI results in a lot of false positives due to
> issues on the remote side, which are of course entirely out
> of our control.
> 
> This reverts commit ad8cdcf7a1e0e293e3cea19f36187b943bb881dd.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list