From nobody Sun May 19 00:42:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1542740367367512.7634647128424; Tue, 20 Nov 2018 10:59:27 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32F3BC053FAA; Tue, 20 Nov 2018 18:59:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DFD316939; Tue, 20 Nov 2018 18:59:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EA9E83F953; Tue, 20 Nov 2018 18:59:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAKIxLg4005203 for ; Tue, 20 Nov 2018 13:59:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7929A57A0; Tue, 20 Nov 2018 18:59:21 +0000 (UTC) Received: from unknown4CEB42C824F4.redhat.com (ovpn-117-6.phx2.redhat.com [10.3.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B5EF5796 for ; Tue, 20 Nov 2018 18:59:17 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 20 Nov 2018 13:59:16 -0500 Message-Id: <20181120185916.30026-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-python PATCH] Fix copy paste error on the version check value X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 20 Nov 2018 18:59:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: John Ferlan --- This one I'll push under the build/test breaker rule... I hadn't "installed" the libvirt library with the API so when "testing" the build I just removed the CHECK_VERSION lines... Of course when looking at the CI results I still saw the fail... So I looked more closely and saw the errors of my ways, ... Before pushing this, I did install the libvirt API/library changes on my host and rebuilt "naturally" and got a pass, so I sincerely hope I got this right for the CI test env.! libvirt-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 349ac63..f7b2f6b 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -1679,7 +1679,7 @@ libvirt_virDomainPinIOThread(PyObject *self ATTRIBUTE= _UNUSED, =20 #endif /* LIBVIR_CHECK_VERSION(1, 2, 14) */ =20 -#if LIBVIR_CHECK_VERSION(4, 10, 4) +#if LIBVIR_CHECK_VERSION(4, 10, 0) =20 static virPyTypedParamsHint virPyDomainSetIOThreadParams[] =3D { { VIR_DOMAIN_IOTHREAD_POLL_MAX_NS, VIR_TYPED_PARAM_ULLONG }, @@ -10039,7 +10039,7 @@ static PyMethodDef libvirtMethods[] =3D { {(char *) "virDomainGetIOThreadInfo", libvirt_virDomainGetIOThreadInfo= , METH_VARARGS, NULL}, {(char *) "virDomainPinIOThread", libvirt_virDomainPinIOThread, METH_V= ARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(1, 2, 14) */ -#if LIBVIR_CHECK_VERSION(4, 10, 4) +#if LIBVIR_CHECK_VERSION(4, 10, 0) {(char *) "virDomainSetIOThreadParams", libvirt_virDomainSetIOThreadPa= rams, METH_VARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(4, 10, 0) */ {(char *) "virConnectListStoragePools", libvirt_virConnectListStorageP= ools, METH_VARARGS, NULL}, --=20 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list