From nobody Sat Feb 7 13:41:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1542226657801644.0288948439527; Wed, 14 Nov 2018 12:17:37 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94EAD307882A; Wed, 14 Nov 2018 20:17:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E18CC5D98E; Wed, 14 Nov 2018 20:17:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C7AB14B1C; Wed, 14 Nov 2018 20:17:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAEJr15J002928 for ; Wed, 14 Nov 2018 14:53:01 -0500 Received: by smtp.corp.redhat.com (Postfix) id C5BF961493; Wed, 14 Nov 2018 19:53:01 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3ACF061480; Wed, 14 Nov 2018 19:52:59 +0000 (UTC) Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D276080F96; Wed, 14 Nov 2018 19:52:57 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id q70so10513655qkh.6; Wed, 14 Nov 2018 11:52:57 -0800 (PST) Received: from localhost.localdomain ([2804:431:f700:6757:dabd:2c88:c24c:80fc]) by smtp.gmail.com with ESMTPSA id n3sm11048027qtc.81.2018.11.14.11.52.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Nov 2018 11:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wMd2p16M6rPGVZuMVbgMUpdMVrQ19aAoj5zY7B6N5y8=; b=kWIt9Uz8TUowAxJ64DAuZR56rO7+oc87rjpxFjpR0/izmQxF6Xzzxydx+vkgUItViM U97FESt8bwiRWs0/tynocgyJF5HZ0NEUtYQWo0MJTvnfujVPO2WZdb7BTSLRP2Tamevc oS6snlBlB1Q+ogHJ4TlfXVKC1AMnuYj/W3cKjUNeC3kDv1qoHeXt8/wX+S1oLIC1vBF9 ygj/dygcfdK+77FbmJyZFukkvizEJCPJvrR8sSRisObAygd5zFyPaaDV5SGYhiawLxh7 lxND3W8EQ1eRummQ0uwr3xuXHUk9JXHTZG+AqEAt8Itx+yMVdrsAfCbZkmA59N+IRmS3 3uSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wMd2p16M6rPGVZuMVbgMUpdMVrQ19aAoj5zY7B6N5y8=; b=nZ5MsRUYdZJY7U0EGnvSv7DgidzUgW5w8X8O6BZavKq/GWdxTQdPQFWUMLTz/Blfdy WlNpMCejg4qoRVz1Y2zKjFWr1mwe9AH7S+EH8I8V8yyHePQ05mg6tc9bwO46ujaXY/4Q IRyilzoyy1SOzMNgBaR9H2ndfNfR6wB0QldoqHBXx9MsEv4n1bIXi96+jcf6UUEmlRet PLjKS0PlR28nGonvqDKD7jlHyOCBbZcjuzRrTut73vbqDbow3G/ee2mZX89nB0vI4+fd 12wiezepmWFwnr0s9X/XlfKSnW/WbeVzpUNnsH8IGok1ZyU8g/IZ61kJimS8Ahi7+m4+ H1Fg== X-Gm-Message-State: AGRZ1gKKcKx8XOQESFWcJr5ScwUDGElWjBg4S71rPjP+2pptWkC5cBj2 TUa2kg40aFrsKIboFaGlI7Gb32E9Dss= X-Google-Smtp-Source: AJdET5eRRLmtGNcJ6khPmdoAdxnckjf3lGkbW/WYOVwjRHAp1pYglYu1r0cuLQb4wrKUm+PDlhDjWw== X-Received: by 2002:ac8:101a:: with SMTP id z26mr3178549qti.184.1542225176972; Wed, 14 Nov 2018 11:52:56 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Date: Wed, 14 Nov 2018 17:52:03 -0200 Message-Id: <20181114195207.26863-2-danielhb413@gmail.com> In-Reply-To: <20181114195207.26863-1-danielhb413@gmail.com> References: <20181114195207.26863-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 14 Nov 2018 19:52:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 14 Nov 2018 19:52:58 +0000 (UTC) for IP:'209.85.222.196' DOMAIN:'mail-qk1-f196.google.com' HELO:'mail-qk1-f196.google.com' FROM:'danielhb413@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.139 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.222.196 mail-qk1-f196.google.com 209.85.222.196 mail-qk1-f196.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza Subject: [libvirt] [PATCH v2 1/5] qemu_process.c: adding maxCpus value to error message X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 14 Nov 2018 20:17:36 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Adding the maxCpus value in the error message of qemuValidateCpuCount allows the user to set an acceptable maxCpus count without knowing QEMU internals. x86 guests, that might have been created prior to the x86 qemuDomainDefValidate maxCpus check code (that validates the maxCpus value in editing time), will also benefit from this change. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_process.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1850923914..84a2163743 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3900,8 +3900,9 @@ qemuValidateCpuCount(virDomainDefPtr def, } =20 if (maxCpus > 0 && virDomainDefGetVcpusMax(def) > maxCpus) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Maximum CPUs greater than specified machine type= limit")); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Maximum CPUs greater than specified machine " + "type limit %u"), maxCpus); return -1; } =20 --=20 2.19.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list