From nobody Sun Apr 28 22:47:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1539162994193598.8463922387784; Wed, 10 Oct 2018 02:16:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60FCD4DD49; Wed, 10 Oct 2018 09:16:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14FE75DEDC; Wed, 10 Oct 2018 09:16:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 96A4E180B5B7; Wed, 10 Oct 2018 09:16:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w9A9Flvc011768 for ; Wed, 10 Oct 2018 05:15:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 001202632A; Wed, 10 Oct 2018 09:15:47 +0000 (UTC) Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB81F26327 for ; Wed, 10 Oct 2018 09:15:44 +0000 (UTC) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A1A5030842D0 for ; Wed, 10 Oct 2018 09:15:41 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 44.2 AUTH) with ESMTPSA id C05026u9A9FdREE (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 10 Oct 2018 11:15:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1539162940; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=N6syC6i6ndALSTsKsAgaa2pd28TXzpJ1ayALkbZ1mMc=; b=lyomtJ0Fohh9VNATR5nGvWMU1uZhNe4j+rGaHBh65d40ONdGsNmnoldAln5LBGR6zr /jgE2Xpb+i5EIoSiW6hidy53/3sBo/mOSqssySgUk71t1NqqePLTsW+1GCTOg9rNx3Dj 97DFu/M2XVKCBLBx7i0J43YpNGo/ybGFZzcBgXnlLJl3l4Y3e01yBY++51dhOvg9ar97 cX/yXO30vacEhOGVhtzb5NndhpjAGhVz9FqOuYUUHuZ8qwyX8ZqvHkNwAZobIIqD0BfL KfDedozld7eWDGyojrup2L9QSpm1XlLXfFfl3oMmAhYWlKFPsW2c6QkxvMUrOU9EtDGU fIvw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAgc0/lb4QMstw0mqi/C51hpW50R4vli8caicjAbM" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: libvir-list@redhat.com Date: Wed, 10 Oct 2018 11:15:37 +0200 Message-Id: <20181010091537.2329-1-olaf@aepfle.de> MIME-Version: 1.0 X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 214 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 10 Oct 2018 09:15:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 10 Oct 2018 09:15:43 +0000 (UTC) for IP:'81.169.146.162' DOMAIN:'mo4-p00-ob.smtp.rzone.de' HELO:'mo4-p00-ob.smtp.rzone.de' FROM:'olaf@aepfle.de' RCPT:'' X-RedHat-Spam-Score: -0.111 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS) 81.169.146.162 mo4-p00-ob.smtp.rzone.de 81.169.146.162 mo4-p00-ob.smtp.rzone.de X-Scanned-By: MIMEDefang 2.84 on 10.5.110.40 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Olaf Hering Subject: [libvirt] [PATCH v1] rpc: reproducible genprotocol output X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 10 Oct 2018 09:16:32 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" If the same source gets built twice ('build same source on different hosts at different times') the resulting files may differ. Fix this by sorting the hash keys before usage. Signed-off-by: Olaf Hering --- src/rpc/genprotocol.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl index 6ce268c024..6baa4f22d5 100755 --- a/src/rpc/genprotocol.pl +++ b/src/rpc/genprotocol.pl @@ -104,7 +104,7 @@ while () { if (keys %uses >=3D 1) { my $i =3D 1; =20 - foreach (keys %uses) { + foreach (sort(keys %uses)) { $i =3D $uses{$_}; unshift @function, (" char **objp_cpp$i =3D (char **) (void *) &$_;\n"= ); -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list