[libvirt] [jenkins-ci PATCH] guests: Allow ssh access as user regardless of flavor

Andrea Bolognani posted 1 patch 5 years, 5 months ago
Failed in applying to current master (apply log)
guests/playbooks/update/tasks/users.yml | 2 --
1 file changed, 2 deletions(-)
[libvirt] [jenkins-ci PATCH] guests: Allow ssh access as user regardless of flavor
Posted by Andrea Bolognani 5 years, 5 months ago
We already allow the host user to ssh into guests as root
using key-based authentication, so it makes no sense to
prevent them to ssh in as the regular user.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/update/tasks/users.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/guests/playbooks/update/tasks/users.yml b/guests/playbooks/update/tasks/users.yml
index abaeaa4..0470686 100644
--- a/guests/playbooks/update/tasks/users.yml
+++ b/guests/playbooks/update/tasks/users.yml
@@ -37,8 +37,6 @@
     user: '{{ flavor }}'
     key: '{{ lookup("file", lookup("env", "HOME") + "/.ssh/id_rsa.pub") }}'
     state: present
-  when:
-    - flavor == 'test'
 
 - name: '{{ flavor }}: Grant passwordless sudo access'
   lineinfile:
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] guests: Allow ssh access as user regardless of flavor
Posted by Daniel P. Berrangé 5 years, 5 months ago
On Fri, Oct 05, 2018 at 04:34:17PM +0200, Andrea Bolognani wrote:
> We already allow the host user to ssh into guests as root
> using key-based authentication, so it makes no sense to
> prevent them to ssh in as the regular user.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/update/tasks/users.yml | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list