From nobody Mon Feb 9 15:50:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1538424470068270.43085493345734; Mon, 1 Oct 2018 13:07:50 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 70EC680465; Mon, 1 Oct 2018 20:07:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B6756CA4D; Mon, 1 Oct 2018 20:07:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D74774BB75; Mon, 1 Oct 2018 20:07:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w91K7eJp023598 for ; Mon, 1 Oct 2018 16:07:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id B72E92010D08; Mon, 1 Oct 2018 20:07:40 +0000 (UTC) Received: from vhost3.laine.org (ovpn-116-73.phx2.redhat.com [10.3.116.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B4332010CBA; Mon, 1 Oct 2018 20:07:38 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Mon, 1 Oct 2018 16:07:34 -0400 Message-Id: <20181001200734.539958-1-laine@laine.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Cc: Yash Mankad Subject: [libvirt] [tck PATCH] Fix runtime "undefined global" error in 100-disk-encryption.t X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 01 Oct 2018 20:07:48 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit 3836a38c added a $secret-undefine call at the end of 100-disk-encryption.t because the presence of the secret was reportedly causing an error when the test was run a 2nd time. Unfortunately the definition of "my $secret" was inside a SKIP: { ... } block, but the $secret->undefine was added just outside that block, so the test failed when it was run. Signed-off-by: Laine Stump Reviewed-by: Yash Mankad --- NB: this test is disabled unconditionally at the start of the SKIP block anyway, so I'm not sure how Jim encountered the error leading to the original patch. scripts/qemu/100-disk-encryption.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-enc= ryption.t index 1a36650..12386ae 100644 --- a/scripts/qemu/100-disk-encryption.t +++ b/scripts/qemu/100-disk-encryption.t @@ -117,6 +117,6 @@ diag "Undefining the inactive domain config"; $dom->undefine; =20 ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised= from missing domain", 42); -} =20 $secret->undefine; +} --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list