[libvirt] [PATCH] libxl: remove configure check for libxl_domain_config_from_json

Jim Fehlig posted 1 patch 5 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180914194248.30282-1-jfehlig@suse.com
Test syntax-check failed
m4/virt-driver-libxl.m4        | 7 -------
tests/libxlxml2domconfigtest.c | 4 ++--
2 files changed, 2 insertions(+), 9 deletions(-)
[libvirt] [PATCH] libxl: remove configure check for libxl_domain_config_from_json
Posted by Jim Fehlig 5 years, 6 months ago
The libxl_domain_config_from_json API appeared in Xen 4.5, hence
there is no need to check for its existence after changing the
minimum supported Xen version to 4.6. Remove the check and its
use in the tests.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 m4/virt-driver-libxl.m4        | 7 -------
 tests/libxlxml2domconfigtest.c | 4 ++--
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4
index 902da11472..70c5c59e6a 100644
--- a/m4/virt-driver-libxl.m4
+++ b/m4/virt-driver-libxl.m4
@@ -56,13 +56,6 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [
     ],[
       LIBXL_LIBS="$LIBXL_LIBS -lxenstore -lxenctrl"
     ])
-
-    dnl Check if libxl_domain_config_from_json is available for domXML to
-    dnl libxl_domain_config tests
-    LIBS="$LIBS -lxenlight -lxenctrl"
-    AC_CHECK_FUNCS([libxl_domain_config_from_json])
-    CFLAGS="$old_CFLAGS"
-    LIBS="$old_LIBS"
   fi
 
   AC_SUBST([LIBXL_CFLAGS])
diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
index b814461acc..eacf8f5615 100644
--- a/tests/libxlxml2domconfigtest.c
+++ b/tests/libxlxml2domconfigtest.c
@@ -33,7 +33,7 @@
 
 #include "testutils.h"
 
-#if defined(WITH_LIBXL) && defined(WITH_YAJL) && defined(HAVE_LIBXL_DOMAIN_CONFIG_FROM_JSON)
+#if defined(WITH_LIBXL) && defined(WITH_YAJL)
 
 # include "internal.h"
 # include "viralloc.h"
@@ -228,4 +228,4 @@ int main(void)
     return EXIT_AM_SKIP;
 }
 
-#endif /* WITH_LIBXL && WITH_YAJL && HAVE_LIBXL_DOMAIN_CONFIG_FROM_JSON */
+#endif /* WITH_LIBXL && WITH_YAJL */
-- 
2.18.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] libxl: remove configure check for libxl_domain_config_from_json
Posted by Ján Tomko 5 years, 6 months ago
On Fri, Sep 14, 2018 at 01:42:48PM -0600, Jim Fehlig wrote:
>The libxl_domain_config_from_json API appeared in Xen 4.5, hence
>there is no need to check for its existence after changing the
>minimum supported Xen version to 4.6. Remove the check and its
>use in the tests.
>
>Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>---
> m4/virt-driver-libxl.m4        | 7 -------
> tests/libxlxml2domconfigtest.c | 4 ++--
> 2 files changed, 2 insertions(+), 9 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list