From nobody Sat Feb 7 09:36:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1536551321892999.476622063667; Sun, 9 Sep 2018 20:48:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 481963001534; Mon, 10 Sep 2018 03:48:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17874D239F; Mon, 10 Sep 2018 03:48:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BEA7F4A463; Mon, 10 Sep 2018 03:48:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w8A3m7kK021338 for ; Sun, 9 Sep 2018 23:48:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6C8EF60BE8; Mon, 10 Sep 2018 03:48:07 +0000 (UTC) Received: from mx1.redhat.com (ext-mx18.extmail.prod.ext.phx2.redhat.com [10.5.110.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64B7A60BE1 for ; Mon, 10 Sep 2018 03:48:07 +0000 (UTC) Received: from m50211.mail.qiye.163.com (m50211.mail.qiye.163.com [123.125.50.211]) by mx1.redhat.com (Postfix) with ESMTP id AA30830820D4 for ; Mon, 10 Sep 2018 03:48:04 +0000 (UTC) Received: from localhost.localdomain (unknown [58.56.27.130]) by smtp3 (Coremail) with SMTP id PdOowEDZhkJu6ZVb8BUdAg--.502S6; Mon, 10 Sep 2018 11:48:00 +0800 (CST) From: Shi Lei To: libvir-list@redhat.com Date: Mon, 10 Sep 2018 11:47:53 +0800 Message-Id: <20180910034755.31246-5-shi_lei@massclouds.com> In-Reply-To: <20180910034755.31246-1-shi_lei@massclouds.com> References: <20180910034755.31246-1-shi_lei@massclouds.com> X-CM-TRANSID: PdOowEDZhkJu6ZVb8BUdAg--.502S6 X-Coremail-Antispam: 1Uf129KBjvAXoW3CFWfKFWxGr4kZw43AF1xAFb_yoW8Gry7Ao WxJr13tFyvgw1xWFWUJFy7trsIga1Yy3y8Z3Z5JFZFyF4rWr95C3yxCanrZa9a9r1UurWD XF1xXa43WFWDArs7n29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73VFW2AGmfu7bjvjm3 AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTRGeHqDUUUU X-Originating-IP: [58.56.27.130] X-CM-SenderInfo: pvklsz1hl6ztxvvfz0xxgvhudrp/1tbigRC9T1sfl4gGEAAAsu X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 212 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 10 Sep 2018 03:48:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 10 Sep 2018 03:48:05 +0000 (UTC) for IP:'123.125.50.211' DOMAIN:'m50211.mail.qiye.163.com' HELO:'m50211.mail.qiye.163.com' FROM:'shi_lei@massclouds.com' RCPT:'' X-RedHat-Spam-Score: -0.01 (RCVD_IN_DNSWL_NONE) 123.125.50.211 m50211.mail.qiye.163.com 123.125.50.211 m50211.mail.qiye.163.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.47 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/6] util: netdev: use VIR_AUTOCLOSE instead of VIR_FORCE_CLOSE X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 10 Sep 2018 03:48:41 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" By making use of GNU C's cleanup attribute handled by the VIR_AUTOCLOSE mac= ro, many of the VIR_FORCE_CLOSE calls can be dropped, which in turn leads to getting rid of many of our cleanup sections. =20 Signed-off-by: Shi Lei --- src/util/virnetdev.c | 253 +++++++++++++++---------------------------- 1 file changed, 87 insertions(+), 166 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 5d4ad24..7f43f15 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -200,27 +200,22 @@ virNetDevSetupControl(const char *ifname ATTRIBUTE_UN= USED, */ int virNetDevExists(const char *ifname) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; =20 if (ioctl(fd, SIOCGIFFLAGS, &ifr)) { if (errno =3D=3D ENODEV || errno =3D=3D ENXIO) - ret =3D 0; - else - virReportSystemError(errno, - _("Unable to check interface flags for %s= "), ifname); - goto cleanup; - } + return 0; =20 - ret =3D 1; + virReportSystemError(errno, _("Unable to check interface flags for= %s"), + ifname); + return -1; + } =20 - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 1; } #else int virNetDevExists(const char *ifname) @@ -251,20 +246,20 @@ virNetDevSetMACInternal(const char *ifname, const virMacAddr *macaddr, bool quiet) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; char macstr[VIR_MAC_STRING_BUFLEN]; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; =20 /* To fill ifr.ifr_hdaddr.sa_family field */ if (ioctl(fd, SIOCGIFHWADDR, &ifr) < 0) { - virReportSystemError(errno, - _("Cannot get interface MAC on '%s'"), + virReportSystemError(errno, _("Cannot get interface MAC on '%s'"), ifname); - goto cleanup; + + VIR_DEBUG("SIOCSIFHWADDR %s get MAC - Fail", ifname); + return -1; } =20 virMacAddrGetRaw(macaddr, (unsigned char *)ifr.ifr_hwaddr.sa_data); @@ -272,24 +267,22 @@ virNetDevSetMACInternal(const char *ifname, if (ioctl(fd, SIOCSIFHWADDR, &ifr) < 0) { =20 if (quiet && - (errno =3D=3D EADDRNOTAVAIL || errno =3D=3D EPERM)) - goto cleanup; + (errno =3D=3D EADDRNOTAVAIL || errno =3D=3D EPERM)) { + VIR_DEBUG("SIOCSIFHWADDR %s MAC=3D%s - Fail", + ifname, virMacAddrFormat(macaddr, macstr)); + return -1; + } =20 virReportSystemError(errno, _("Cannot set interface MAC to %s on '%s'"), virMacAddrFormat(macaddr, macstr), ifname); - goto cleanup; + return -1; } =20 - ret =3D 0; + VIR_DEBUG("SIOCSIFHWADDR %s MAC=3D%s - Success", + ifname, virMacAddrFormat(macaddr, macstr)); =20 - cleanup: - VIR_DEBUG("SIOCSIFHWADDR %s MAC=3D%s - %s", - ifname, virMacAddrFormat(macaddr, macstr), - ret < 0 ? "Fail" : "Success"); - - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } =20 =20 @@ -305,8 +298,7 @@ virNetDevSetMACInternal(const char *ifname, struct ifreq ifr; struct sockaddr_dl sdl; char mac[VIR_MAC_STRING_BUFLEN + 1] =3D ":"; - int s; - int ret =3D -1; + VIR_AUTOCLOSE(s); =20 if ((s =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -320,23 +312,19 @@ virNetDevSetMACInternal(const char *ifname, =20 if (ioctl(s, SIOCSIFLLADDR, &ifr) < 0) { if (quiet && - (errno =3D=3D EADDRNOTAVAIL || errno =3D=3D EPERM)) - goto cleanup; + (errno =3D=3D EADDRNOTAVAIL || errno =3D=3D EPERM)) { + VIR_DEBUG("SIOCSIFLLADDR %s MAC=3D%s - Fail", ifname, mac = + 1); + return -1; + } =20 virReportSystemError(errno, _("Cannot set interface MAC to %s on '%s'= "), mac + 1, ifname); - goto cleanup; + return -1; } =20 - ret =3D 0; - cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=3D%s - %s", ifname, mac + 1, - ret < 0 ? "Fail" : "Success"); - - VIR_FORCE_CLOSE(s); - - return ret; + VIR_DEBUG("SIOCSIFLLADDR %s MAC=3D%s - Success", ifname, mac + 1); + return 0; } =20 =20 @@ -379,9 +367,8 @@ virNetDevSetMAC(const char *ifname, int virNetDevGetMAC(const char *ifname, virMacAddrPtr macaddr) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -390,16 +377,12 @@ int virNetDevGetMAC(const char *ifname, virReportSystemError(errno, _("Cannot get interface MAC on '%s'"), ifname); - goto cleanup; + return -1; } =20 virMacAddrSetRaw(macaddr, (unsigned char *)ifr.ifr_hwaddr.sa_data); =20 - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else int virNetDevGetMAC(const char *ifname, @@ -424,9 +407,8 @@ int virNetDevGetMAC(const char *ifname, */ int virNetDevGetMTU(const char *ifname) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -435,14 +417,10 @@ int virNetDevGetMTU(const char *ifname) virReportSystemError(errno, _("Cannot get interface MTU on '%s'"), ifname); - goto cleanup; + return -1; } =20 - ret =3D ifr.ifr_mtu; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return ifr.ifr_mtu; } #else int virNetDevGetMTU(const char *ifname) @@ -468,9 +446,8 @@ int virNetDevGetMTU(const char *ifname) */ int virNetDevSetMTU(const char *ifname, int mtu) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -481,14 +458,10 @@ int virNetDevSetMTU(const char *ifname, int mtu) virReportSystemError(errno, _("Cannot set interface MTU on '%s'"), ifname); - goto cleanup; + return -1; } =20 - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else int virNetDevSetMTU(const char *ifname, int mtu ATTRIBUTE_UNUSED) @@ -592,9 +565,8 @@ int virNetDevSetNamespace(const char *ifname, pid_t pid= InNs) */ int virNetDevSetName(const char* ifname, const char *newifname) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -604,7 +576,7 @@ int virNetDevSetName(const char* ifname, const char *ne= wifname) virReportSystemError(ERANGE, _("Network interface name '%s' is too long"), newifname); - goto cleanup; + return -1; } # else ifr.ifr_data =3D (caddr_t)newifname; @@ -614,14 +586,10 @@ int virNetDevSetName(const char* ifname, const char *= newifname) virReportSystemError(errno, _("Unable to rename '%s' to '%s'"), ifname, newifname); - goto cleanup; + return -1; } =20 - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else int virNetDevSetName(const char* ifname, const char *newifname) @@ -638,10 +606,9 @@ int virNetDevSetName(const char* ifname, const char *n= ewifname) static int virNetDevSetIFFlag(const char *ifname, int flag, bool val) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; int ifflags; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -650,7 +617,7 @@ virNetDevSetIFFlag(const char *ifname, int flag, bool v= al) virReportSystemError(errno, _("Cannot get interface flags on '%s'"), ifname); - goto cleanup; + return -1; } =20 if (val) @@ -664,15 +631,11 @@ virNetDevSetIFFlag(const char *ifname, int flag, bool= val) virReportSystemError(errno, _("Cannot set interface flags on '%s'"), ifname); - goto cleanup; + return -1; } } =20 - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else static int @@ -765,9 +728,8 @@ virNetDevSetRcvAllMulti(const char *ifname, static int virNetDevGetIFFlag(const char *ifname, int flag, bool *val) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -776,15 +738,11 @@ virNetDevGetIFFlag(const char *ifname, int flag, bool= *val) virReportSystemError(errno, _("Cannot get interface flags on '%s'"), ifname); - goto cleanup; + return -1; } =20 *val =3D (ifr.ifr_flags & flag) ? true : false; - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else static int @@ -909,9 +867,9 @@ char *virNetDevGetName(int ifindex) #if defined(SIOCGIFINDEX) && defined(HAVE_STRUCT_IFREQ) int virNetDevGetIndex(const char *ifname, int *ifindex) { - int ret =3D -1; struct ifreq ifreq; - int fd =3D socket(VIR_NETDEV_FAMILY, SOCK_DGRAM, 0); + VIR_AUTOCLOSE(fd); + socket(VIR_NETDEV_FAMILY, SOCK_DGRAM, 0); =20 if (fd < 0) { virReportSystemError(errno, "%s", @@ -925,13 +883,13 @@ int virNetDevGetIndex(const char *ifname, int *ifinde= x) virReportSystemError(ERANGE, _("invalid interface name %s"), ifname); - goto cleanup; + return -1; } =20 if (ioctl(fd, SIOCGIFINDEX, &ifreq) < 0) { virReportSystemError(errno, _("Unable to get index for interface %s"), if= name); - goto cleanup; + return -1; } =20 # ifdef HAVE_STRUCT_IFREQ_IFR_INDEX @@ -939,11 +897,7 @@ int virNetDevGetIndex(const char *ifname, int *ifindex) # else *ifindex =3D ifreq.ifr_ifindex; # endif - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else /* ! SIOCGIFINDEX */ int virNetDevGetIndex(const char *ifname ATTRIBUTE_UNUSED, @@ -1013,8 +967,8 @@ int virNetDevGetVLanID(const char *ifname, int *vlanid) struct vlan_ioctl_args vlanargs =3D { .cmd =3D GET_VLAN_VID_CMD, }; - int ret =3D -1; - int fd =3D socket(PF_PACKET, SOCK_DGRAM, 0); + VIR_AUTOCLOSE(fd); + socket(PF_PACKET, SOCK_DGRAM, 0); =20 if (fd < 0) { virReportSystemError(errno, "%s", @@ -1026,22 +980,17 @@ int virNetDevGetVLanID(const char *ifname, int *vlan= id) virReportSystemError(ERANGE, _("invalid interface name %s"), ifname); - goto cleanup; + return -1; } =20 if (ioctl(fd, SIOCGIFVLAN, &vlanargs) !=3D 0) { virReportSystemError(errno, _("Unable to get VLAN for interface %s"), ifn= ame); - goto cleanup; + return -1; } =20 *vlanid =3D vlanargs.u.VID; - ret =3D 0; - - cleanup: - VIR_FORCE_CLOSE(fd); - - return ret; + return 0; } #else /* ! SIOCGIFVLAN */ int virNetDevGetVLanID(const char *ifname ATTRIBUTE_UNUSED, @@ -1070,55 +1019,43 @@ int virNetDevGetVLanID(const char *ifname ATTRIBUTE= _UNUSED, int virNetDevValidateConfig(const char *ifname, const virMacAddr *macaddr, int ifindex) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; int idx; int rc; + VIR_AUTOCLOSE(fd); =20 if ((rc =3D virNetDevExists(ifname)) < 0) return -1; - if (rc =3D=3D 0) { - ret =3D 0; - goto cleanup; - } + if (rc =3D=3D 0) + return 0; =20 if (macaddr !=3D NULL) { if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; =20 if (ioctl(fd, SIOCGIFHWADDR, &ifr) < 0) { - if (errno =3D=3D ENODEV) { - ret =3D 0; - goto cleanup; - } + if (errno =3D=3D ENODEV) + return 0; + virReportSystemError(errno, _("could not get MAC address of interface= %s"), ifname); - goto cleanup; + return -1; } =20 if (virMacAddrCmpRaw(macaddr, - (unsigned char *)ifr.ifr_hwaddr.sa_data) !=3D= 0) { - ret =3D 0; - goto cleanup; - } + (unsigned char *)ifr.ifr_hwaddr.sa_data) !=3D= 0) + return 0; } =20 if (ifindex !=3D -1) { if (virNetDevGetIndex(ifname, &idx) < 0) - goto cleanup; - if (idx !=3D ifindex) { - ret =3D 0; - goto cleanup; - } + return -1; + if (idx !=3D ifindex) + return 0; } =20 - ret =3D 1; - - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 1; } #else int virNetDevValidateConfig(const char *ifname ATTRIBUTE_UNUSED, @@ -2649,9 +2586,8 @@ virNetDevGetLinkInfo(const char *ifname, int virNetDevAddMulti(const char *ifname, virMacAddrPtr macaddr) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -2664,13 +2600,10 @@ int virNetDevAddMulti(const char *ifname, virReportSystemError(errno, _("Cannot add multicast MAC %s on '%s' interf= ace"), virMacAddrFormat(macaddr, macstr), ifname); - goto cleanup; + return -1; } =20 - ret =3D 0; - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else int virNetDevAddMulti(const char *ifname ATTRIBUTE_UNUSED, @@ -2698,9 +2631,8 @@ int virNetDevAddMulti(const char *ifname ATTRIBUTE_UN= USED, int virNetDevDelMulti(const char *ifname, virMacAddrPtr macaddr) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; + VIR_AUTOCLOSE(fd); =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) return -1; @@ -2713,13 +2645,10 @@ int virNetDevDelMulti(const char *ifname, virReportSystemError(errno, _("Cannot add multicast MAC %s on '%s' interf= ace"), virMacAddrFormat(macaddr, macstr), ifname); - goto cleanup; + return -1; } =20 - ret =3D 0; - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else int virNetDevDelMulti(const char *ifname ATTRIBUTE_UNUSED, @@ -3388,10 +3317,9 @@ int virNetDevSetCoalesce(const char *ifname, virNetDevCoalescePtr coalesce, bool update) { - int fd =3D -1; - int ret =3D -1; struct ifreq ifr; struct ethtool_coalesce coal =3D {0}; + VIR_AUTOCLOSE(fd); =20 if (!coalesce && !update) return 0; @@ -3433,7 +3361,7 @@ int virNetDevSetCoalesce(const char *ifname, virReportSystemError(errno, _("Cannot set coalesce info on '%s'"), ifname); - goto cleanup; + return -1; } =20 if (coalesce) { @@ -3467,10 +3395,7 @@ int virNetDevSetCoalesce(const char *ifname, } } =20 - ret =3D 0; - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } # else int virNetDevSetCoalesce(const char *ifname, @@ -3503,30 +3428,26 @@ virNetDevGetFeatures(const char *ifname, virBitmapPtr *out) { struct ifreq ifr; - int ret =3D -1; - int fd =3D -1; + VIR_AUTOCLOSE(fd); =20 if (!(*out =3D virBitmapNew(VIR_NET_DEV_FEAT_LAST))) return -1; =20 if ((fd =3D virNetDevSetupControl(ifname, &ifr)) < 0) - goto cleanup; + return -1; =20 virNetDevGetEthtoolFeatures(*out, fd, &ifr); =20 if (virNetDevGetEthtoolGFeatures(*out, fd, &ifr) < 0) - goto cleanup; + return -1; =20 if (virNetDevRDMAFeature(ifname, out) < 0) - goto cleanup; + return -1; =20 if (virNetDevSwitchdevFeature(ifname, out) < 0) - goto cleanup; + return -1; =20 - ret =3D 0; - cleanup: - VIR_FORCE_CLOSE(fd); - return ret; + return 0; } #else int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list