From nobody Sun Feb 8 22:58:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533256125597273.9831160338574; Thu, 2 Aug 2018 17:28:45 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65F663086248; Fri, 3 Aug 2018 00:28:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A05C18513; Fri, 3 Aug 2018 00:28:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7DDA218037ED; Fri, 3 Aug 2018 00:28:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730SeMi008778 for ; Thu, 2 Aug 2018 20:28:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 84C882010CFA; Fri, 3 Aug 2018 00:28:40 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A37E2010CF9 for ; Fri, 3 Aug 2018 00:28:40 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A98A191D19 for ; Fri, 3 Aug 2018 00:28:39 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id n6-v6so4436127qtl.4 for ; Thu, 02 Aug 2018 17:28:39 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NtxKmL9IjOMzQT1Mz4sepMhaH8VYNP3lCDvfRqGFP8Y=; b=sGlfLvf7xvRqplqoH6lK2oyr4QD50UZB5XaPbIy1SNxF/mKbo8BOCXKvgJm7xkjtJD I7QGF2p5BZQqDMPBqUzR2GqkQHBsMnIU1H2JJBfH6qb0kBBC9IQ9gkVg85smQU5X1Dbk R6zcdzny+YTXPiJavT14QWvnwzXYPZ8iGroljy64Ri2MDjXGswvXm2sVodD8jMVgN+MU paIYIXOIVYixMGZM4//5f51oIoC3ksPVZ0SXBa+Ou1XsCGqgY0s712DvlYY411JXrIys Cb8yCwCuLgp285kL+3or4uB+/6t14+GdO/5qnBFe5RBZYbFpfaG7bpKm5hwiW2vW9YYf XENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NtxKmL9IjOMzQT1Mz4sepMhaH8VYNP3lCDvfRqGFP8Y=; b=OABdd20tm2A+cUIizCJTWNJFRmXmcDr5/m2mdyBk1XhX0ow7o6vQI3yQDNbMQuKk7T zxBvBjx26WTywpUMBp5JZE7CQNrisXCH3Is1X8NayRdKNUpU81ItseuUbbeGv57JUK/o F161wOlknqY17M440KZYjckZIrF8yrx+bPlv1y0inLWJQ0xx7cW8lKQKdU/Bqe5xyPUh Hl4N+1250Du5zZXg8wI4dJi1KFPWTT0QVYM93408xnQle4haXq8MgYKs1h0CJMUy/bSp 4QkHHA5qPaBQ2o8XOridpiKhx1jsXoENYYOvh8ofmPT6ihc60bo+oQCGfJ2R3jdu2v44 fw1Q== X-Gm-Message-State: AOUpUlFtm2gMt39Xmkwi4KaLh7JEwVCBz+Fk1CKbxkU+xv2GrJV8VXRr gAAwvArUXSoj8IBEjCw/JGsrQlff X-Google-Smtp-Source: AAOMgpfiTVTTHFhJnB4eNItRe8QwEA7P47DSKWC7Fflz9df6805hdN5GUHXA7uzvHRo1FZbNr/2aGg== X-Received: by 2002:ac8:2ae:: with SMTP id p46-v6mr1695516qtg.306.1533256118513; Thu, 02 Aug 2018 17:28:38 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:55 -0300 Message-Id: <20180803002755.7269-6-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 03 Aug 2018 00:28:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 03 Aug 2018 00:28:39 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 5/5] xenapi: Drop check for auth X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 03 Aug 2018 00:28:44 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since they are done inside virAuthGetPassword and virAuthGetUsername when needed. Also, only auth is checked, but auth->cb, which that could lead to a crash if the callback is NULL. Signed-off-by: Marcos Paulo de Souza --- src/xenapi/xenapi_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 34f9e2c717..3af5eeafcf 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -152,12 +152,6 @@ xenapiConnectOpen(virConnectPtr conn, virConnectAuthPt= r auth, goto error; } =20 - if (auth =3D=3D NULL) { - xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, - _("Authentication Credentials not found"= )); - goto error; - } - if (conn->uri->user !=3D NULL) { if (VIR_STRDUP(username, conn->uri->user) < 0) goto error; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list