From nobody Mon Feb 9 09:10:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533459138880606.7605168324963; Sun, 5 Aug 2018 01:52:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2AA6030E6853; Sun, 5 Aug 2018 08:52:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF6615E7AA; Sun, 5 Aug 2018 08:52:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7E5B91800B6D; Sun, 5 Aug 2018 08:52:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730Sciq008768 for ; Thu, 2 Aug 2018 20:28:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 405B474E92; Fri, 3 Aug 2018 00:28:38 +0000 (UTC) Received: from mx1.redhat.com (ext-mx17.extmail.prod.ext.phx2.redhat.com [10.5.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37A0774EA8 for ; Fri, 3 Aug 2018 00:28:35 +0000 (UTC) Received: from mail-qt0-f178.google.com (mail-qt0-f178.google.com [209.85.216.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E28DB30E6877 for ; Fri, 3 Aug 2018 00:28:34 +0000 (UTC) Received: by mail-qt0-f178.google.com with SMTP id t5-v6so4449178qtn.3 for ; Thu, 02 Aug 2018 17:28:34 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uBiA/G+WZeUpsJvRuB0q3pMMVI9LklIbRaQeibXH32M=; b=Xt1wawDNEZes0GWkD1N115NQ8mqf9seL/Nm7RwpQAkbSSk62jjc6Jbf79lXnsHKV0n zGa24E8ny1kvSF+FkhVAvGQTTB1Fl1xxfftIRE4Mwrxf6Y2xjwxklq/4K5T05QVuclL0 VfSDBafg7Ku+X3KoRmQe7xkJgTo0ug8lAomBVNZMq27oFiKq+RX4KlcTUkipYdYFBi1N H1XBSIEjibhYi2XHCfqH2LZmflxcTwjps3sNb24G7tpve5XFWRrSTA7FFe1BWQKRlti/ HBS0SA8pwNATBFUbRSOpnleo2hqLT2WSGlyBuCSiZH9yjMLE70yXPkmx02k/4w41Jh1G p7Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uBiA/G+WZeUpsJvRuB0q3pMMVI9LklIbRaQeibXH32M=; b=X6rjM5eMNy4rBF8cmXjnAYvb2g7WKeAiUhFm6bKXZqoCojhse9lR/Tp1VsNahfMtMv 2I0KqXfWd8em2CVknLH1THxqrMH4Au3VzhbfIfxz/SqyjoIkNeLwSzs4m+qI0LTbPXFJ SyB4cYzwMxcm6qhShq6AHuc/9mYoLUqDa35dSwp2EmYVB9Ke4iRlLSnpvN2VBV5tZYSg CP8EJkkZOOSL1wsmpPZfb2OPslIBafsS0k3xTKD4KZmaMBGcklf010wbErsmx0uVZ9CJ PVZ7II9hG84ju7QIGp11ytW4/T00/LWizJlil6uyOwUxnBViCGDiEBOZoYhQgx0THdcT I3rQ== X-Gm-Message-State: AOUpUlHg1d6X/JDLXATURt9V+QVz/etwOPAyvi05qYSFsyVyEdUrb/+V xto5WIVV15Bh4ckNE0A0Rgs3X2Io X-Google-Smtp-Source: AAOMgpewDEoSgWAN6Sd4T9mRsvD12PiW+xFqqmvonotiRy1Utuf3hdJZtSvP0FgCtzsyCIUQ+RUPWw== X-Received: by 2002:ac8:2bb3:: with SMTP id m48-v6mr1704713qtm.207.1533256113728; Thu, 02 Aug 2018 17:28:33 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:54 -0300 Message-Id: <20180803002755.7269-5-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 03 Aug 2018 00:28:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 03 Aug 2018 00:28:35 +0000 (UTC) for IP:'209.85.216.178' DOMAIN:'mail-qt0-f178.google.com' HELO:'mail-qt0-f178.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.178 mail-qt0-f178.google.com 209.85.216.178 mail-qt0-f178.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.46 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 4/5] phyp: Drop check for auth and auth->cb X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Sun, 05 Aug 2018 08:52:17 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since they are done inside virAuthGetPassword and virAuthGetUsername when needed. Signed-off-by: Marcos Paulo de Souza --- src/phyp/phyp_driver.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index d78de83231..5b17508dae 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -957,12 +957,6 @@ openSSHSession(virConnectPtr conn, virConnectAuthPtr a= uth, if (VIR_STRDUP(username, conn->uri->user) < 0) goto err; } else { - if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { - virReportError(VIR_ERR_AUTH_FAILED, - "%s", _("No authentication callback provided.")= ); - goto err; - } - username =3D virAuthGetUsername(conn, auth, "ssh", NULL, conn->uri= ->server); =20 if (username =3D=3D NULL) { @@ -1039,11 +1033,6 @@ openSSHSession(virConnectPtr conn, virConnectAuthPtr= auth, if (rc =3D=3D LIBSSH2_ERROR_SOCKET_NONE || rc =3D=3D LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED || rc =3D=3D LIBSSH2_ERROR_PUBLICKEY_UNVERIFIED) { - if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { - virReportError(VIR_ERR_AUTH_FAILED, - "%s", _("No authentication callback provided.")= ); - goto disconnect; - } =20 password =3D virAuthGetPassword(conn, auth, "ssh", username, conn-= >uri->server); =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list