From nobody Mon May 20 23:33:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1532724673738957.1526771642326; Fri, 27 Jul 2018 13:51:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FB3D307D84D; Fri, 27 Jul 2018 20:51:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 777595D6A9; Fri, 27 Jul 2018 20:51:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E18E64A460; Fri, 27 Jul 2018 20:51:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6RKp0cE016558 for ; Fri, 27 Jul 2018 16:51:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id B37332015AC9; Fri, 27 Jul 2018 20:51:00 +0000 (UTC) Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A92672015AC8 for ; Fri, 27 Jul 2018 20:50:58 +0000 (UTC) Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25E157F3F1 for ; Fri, 27 Jul 2018 20:50:57 +0000 (UTC) Received: by mail-qk0-f196.google.com with SMTP id z74-v6so4171096qkb.10 for ; Fri, 27 Jul 2018 13:50:57 -0700 (PDT) Received: from localhost.localdomain ([187.104.182.63]) by smtp.gmail.com with ESMTPSA id y128-v6sm2435621qkc.1.2018.07.27.13.50.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 13:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=stqML+WVKNy7ZRcQxjgJO4kjOytFOvVEMvtm06BrzXI=; b=fzBisPnXPc4aJoUIZJvo48/HTAI+OdLp6Ay1Q6/rukksWR5HSXtz3OGUOxcVyjBHF7 Sr5htepRCdB4U24tWP002Gul+zV7h6uWvk1jvwJBW0zOtT4oL/ArOKfuSJmlJ7HimE2o F8EPw8gCArEQskQg777RlZpKyVBJvj7Xj5jgmy2E5xMDjiHll56Baezv0Qsbj1eANCA8 dHf6o++7Fz4GDEjNAofFryyhEMML+5I68Xj8Axij1fyVESnFbGNotdOD3XlI21U6qsMU Bhijz/Lp3LQI02Nx/mkUKxpYGfOIP98B8nGfyWChasSr8izRQNICY60pqOLDGLoGgZs+ 0SPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=stqML+WVKNy7ZRcQxjgJO4kjOytFOvVEMvtm06BrzXI=; b=YFZarKohs9KsRUpL/lbqUdorxNGT4I55eJnk7N8MGlnvJ30r1ybc3Gv7iL2AnvR6N5 S79zQPvYohjOguhYoYjs5KU7Eh3ont/1SU/3yY6md2ZVuJ5ciGgsciKtbhsFrFxH/rUg e8QIIP55kAxpYKuBPhcbUHUZvcNPAAtukGz4cHTcXcNVxgns9qHzpK2Dsm3HW9aIKAPb Cji8A686GCe2W+aVZ94hFbQsNmtxhuSd7BWzzzF/l81txbdLuDiK2bfAMi7tma9RHOJy MPz3ai4NUcvFfDcHhD4WxTr5gnGX+f/suItU3LivyQLhOXxJRlMgeCYZVfRZ/daKQeaq tTgw== X-Gm-Message-State: AOUpUlGWpF2o9lKcaJqVVepVBeoyAN2frT+Djl2JuK6/QoyDUvJxrSDu xeaEDY5ACOpT/3pv4deTHNbyuxr7 X-Google-Smtp-Source: AAOMgpdBkJcv0sfLec2lexaMt2zWyYto+RdgfSnTXcOG0vgwN/YZD4R2YfcO+PpTEGCxyi7oHFrAIA== X-Received: by 2002:a37:9007:: with SMTP id s7-v6mr7332645qkd.243.1532724656078; Fri, 27 Jul 2018 13:50:56 -0700 (PDT) From: Julio Faracco To: libvir-list@redhat.com Date: Fri, 27 Jul 2018 17:50:42 -0300 Message-Id: <20180727205042.30278-1-jcfaracco@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 27 Jul 2018 20:50:57 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 27 Jul 2018 20:50:57 +0000 (UTC) for IP:'209.85.220.196' DOMAIN:'mail-qk0-f196.google.com' HELO:'mail-qk0-f196.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.220.196 mail-qk0-f196.google.com 209.85.220.196 mail-qk0-f196.google.com X-Scanned-By: MIMEDefang 2.83 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] util: clang is failing due to unused variables. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 27 Jul 2018 20:51:11 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" After some recent patches, clang is throwing some errors related to unused variables. This is not happening when we use GCC with -Werror enabled. Only clang reports this warning. make[3]: Entering directory '/home/julio/Desktop/virt/libvirt/src' CC util/libvirt_util_la-virscsivhost.lo CC util/libvirt_util_la-virusb.lo CC util/libvirt_util_la-virmdev.lo util/virmdev.c:373:36: error: unused variable 'ret' [-Werror,-Wunused-varia= ble] VIR_AUTOPTR(virMediatedDevice) ret =3D virMediatedDeviceListSteal(list,= dev); ^ 1 error generated. Makefile:11579: recipe for target 'util/libvirt_util_la-virmdev.lo' failed make[3]: *** [util/libvirt_util_la-virmdev.lo] Error 1 make[3]: *** Waiting for unfinished jobs.... util/virscsivhost.c:112:37: error: unused variable 'tmp' [-Werror,-Wunused-= variable] VIR_AUTOPTR(virSCSIVHostDevice) tmp =3D virSCSIVHostDeviceListSteal(lis= t, dev); ^ 1 error generated. Makefile:11411: recipe for target 'util/libvirt_util_la-virscsivhost.lo' fa= iled make[3]: *** [util/libvirt_util_la-virscsivhost.lo] Error 1 util/virusb.c:511:31: error: unused variable 'ret' [-Werror,-Wunused-variab= le] VIR_AUTOPTR(virUSBDevice) ret =3D virUSBDeviceListSteal(list, dev); Signed-off-by: Julio Faracco --- src/util/virmdev.c | 3 ++- src/util/virscsivhost.c | 3 ++- src/util/virusb.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index 4050835cc1..63df4e40d8 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -370,7 +370,8 @@ void virMediatedDeviceListDel(virMediatedDeviceListPtr list, virMediatedDevicePtr dev) { - VIR_AUTOPTR(virMediatedDevice) ret =3D virMediatedDeviceListSteal(list= , dev); + VIR_AUTOPTR(virMediatedDevice) ret ATTRIBUTE_UNUSED + =3D virMediatedDeviceListSteal(list, dev); } =20 =20 diff --git a/src/util/virscsivhost.c b/src/util/virscsivhost.c index 280d0dc2fd..e07cd46ba9 100644 --- a/src/util/virscsivhost.c +++ b/src/util/virscsivhost.c @@ -109,7 +109,8 @@ void virSCSIVHostDeviceListDel(virSCSIVHostDeviceListPtr list, virSCSIVHostDevicePtr dev) { - VIR_AUTOPTR(virSCSIVHostDevice) tmp =3D virSCSIVHostDeviceListSteal(li= st, dev); + VIR_AUTOPTR(virSCSIVHostDevice) tmp ATTRIBUTE_UNUSED + =3D virSCSIVHostDeviceListSteal(list, dev); } =20 =20 diff --git a/src/util/virusb.c b/src/util/virusb.c index 609d54836f..73a1041097 100644 --- a/src/util/virusb.c +++ b/src/util/virusb.c @@ -508,7 +508,8 @@ void virUSBDeviceListDel(virUSBDeviceListPtr list, virUSBDevicePtr dev) { - VIR_AUTOPTR(virUSBDevice) ret =3D virUSBDeviceListSteal(list, dev); + VIR_AUTOPTR(virUSBDevice) ret ATTRIBUTE_UNUSED + =3D virUSBDeviceListSteal(list, dev); } =20 virUSBDevicePtr --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list