From nobody Sun Feb 8 05:41:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 153269516417766.99594984371345; Fri, 27 Jul 2018 05:39:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F367930E266E; Fri, 27 Jul 2018 12:37:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8719D62A39; Fri, 27 Jul 2018 12:37:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 350EE3F7D2; Fri, 27 Jul 2018 12:37:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6RCbkV3004266 for ; Fri, 27 Jul 2018 08:37:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 568F42026D74; Fri, 27 Jul 2018 12:37:46 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E99C52026D6B for ; Fri, 27 Jul 2018 12:37:45 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 27 Jul 2018 14:37:39 +0200 Message-Id: <20180727123741.28513-3-abologna@redhat.com> In-Reply-To: <20180727123741.28513-1-abologna@redhat.com> References: <20180727123741.28513-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 2/4] tests: Move some test cases to test_nodedev X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 27 Jul 2018 12:38:17 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" For whatever reason, a few nodedev-related test cases have ended up in test_connect instead of the more appropriate test_nodedev. Move them. Signed-off-by: Andrea Bolognani --- tests/test_connect.py | 27 --------------------------- tests/test_nodedev.py | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 27 deletions(-) diff --git a/tests/test_connect.py b/tests/test_connect.py index f481356..9cc51db 100755 --- a/tests/test_connect.py +++ b/tests/test_connect.py @@ -161,19 +161,6 @@ class TestConnect(libvirttest.BaseTestClass): =20 self.main_loop() =20 - @pytest.mark.usefixtures("node_device_create") - @pytest.mark.parametrize("lookup_method_name,lookup_item", [ - ("NodeDeviceLookupByName", 'Name'), - ]) - def test_connect_node_device_lookup_by_property(self, lookup_method_na= me, lookup_item, node_device_create): - """Parameterized test for all NodeDeviceLookupBy* API calls of Con= nect interface - """ - original_path =3D node_device_create - obj =3D self.bus.get_object('org.libvirt', original_path) - prop =3D obj.Get('org.libvirt.NodeDevice', lookup_item, dbus_inter= face=3Ddbus.PROPERTIES_IFACE) - path =3D getattr(self.connect, lookup_method_name)(prop) - assert original_path =3D=3D path - @pytest.mark.parametrize("lookup_method_name,lookup_item", [ ("NetworkLookupByName", 'Name'), ("NetworkLookupByUUID", 'UUID'), @@ -186,20 +173,6 @@ class TestConnect(libvirttest.BaseTestClass): path =3D getattr(self.connect, lookup_method_name)(prop) assert original_path =3D=3D path =20 - def test_connect_node_device_create_xml(self): - def node_device_created(path, event, _detail): - if event !=3D libvirttest.NodeDeviceEvent.CREATED: - return - assert isinstance(path, dbus.ObjectPath) - self.loop.quit() - - self.connect.connect_to_signal('NodeDeviceEvent', node_device_crea= ted) - - path =3D self.connect.NodeDeviceCreateXML(xmldata.minimal_node_dev= ice_xml, 0) - assert isinstance(path, dbus.ObjectPath) - - self.main_loop() - def test_connect_node_get_cpu_stats(self): stats =3D self.connect.NodeGetCPUStats(0, 0) assert isinstance(stats, dbus.Dictionary) diff --git a/tests/test_nodedev.py b/tests/test_nodedev.py index 082cf0b..c68cb66 100755 --- a/tests/test_nodedev.py +++ b/tests/test_nodedev.py @@ -3,11 +3,37 @@ import dbus import libvirttest import pytest +import xmldata =20 =20 class TestNodeDevice(libvirttest.BaseTestClass): """ Tests for methods and properties of the NodeDevice interface """ + @pytest.mark.parametrize("lookup_method_name,lookup_item", [ + ("NodeDeviceLookupByName", 'Name'), + ]) + def test_connect_node_device_lookup_by_property(self, lookup_method_na= me, lookup_item, node_device_create): + """Parameterized test for all NodeDeviceLookupBy* API calls of Con= nect interface + """ + original_path =3D node_device_create + obj =3D self.bus.get_object('org.libvirt', original_path) + prop =3D obj.Get('org.libvirt.NodeDevice', lookup_item, dbus_inter= face=3Ddbus.PROPERTIES_IFACE) + path =3D getattr(self.connect, lookup_method_name)(prop) + assert original_path =3D=3D path + + def test_connect_node_device_create(self): + def node_device_created(path, event, _detail): + if event !=3D libvirttest.NodeDeviceEvent.CREATED: + return + assert isinstance(path, dbus.ObjectPath) + self.loop.quit() + + self.connect.connect_to_signal('NodeDeviceEvent', node_device_crea= ted) + + path =3D self.connect.NodeDeviceCreateXML(xmldata.minimal_node_dev= ice_xml, 0) + assert isinstance(path, dbus.ObjectPath) + + self.main_loop() =20 def test_node_device_destroy(self, node_device_create): def node_device_deleted(path, event, _detail): --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list