From nobody Tue Feb 10 00:58:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1532611315157283.61177894539026; Thu, 26 Jul 2018 06:21:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE3633082268; Thu, 26 Jul 2018 13:21:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56B8E108421B; Thu, 26 Jul 2018 13:21:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E26FE3FCC2; Thu, 26 Jul 2018 13:21:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6QDKtdI021455 for ; Thu, 26 Jul 2018 09:20:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id B6B971102E26; Thu, 26 Jul 2018 13:20:55 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.40.205.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id 353C81102E1F for ; Thu, 26 Jul 2018 13:20:55 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Thu, 26 Jul 2018 15:20:49 +0200 Message-Id: <20180726132049.4362-3-kkoukiou@redhat.com> In-Reply-To: <20180726132049.4362-1-kkoukiou@redhat.com> References: <20180726132049.4362-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 2/2] Add syntax-check target in Makefile.am X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 26 Jul 2018 13:21:54 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" For now syntax checking is performed only on the python files using flake8. E501: (line too long) warning is ignored. Signed-off-by: Katerina Koukiou Reviewed-by: J=EF=BF=BDn Tomko --- HACKING.md | 9 ++++++++- Makefile.am | 6 ++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/HACKING.md b/HACKING.md index bb22fd6..9327959 100644 --- a/HACKING.md +++ b/HACKING.md @@ -29,7 +29,7 @@ Running from git repository ``` =20 =20 - * Before posting a patch, you should run tests: + * Before posting a patch, you should run tests and perform syntax-checki= ng: =20 ``` make check @@ -37,6 +37,13 @@ Running from git repository =20 The test tool requires python3, python3-pytest and python3-dbus. =20 + ``` + make syntax-check + ``` + + Syntax checking currently is applied only on the python code. + To run this flake8 package is required. + =20 * To run libvirt-dbus directly from the build dir without installing it use the run script: diff --git a/Makefile.am b/Makefile.am index 2c9e588..5c95e96 100644 --- a/Makefile.am +++ b/Makefile.am @@ -42,3 +42,9 @@ gen-AUTHORS: mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS && \ rm -f all.list maint.list contrib.list; \ fi + +.PHONY: flake8 +flake8: + flake8 --ignore=3DE501 + +syntax-check: flake8 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list