From nobody Sun Feb 8 05:10:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531747544701671.9530961760989; Mon, 16 Jul 2018 06:25:44 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 652AA317C41F; Mon, 16 Jul 2018 13:25:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F5B15D9C7; Mon, 16 Jul 2018 13:25:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C75651853DA5; Mon, 16 Jul 2018 13:25:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6GDP9dP028402 for ; Mon, 16 Jul 2018 09:25:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 16DBE2027047; Mon, 16 Jul 2018 13:25:09 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E0E42026D65; Mon, 16 Jul 2018 13:25:07 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 16 Jul 2018 14:24:22 +0100 Message-Id: <20180716132423.10354-37-berrange@redhat.com> In-Reply-To: <20180716132423.10354-1-berrange@redhat.com> References: <20180716132423.10354-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [go PATCH 36/37] error: make GetNotImplementedError private X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 16 Jul 2018 13:25:44 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The GetNotImplementedError() method is only for internal use so should not have a public name. Signed-off-by: Daniel P. Berrang=C3=A9 --- connect.go | 24 +++++++++--------- domain.go | 56 +++++++++++++++++++++--------------------- error.go | 2 +- lxc.go | 2 +- network.go | 2 +- network_events.go | 4 +-- node_device_events.go | 4 +-- nwfilter_binding.go | 12 ++++----- qemu.go | 4 +-- secret_events.go | 6 ++--- storage_pool_events.go | 6 ++--- storage_volume.go | 2 +- stream.go | 10 ++++---- 13 files changed, 67 insertions(+), 67 deletions(-) diff --git a/connect.go b/connect.go index 29e4fb0..34a96ed 100644 --- a/connect.go +++ b/connect.go @@ -857,7 +857,7 @@ func (c *Connect) DomainDefineXML(xmlConfig string) (*D= omain, error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= DefineXMLFlags func (c *Connect) DomainDefineXMLFlags(xmlConfig string, flags DomainDefin= eFlags) (*Domain, error) { if C.LIBVIR_VERSION_NUMBER < 1002012 { - return nil, GetNotImplementedError("virDomainDefineXMLFlags") + return nil, makeNotImplementedError("virDomainDefineXMLFlags") } cXml :=3D C.CString(string(xmlConfig)) defer C.free(unsafe.Pointer(cXml)) @@ -1266,7 +1266,7 @@ func (c *Connect) LookupStoragePoolByUUID(uuid []byte= ) (*StoragePool, error) { // See also https://libvirt.org/html/libvirt-libvirt-storage.html#virStora= gePoolLookupByTargetPath func (c *Connect) LookupStoragePoolByTargetPath(path string) (*StoragePool= , error) { if C.LIBVIR_VERSION_NUMBER < 4001000 { - return nil, GetNotImplementedError("virStoragePoolLookupByTargetPath") + return nil, makeNotImplementedError("virStoragePoolLookupByTargetPath") } cPath :=3D C.CString(path) defer C.free(unsafe.Pointer(cPath)) @@ -1335,7 +1335,7 @@ func (c *Connect) LookupNWFilterByUUID(uuid []byte) (= *NWFilter, error) { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingLookupByPortDev func (c *Connect) LookupNWFilterBindingByPortDev(name string) (*NWFilterBi= nding, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return nil, GetNotImplementedError("virNWFilterBindingLookupByPortDev") + return nil, makeNotImplementedError("virNWFilterBindingLookupByPortDev") } cName :=3D C.CString(name) defer C.free(unsafe.Pointer(cName)) @@ -1555,7 +1555,7 @@ func (c *Connect) ListAllNWFilters(flags uint32) ([]N= WFilter, error) { func (c *Connect) ListAllNWFilterBindings(flags uint32) ([]NWFilterBinding= , error) { var cList *C.virNWFilterBindingPtr if C.LIBVIR_VERSION_NUMBER < 4005000 { - return []NWFilterBinding{}, GetNotImplementedError("virConnectListAllNWF= ilterBindings") + return []NWFilterBinding{}, makeNotImplementedError("virConnectListAllNW= FilterBindings") } var err C.virError numNWFilters :=3D C.virConnectListAllNWFilterBindingsWrapper(c.ptr, (**C.= virNWFilterBindingPtr)(&cList), C.uint(flags), &err) @@ -1675,7 +1675,7 @@ func (c *Connect) InterfaceChangeRollback(flags uint3= 2) error { // See also https://libvirt.org/html/libvirt-libvirt-host.html#virNodeAllo= cPages func (c *Connect) AllocPages(pageSizes map[int]int64, startCell int, cellC= ount uint, flags NodeAllocPagesFlags) (int, error) { if C.LIBVIR_VERSION_NUMBER < 1002009 { - return 0, GetNotImplementedError("virNodeAllocPages") + return 0, makeNotImplementedError("virNodeAllocPages") } cpages :=3D make([]C.uint, len(pageSizes)) ccounts :=3D make([]C.ulonglong, len(pageSizes)) @@ -1812,7 +1812,7 @@ func (c *Connect) GetFreeMemory() (uint64, error) { // See also https://libvirt.org/html/libvirt-libvirt-host.html#virNodeGetF= reePages func (c *Connect) GetFreePages(pageSizes []uint64, startCell int, maxCells= uint, flags uint32) ([]uint64, error) { if C.LIBVIR_VERSION_NUMBER < 1002006 { - return []uint64{}, GetNotImplementedError("virNodeGetFreePages") + return []uint64{}, makeNotImplementedError("virNodeGetFreePages") } cpageSizes :=3D make([]C.uint, len(pageSizes)) ccounts :=3D make([]C.ulonglong, len(pageSizes)*int(maxCells)) @@ -2087,7 +2087,7 @@ func (c *Connect) BaselineCPU(xmlCPUs []string, flags= ConnectBaselineCPUFlags) ( // See also https://libvirt.org/html/libvirt-libvirt-host.html#virConnectB= aselineHypervisorCPU func (c *Connect) BaselineHypervisorCPU(emulator string, arch string, mach= ine string, virttype string, xmlCPUs []string, flags ConnectBaselineCPUFlag= s) (string, error) { if C.LIBVIR_VERSION_NUMBER < 4004000 { - return "", GetNotImplementedError("virConnectBaselineHypervisorCPU") + return "", makeNotImplementedError("virConnectBaselineHypervisorCPU") } =20 var cemulator, carch, cmachine, cvirttype *C.char @@ -2142,7 +2142,7 @@ func (c *Connect) CompareCPU(xmlDesc string, flags Co= nnectCompareCPUFlags) (CPUC // See also https://libvirt.org/html/libvirt-libvirt-host.html#virConnectC= ompareHypervisorCPU func (c *Connect) CompareHypervisorCPU(emulator string, arch string, machi= ne string, virttype string, xmlDesc string, flags ConnectCompareCPUFlags) (= CPUCompareResult, error) { if C.LIBVIR_VERSION_NUMBER < 4004000 { - return CPU_COMPARE_ERROR, GetNotImplementedError("virConnectCompareHyper= visorCPU") + return CPU_COMPARE_ERROR, makeNotImplementedError("virConnectCompareHype= rvisorCPU") } =20 var cemulator, carch, cmachine, cvirttype *C.char @@ -2238,7 +2238,7 @@ func (c *Connect) GetCPUModelNames(arch string, flags= uint32) ([]string, error) // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virConnec= tGetDomainCapabilities func (c *Connect) GetDomainCapabilities(emulatorbin string, arch string, m= achine string, virttype string, flags uint32) (string, error) { if C.LIBVIR_VERSION_NUMBER < 1002007 { - return "", GetNotImplementedError("virConnectGetDomainCapabilities") + return "", makeNotImplementedError("virConnectGetDomainCapabilities") } var cemulatorbin *C.char if emulatorbin !=3D "" { @@ -2776,7 +2776,7 @@ func getDomainStatsLengthsFieldInfo(params *domainSta= tsLengths) map[string]typed // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virConnec= tGetAllDomainStats func (c *Connect) GetAllDomainStats(doms []*Domain, statsTypes DomainStats= Types, flags ConnectGetAllDomainStatsFlags) ([]DomainStats, error) { if C.LIBVIR_VERSION_NUMBER < 1002008 { - return []DomainStats{}, GetNotImplementedError("virConnectGetAllDomainSt= ats") + return []DomainStats{}, makeNotImplementedError("virConnectGetAllDomainS= tats") } var ret C.int var cstats *C.virDomainStatsRecordPtr @@ -2953,7 +2953,7 @@ func getNodeSEVFieldInfo(params *NodeSEVParameters) m= ap[string]typedParamsFieldI // See also https://libvirt.org/html/libvirt-libvirt-host.html#virNodeGetS= EVInfo func (c *Connect) GetSEVInfo(flags uint32) (*NodeSEVParameters, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return nil, GetNotImplementedError("virNodeGetSEVInfo") + return nil, makeNotImplementedError("virNodeGetSEVInfo") } =20 params :=3D &NodeSEVParameters{} @@ -2981,7 +2981,7 @@ func (c *Connect) GetSEVInfo(flags uint32) (*NodeSEVP= arameters, error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virNWFilt= erBindingCreateXML func (c *Connect) NWFilterBindingCreateXML(xmlConfig string, flags uint32)= (*NWFilterBinding, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return nil, GetNotImplementedError("virNWFilterBindingCreateXML") + return nil, makeNotImplementedError("virNWFilterBindingCreateXML") } cXml :=3D C.CString(string(xmlConfig)) defer C.free(unsafe.Pointer(cXml)) diff --git a/domain.go b/domain.go index 302cdb8..14a6485 100644 --- a/domain.go +++ b/domain.go @@ -1539,7 +1539,7 @@ func (d *Domain) DetachDeviceFlags(xml string, flags = DomainDeviceModifyFlags) er // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= DetachDeviceAlias func (d *Domain) DetachDeviceAlias(alias string, flags DomainDeviceModifyF= lags) error { if C.LIBVIR_VERSION_NUMBER < 4004000 { - return GetNotImplementedError("virDomainDetachDeviceAlias") + return makeNotImplementedError("virDomainDetachDeviceAlias") } =20 cAlias :=3D C.CString(alias) @@ -1924,7 +1924,7 @@ type DomainInterface struct { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= InterfaceAddresses func (d *Domain) ListAllInterfaceAddresses(src DomainInterfaceAddressesSou= rce) ([]DomainInterface, error) { if C.LIBVIR_VERSION_NUMBER < 1002014 { - return []DomainInterface{}, GetNotImplementedError("virDomainInterfaceAd= dresses") + return []DomainInterface{}, makeNotImplementedError("virDomainInterfaceA= ddresses") } =20 var cList *C.virDomainInterfacePtr @@ -2089,7 +2089,7 @@ func getBlockCopyParameterFieldInfo(params *DomainBlo= ckCopyParameters) map[strin // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= BlockCopy func (d *Domain) BlockCopy(disk string, destxml string, params *DomainBloc= kCopyParameters, flags DomainBlockCopyFlags) error { if C.LIBVIR_VERSION_NUMBER < 1002008 { - return GetNotImplementedError("virDomainBlockCopy") + return makeNotImplementedError("virDomainBlockCopy") } cdisk :=3D C.CString(disk) defer C.free(unsafe.Pointer(cdisk)) @@ -2530,7 +2530,7 @@ func (d *Domain) MigrateGetMaxDowntime(flags uint32) = (uint64, error) { var downtimeLen C.ulonglong =20 if C.LIBVIR_VERSION_NUMBER < 3007000 { - return 0, GetNotImplementedError("virDomainMigrateGetMaxDowntime") + return 0, makeNotImplementedError("virDomainMigrateGetMaxDowntime") } =20 var err C.virError @@ -2545,7 +2545,7 @@ func (d *Domain) MigrateGetMaxDowntime(flags uint32) = (uint64, error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= MigrateStartPostCopy func (d *Domain) MigrateStartPostCopy(flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 1003003 { - return GetNotImplementedError("virDomainMigrateStartPostCopy") + return makeNotImplementedError("virDomainMigrateStartPostCopy") } =20 var err C.virError @@ -3548,7 +3548,7 @@ func getDomainPerfEventsFieldInfo(params *DomainPerfE= vents) map[string]typedPara // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= GetPerfEvents func (d *Domain) GetPerfEvents(flags DomainModificationImpact) (*DomainPer= fEvents, error) { if C.LIBVIR_VERSION_NUMBER < 1003003 { - return nil, GetNotImplementedError("virDomainGetPerfEvents") + return nil, makeNotImplementedError("virDomainGetPerfEvents") } =20 params :=3D &DomainPerfEvents{} @@ -3575,7 +3575,7 @@ func (d *Domain) GetPerfEvents(flags DomainModificati= onImpact) (*DomainPerfEvent // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetPerfEvents func (d *Domain) SetPerfEvents(params *DomainPerfEvents, flags DomainModif= icationImpact) error { if C.LIBVIR_VERSION_NUMBER < 1003003 { - return GetNotImplementedError("virDomainSetPerfEvents") + return makeNotImplementedError("virDomainSetPerfEvents") } =20 info :=3D getDomainPerfEventsFieldInfo(params) @@ -3874,7 +3874,7 @@ func (d *Domain) GetSecurityLabelList() ([]SecurityLa= bel, error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= GetTime func (d *Domain) GetTime(flags uint32) (int64, uint, error) { if C.LIBVIR_VERSION_NUMBER < 1002005 { - return 0, 0, GetNotImplementedError("virDomainGetTime") + return 0, 0, makeNotImplementedError("virDomainGetTime") } var secs C.longlong var nsecs C.uint @@ -3890,7 +3890,7 @@ func (d *Domain) GetTime(flags uint32) (int64, uint, = error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetTime func (d *Domain) SetTime(secs int64, nsecs uint, flags DomainSetTimeFlags)= error { if C.LIBVIR_VERSION_NUMBER < 1002005 { - return GetNotImplementedError("virDomainSetTime") + return makeNotImplementedError("virDomainSetTime") } =20 var err C.virError @@ -3905,7 +3905,7 @@ func (d *Domain) SetTime(secs int64, nsecs uint, flag= s DomainSetTimeFlags) error // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetUserPassword func (d *Domain) SetUserPassword(user string, password string, flags Domai= nSetUserPasswordFlags) error { if C.LIBVIR_VERSION_NUMBER < 1002015 { - return GetNotImplementedError("virDomainSetUserPassword") + return makeNotImplementedError("virDomainSetUserPassword") } cuser :=3D C.CString(user) cpassword :=3D C.CString(password) @@ -3960,7 +3960,7 @@ func (d *Domain) ManagedSaveRemove(flags uint32) erro= r { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= Rename func (d *Domain) Rename(name string, flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 1002019 { - return GetNotImplementedError("virDomainRename") + return makeNotImplementedError("virDomainRename") } cname :=3D C.CString(name) defer C.free(unsafe.Pointer(cname)) @@ -4023,7 +4023,7 @@ func (d *Domain) CoreDump(to string, flags DomainCore= DumpFlags) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= CoreDumpWithFormat func (d *Domain) CoreDumpWithFormat(to string, format DomainCoreDumpFormat= , flags DomainCoreDumpFlags) error { if C.LIBVIR_VERSION_NUMBER < 1002003 { - GetNotImplementedError("virDomainCoreDumpWithFormat") + makeNotImplementedError("virDomainCoreDumpWithFormat") } cto :=3D C.CString(to) defer C.free(unsafe.Pointer(cto)) @@ -4053,7 +4053,7 @@ func (d *Domain) HasCurrentSnapshot(flags uint32) (bo= ol, error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= FSFreeze func (d *Domain) FSFreeze(mounts []string, flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 1002005 { - return GetNotImplementedError("virDomainFSFreeze") + return makeNotImplementedError("virDomainFSFreeze") } cmounts :=3D make([](*C.char), len(mounts)) =20 @@ -4075,7 +4075,7 @@ func (d *Domain) FSFreeze(mounts []string, flags uint= 32) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= FSThaw func (d *Domain) FSThaw(mounts []string, flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 1002005 { - return GetNotImplementedError("virDomainFSThaw") + return makeNotImplementedError("virDomainFSThaw") } cmounts :=3D make([](*C.char), len(mounts)) =20 @@ -4121,7 +4121,7 @@ type DomainFSInfo struct { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= GetFSInfo func (d *Domain) GetFSInfo(flags uint32) ([]DomainFSInfo, error) { if C.LIBVIR_VERSION_NUMBER < 1002011 { - return []DomainFSInfo{}, GetNotImplementedError("virDomainGetFSInfo") + return []DomainFSInfo{}, makeNotImplementedError("virDomainGetFSInfo") } var cfsinfolist **C.virDomainFSInfo =20 @@ -4180,7 +4180,7 @@ func (d *Domain) PMWakeup(flags uint32) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= AddIOThread func (d *Domain) AddIOThread(id uint, flags DomainModificationImpact) erro= r { if C.LIBVIR_VERSION_NUMBER < 1002015 { - return GetNotImplementedError("virDomainAddIOThread") + return makeNotImplementedError("virDomainAddIOThread") } var err C.virError ret :=3D C.virDomainAddIOThreadWrapper(d.ptr, C.uint(id), C.uint(flags), = &err) @@ -4194,7 +4194,7 @@ func (d *Domain) AddIOThread(id uint, flags DomainMod= ificationImpact) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= DelIOThread func (d *Domain) DelIOThread(id uint, flags DomainModificationImpact) erro= r { if C.LIBVIR_VERSION_NUMBER < 1002015 { - return GetNotImplementedError("virDomainDelIOThread") + return makeNotImplementedError("virDomainDelIOThread") } var err C.virError ret :=3D C.virDomainDelIOThreadWrapper(d.ptr, C.uint(id), C.uint(flags), = &err) @@ -4240,7 +4240,7 @@ type DomainIOThreadInfo struct { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= GetIOThreadInfo func (d *Domain) GetIOThreadInfo(flags DomainModificationImpact) ([]Domain= IOThreadInfo, error) { if C.LIBVIR_VERSION_NUMBER < 1002014 { - return []DomainIOThreadInfo{}, GetNotImplementedError("virDomaingetIOThr= eadInfo") + return []DomainIOThreadInfo{}, makeNotImplementedError("virDomaingetIOTh= readInfo") } var cinfolist **C.virDomainIOThreadInfo =20 @@ -4344,7 +4344,7 @@ func (d *Domain) PinEmulator(cpumap []bool, flags Dom= ainModificationImpact) erro // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= PinIOThread func (d *Domain) PinIOThread(iothreadid uint, cpumap []bool, flags DomainM= odificationImpact) error { if C.LIBVIR_VERSION_NUMBER < 1002014 { - return GetNotImplementedError("virDomainPinIOThread") + return makeNotImplementedError("virDomainPinIOThread") } =20 maplen :=3D (len(cpumap) + 7) / 8 @@ -4412,7 +4412,7 @@ func (d *Domain) OpenGraphics(idx uint, file os.File,= flags DomainOpenGraphicsFl // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= OpenGraphicsFD func (d *Domain) OpenGraphicsFD(idx uint, flags DomainOpenGraphicsFlags) (= *os.File, error) { if C.LIBVIR_VERSION_NUMBER < 1002008 { - return nil, GetNotImplementedError("virDomainOpenGraphicsFD") + return nil, makeNotImplementedError("virDomainOpenGraphicsFD") } var err C.virError ret :=3D C.virDomainOpenGraphicsFDWrapper(d.ptr, C.uint(idx), C.uint(flag= s), &err) @@ -4544,7 +4544,7 @@ func parseCPUString(cpumapstr string) ([]bool, error)= { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= GetGuestVcpus func (d *Domain) GetGuestVcpus(flags uint32) (*DomainGuestVcpus, error) { if C.LIBVIR_VERSION_NUMBER < 2000000 { - return nil, GetNotImplementedError("virDomainGetGuestVcpus") + return nil, makeNotImplementedError("virDomainGetGuestVcpus") } =20 var VcpusSet, OnlineSet, OfflinableSet bool @@ -4572,7 +4572,7 @@ func (d *Domain) GetGuestVcpus(flags uint32) (*Domain= GuestVcpus, error) { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetGuestVcpus func (d *Domain) SetGuestVcpus(cpus []bool, state bool, flags uint32) erro= r { if C.LIBVIR_VERSION_NUMBER < 2000000 { - return GetNotImplementedError("virDomainSetGuestVcpus") + return makeNotImplementedError("virDomainSetGuestVcpus") } =20 cpumap :=3D "" @@ -4606,7 +4606,7 @@ func (d *Domain) SetGuestVcpus(cpus []bool, state boo= l, flags uint32) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetVcpu func (d *Domain) SetVcpu(cpus []bool, state bool, flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 3001000 { - return GetNotImplementedError("virDomainSetVcpu") + return makeNotImplementedError("virDomainSetVcpu") } =20 cpumap :=3D "" @@ -4640,7 +4640,7 @@ func (d *Domain) SetVcpu(cpus []bool, state bool, fla= gs uint32) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetBlockThreshold func (d *Domain) SetBlockThreshold(dev string, threshold uint64, flags uin= t32) error { if C.LIBVIR_VERSION_NUMBER < 3002000 { - return GetNotImplementedError("virDomainSetBlockThreshold") + return makeNotImplementedError("virDomainSetBlockThreshold") } =20 cdev :=3D C.CString(dev) @@ -4657,7 +4657,7 @@ func (d *Domain) SetBlockThreshold(dev string, thresh= old uint64, flags uint32) e // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= ManagedSaveDefineXML func (d *Domain) ManagedSaveDefineXML(xml string, flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 3007000 { - return GetNotImplementedError("virDomainManagedSaveDefineXML") + return makeNotImplementedError("virDomainManagedSaveDefineXML") } =20 cxml :=3D C.CString(xml) @@ -4674,7 +4674,7 @@ func (d *Domain) ManagedSaveDefineXML(xml string, fla= gs uint32) error { // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= ManagedSaveGetXMLDesc func (d *Domain) ManagedSaveGetXMLDesc(flags uint32) (string, error) { if C.LIBVIR_VERSION_NUMBER < 3007000 { - return "", GetNotImplementedError("virDomainManagedSaveGetXMLDesc") + return "", makeNotImplementedError("virDomainManagedSaveGetXMLDesc") } =20 var err C.virError @@ -4710,7 +4710,7 @@ const ( // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= SetLifecycleAction func (d *Domain) SetLifecycleAction(lifecycleType uint32, action uint32, f= lags uint32) error { if C.LIBVIR_VERSION_NUMBER < 3009000 { - return GetNotImplementedError("virDomainSetLifecycleAction") + return makeNotImplementedError("virDomainSetLifecycleAction") } =20 var err C.virError @@ -4739,7 +4739,7 @@ func getDomainLaunchSecurityFieldInfo(params *DomainL= aunchSecurityParameters) ma // See also https://libvirt.org/html/libvirt-libvirt-domain.html#virDomain= GetLaunchSecurityInfo func (d *Domain) GetLaunchSecurityInfo(flags uint32) (*DomainLaunchSecurit= yParameters, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return nil, GetNotImplementedError("virDomainGetLaunchSecurityInfo") + return nil, makeNotImplementedError("virDomainGetLaunchSecurityInfo") } =20 params :=3D &DomainLaunchSecurityParameters{} diff --git a/error.go b/error.go index 37fefc1..1cfdf92 100644 --- a/error.go +++ b/error.go @@ -594,7 +594,7 @@ func makeError(err *C.virError) Error { return ret } =20 -func GetNotImplementedError(apiname string) Error { +func makeNotImplementedError(apiname string) Error { return Error{ Code: ERR_NO_SUPPORT, Domain: FROM_NONE, diff --git a/lxc.go b/lxc.go index 56ab28a..1578cab 100644 --- a/lxc.go +++ b/lxc.go @@ -141,7 +141,7 @@ func DomainLxcEnterSecurityLabel(model *NodeSecurityMod= el, label *SecurityLabel, =20 func (d *Domain) DomainLxcEnterCGroup(flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 2000000 { - return GetNotImplementedError("virDomainLxcEnterCGroup") + return makeNotImplementedError("virDomainLxcEnterCGroup") } =20 var err C.virError diff --git a/network.go b/network.go index d9ec9bf..99954aa 100644 --- a/network.go +++ b/network.go @@ -301,7 +301,7 @@ func (n *Network) Update(cmd NetworkUpdateCommand, sect= ion NetworkUpdateSection, // See also https://libvirt.org/html/libvirt-libvirt-network.html#virNetwo= rkGetDHCPLeases func (n *Network) GetDHCPLeases() ([]NetworkDHCPLease, error) { if C.LIBVIR_VERSION_NUMBER < 1002006 { - return []NetworkDHCPLease{}, GetNotImplementedError("virNetworkGetDHCPLe= ases") + return []NetworkDHCPLease{}, makeNotImplementedError("virNetworkGetDHCPL= eases") } var cLeases *C.virNetworkDHCPLeasePtr var err C.virError diff --git a/network_events.go b/network_events.go index 8ed16d9..2d9bddc 100644 --- a/network_events.go +++ b/network_events.go @@ -69,7 +69,7 @@ func networkEventLifecycleCallback(c C.virConnectPtr, n C= .virNetworkPtr, func (c *Connect) NetworkEventLifecycleRegister(net *Network, callback Net= workEventLifecycleCallback) (int, error) { goCallBackId :=3D registerCallbackId(callback) if C.LIBVIR_VERSION_NUMBER < 1002001 { - return 0, GetNotImplementedError("virConnectNetworkEventRegisterAny") + return 0, makeNotImplementedError("virConnectNetworkEventRegisterAny") } =20 callbackPtr :=3D unsafe.Pointer(C.networkEventLifecycleCallbackHelper) @@ -91,7 +91,7 @@ func (c *Connect) NetworkEventLifecycleRegister(net *Netw= ork, callback NetworkEv =20 func (c *Connect) NetworkEventDeregister(callbackId int) error { if C.LIBVIR_VERSION_NUMBER < 1002001 { - return GetNotImplementedError("virConnectNetworkEventDeregisterAny") + return makeNotImplementedError("virConnectNetworkEventDeregisterAny") } // Deregister the callback var err C.virError diff --git a/node_device_events.go b/node_device_events.go index 632c94d..7920a42 100644 --- a/node_device_events.go +++ b/node_device_events.go @@ -85,7 +85,7 @@ func nodeDeviceEventGenericCallback(c C.virConnectPtr, d = C.virNodeDevicePtr, =20 func (c *Connect) NodeDeviceEventLifecycleRegister(device *NodeDevice, cal= lback NodeDeviceEventLifecycleCallback) (int, error) { if C.LIBVIR_VERSION_NUMBER < 2002000 { - return 0, GetNotImplementedError("virConnectNodeDeviceEventRegisterAny") + return 0, makeNotImplementedError("virConnectNodeDeviceEventRegisterAny") } goCallBackId :=3D registerCallbackId(callback) =20 @@ -128,7 +128,7 @@ func (c *Connect) NodeDeviceEventUpdateRegister(device = *NodeDevice, callback Nod =20 func (c *Connect) NodeDeviceEventDeregister(callbackId int) error { if C.LIBVIR_VERSION_NUMBER < 2002000 { - return GetNotImplementedError("virConnectNodeDeviceEventDeregisterAny") + return makeNotImplementedError("virConnectNodeDeviceEventDeregisterAny") } // Deregister the callback var err C.virError diff --git a/nwfilter_binding.go b/nwfilter_binding.go index 5999d3e..e36c1de 100644 --- a/nwfilter_binding.go +++ b/nwfilter_binding.go @@ -43,7 +43,7 @@ type NWFilterBinding struct { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingFree func (f *NWFilterBinding) Free() error { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return GetNotImplementedError("virNWFilterBindingFree") + return makeNotImplementedError("virNWFilterBindingFree") } var err C.virError ret :=3D C.virNWFilterBindingFreeWrapper(f.ptr, &err) @@ -56,7 +56,7 @@ func (f *NWFilterBinding) Free() error { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingRef func (c *NWFilterBinding) Ref() error { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return GetNotImplementedError("virNWFilterBindingRef") + return makeNotImplementedError("virNWFilterBindingRef") } var err C.virError ret :=3D C.virNWFilterBindingRefWrapper(c.ptr, &err) @@ -69,7 +69,7 @@ func (c *NWFilterBinding) Ref() error { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingDelete func (f *NWFilterBinding) Delete() error { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return GetNotImplementedError("virNWFilterBindingDelete") + return makeNotImplementedError("virNWFilterBindingDelete") } var err C.virError result :=3D C.virNWFilterBindingDeleteWrapper(f.ptr, &err) @@ -82,7 +82,7 @@ func (f *NWFilterBinding) Delete() error { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingGetPortDev func (f *NWFilterBinding) GetPortDev() (string, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return "", GetNotImplementedError("virNWFilterBindingGetPortDev") + return "", makeNotImplementedError("virNWFilterBindingGetPortDev") } var err C.virError result :=3D C.virNWFilterBindingGetPortDevWrapper(f.ptr, &err) @@ -97,7 +97,7 @@ func (f *NWFilterBinding) GetPortDev() (string, error) { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingGetFilterName func (f *NWFilterBinding) GetFilterName() (string, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return "", GetNotImplementedError("virNWFilterBindingGetFilterName") + return "", makeNotImplementedError("virNWFilterBindingGetFilterName") } var err C.virError result :=3D C.virNWFilterBindingGetFilterNameWrapper(f.ptr, &err) @@ -112,7 +112,7 @@ func (f *NWFilterBinding) GetFilterName() (string, erro= r) { // See also https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFi= lterBindingGetXMLDesc func (f *NWFilterBinding) GetXMLDesc(flags uint32) (string, error) { if C.LIBVIR_VERSION_NUMBER < 4005000 { - return "", GetNotImplementedError("virNWFilterBindingGetXMLDesc") + return "", makeNotImplementedError("virNWFilterBindingGetXMLDesc") } var err C.virError result :=3D C.virNWFilterBindingGetXMLDescWrapper(f.ptr, C.uint(flags), &= err) diff --git a/qemu.go b/qemu.go index dd4f258..a2f8507 100644 --- a/qemu.go +++ b/qemu.go @@ -151,7 +151,7 @@ func domainQemuMonitorEventCallback(c C.virConnectPtr, = d C.virDomainPtr, =20 func (c *Connect) DomainQemuMonitorEventRegister(dom *Domain, event string= , callback DomainQemuMonitorEventCallback, flags DomainQemuMonitorEventFlag= s) (int, error) { if C.LIBVIR_VERSION_NUMBER < 1002003 { - return 0, GetNotImplementedError("virConnectDomainQemuMonitorEventRegist= er") + return 0, makeNotImplementedError("virConnectDomainQemuMonitorEventRegis= ter") } =20 cEvent :=3D C.CString(event) @@ -176,7 +176,7 @@ func (c *Connect) DomainQemuMonitorEventRegister(dom *D= omain, event string, call =20 func (c *Connect) DomainQemuEventDeregister(callbackId int) error { if C.LIBVIR_VERSION_NUMBER < 1002003 { - return GetNotImplementedError("virConnectDomainQemuMonitorEventDeregiste= r") + return makeNotImplementedError("virConnectDomainQemuMonitorEventDeregist= er") } =20 // Deregister the callback diff --git a/secret_events.go b/secret_events.go index 38605ba..d928e98 100644 --- a/secret_events.go +++ b/secret_events.go @@ -86,7 +86,7 @@ func secretEventGenericCallback(c C.virConnectPtr, n C.vi= rSecretPtr, func (c *Connect) SecretEventLifecycleRegister(secret *Secret, callback Se= cretEventLifecycleCallback) (int, error) { goCallBackId :=3D registerCallbackId(callback) if C.LIBVIR_VERSION_NUMBER < 3000000 { - return 0, GetNotImplementedError("virConnectSecretEventRegisterAny") + return 0, makeNotImplementedError("virConnectSecretEventRegisterAny") } =20 callbackPtr :=3D unsafe.Pointer(C.secretEventLifecycleCallbackHelper) @@ -109,7 +109,7 @@ func (c *Connect) SecretEventLifecycleRegister(secret *= Secret, callback SecretEv func (c *Connect) SecretEventValueChangedRegister(secret *Secret, callback= SecretEventGenericCallback) (int, error) { goCallBackId :=3D registerCallbackId(callback) if C.LIBVIR_VERSION_NUMBER < 3000000 { - return 0, GetNotImplementedError("virConnectSecretEventRegisterAny") + return 0, makeNotImplementedError("virConnectSecretEventRegisterAny") } =20 callbackPtr :=3D unsafe.Pointer(C.secretEventGenericCallbackHelper) @@ -131,7 +131,7 @@ func (c *Connect) SecretEventValueChangedRegister(secre= t *Secret, callback Secre =20 func (c *Connect) SecretEventDeregister(callbackId int) error { if C.LIBVIR_VERSION_NUMBER < 3000000 { - return GetNotImplementedError("virConnectSecretEventDeregisterAny") + return makeNotImplementedError("virConnectSecretEventDeregisterAny") } // Deregister the callback var err C.virError diff --git a/storage_pool_events.go b/storage_pool_events.go index 55c9f4e..fd1b997 100644 --- a/storage_pool_events.go +++ b/storage_pool_events.go @@ -85,7 +85,7 @@ func storagePoolEventGenericCallback(c C.virConnectPtr, s= C.virStoragePoolPtr, =20 func (c *Connect) StoragePoolEventLifecycleRegister(pool *StoragePool, cal= lback StoragePoolEventLifecycleCallback) (int, error) { if C.LIBVIR_VERSION_NUMBER < 2000000 { - return 0, GetNotImplementedError("virConnectStoragePoolEventRegisterAny") + return 0, makeNotImplementedError("virConnectStoragePoolEventRegisterAny= ") } =20 goCallBackId :=3D registerCallbackId(callback) @@ -109,7 +109,7 @@ func (c *Connect) StoragePoolEventLifecycleRegister(poo= l *StoragePool, callback =20 func (c *Connect) StoragePoolEventRefreshRegister(pool *StoragePool, callb= ack StoragePoolEventGenericCallback) (int, error) { if C.LIBVIR_VERSION_NUMBER < 2000000 { - return 0, GetNotImplementedError("virConnectStoragePoolEventRegisterAny") + return 0, makeNotImplementedError("virConnectStoragePoolEventRegisterAny= ") } =20 goCallBackId :=3D registerCallbackId(callback) @@ -133,7 +133,7 @@ func (c *Connect) StoragePoolEventRefreshRegister(pool = *StoragePool, callback St =20 func (c *Connect) StoragePoolEventDeregister(callbackId int) error { if C.LIBVIR_VERSION_NUMBER < 2000000 { - return GetNotImplementedError("virConnectStoragePoolEventDeregisterAny") + return makeNotImplementedError("virConnectStoragePoolEventDeregisterAny") } =20 // Deregister the callback diff --git a/storage_volume.go b/storage_volume.go index 711c3c1..bb10813 100644 --- a/storage_volume.go +++ b/storage_volume.go @@ -169,7 +169,7 @@ func (v *StorageVol) GetInfo() (*StorageVolInfo, error)= { // See also https://libvirt.org/html/libvirt-libvirt-storage.html#virStora= geVolGetInfoFlags func (v *StorageVol) GetInfoFlags(flags StorageVolInfoFlags) (*StorageVolI= nfo, error) { if C.LIBVIR_VERSION_NUMBER < 3000000 { - return nil, GetNotImplementedError("virStorageVolGetInfoFlags") + return nil, makeNotImplementedError("virStorageVolGetInfoFlags") } =20 var cinfo C.virStorageVolInfo diff --git a/stream.go b/stream.go index 515ae08..4010b11 100644 --- a/stream.go +++ b/stream.go @@ -121,7 +121,7 @@ func (v *Stream) Recv(p []byte) (int, error) { // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStream= RecvFlags func (v *Stream) RecvFlags(p []byte, flags StreamRecvFlagsValues) (int, er= ror) { if C.LIBVIR_VERSION_NUMBER < 3004000 { - return 0, GetNotImplementedError("virStreamRecvFlags") + return 0, makeNotImplementedError("virStreamRecvFlags") } =20 var err C.virError @@ -139,7 +139,7 @@ func (v *Stream) RecvFlags(p []byte, flags StreamRecvFl= agsValues) (int, error) { // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStream= RecvHole func (v *Stream) RecvHole(flags uint) (int64, error) { if C.LIBVIR_VERSION_NUMBER < 3004000 { - return 0, GetNotImplementedError("virStreamSparseRecvHole") + return 0, makeNotImplementedError("virStreamSparseRecvHole") } =20 var len C.longlong @@ -169,7 +169,7 @@ func (v *Stream) Send(p []byte) (int, error) { // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStream= SendHole func (v *Stream) SendHole(len int64, flags uint32) error { if C.LIBVIR_VERSION_NUMBER < 3004000 { - return GetNotImplementedError("virStreamSendHole") + return makeNotImplementedError("virStreamSendHole") } =20 var err C.virError @@ -242,7 +242,7 @@ func (v *Stream) RecvAll(handler StreamSinkFunc) error { // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStream= SparseRecvAll func (v *Stream) SparseRecvAll(handler StreamSinkFunc, holeHandler StreamS= inkHoleFunc) error { if C.LIBVIR_VERSION_NUMBER < 3004000 { - return GetNotImplementedError("virStreamSparseSendAll") + return makeNotImplementedError("virStreamSparseSendAll") } =20 callbackID :=3D registerCallbackId(handler) @@ -349,7 +349,7 @@ func (v *Stream) SendAll(handler StreamSourceFunc) erro= r { // See also https://libvirt.org/html/libvirt-libvirt-stream.html#virStream= SparseSendAll func (v *Stream) SparseSendAll(handler StreamSourceFunc, holeHandler Strea= mSourceHoleFunc, skipHandler StreamSourceSkipFunc) error { if C.LIBVIR_VERSION_NUMBER < 3004000 { - return GetNotImplementedError("virStreamSparseSendAll") + return makeNotImplementedError("virStreamSparseSendAll") } =20 callbackID :=3D registerCallbackId(handler) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list