From nobody Fri Apr 19 03:17:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531265703738263.186992898153; Tue, 10 Jul 2018 16:35:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B851D30E6851; Tue, 10 Jul 2018 23:35:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 762126016F; Tue, 10 Jul 2018 23:35:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C95018037ED; Tue, 10 Jul 2018 23:35:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6ANYwt0003960 for ; Tue, 10 Jul 2018 19:34:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 57A8B5D75A; Tue, 10 Jul 2018 23:34:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 492295D750; Tue, 10 Jul 2018 23:34:54 +0000 (UTC) Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8283881F01; Tue, 10 Jul 2018 23:34:43 +0000 (UTC) Received: by mail-qk0-f193.google.com with SMTP id d22-v6so12539300qkc.8; Tue, 10 Jul 2018 16:34:43 -0700 (PDT) Received: from localhost.localdomain ([179.185.212.58]) by smtp.gmail.com with ESMTPSA id r185-v6sm7918363qkf.53.2018.07.10.16.34.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 16:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qB/fNDwnGLb6qs+0dG/GBNBuVcqdV7Iu/QDDPgIvNms=; b=caDdWXPoiFg2DlF6qoq+L0C9FMUkrjGbFAkGg9Fx5FzJ1nKNL8wXWCy1nps4WQpjM1 TaSzS2f3KAxDgJ3e0FHgFnMN2cnCoaZPPxCVa1/5BSqRJq5cW7A0FBbykPt/PpVJkvyj tlEtl4BiirXTo2qpgJNK3/1OMA8TBgzCbSQ1IlwJ2zTyIEa74kMThOLmhB8EqGB92h0s +MuikbwyulribKSx0Y6gI54OY60cpjwyEJ4RB4+XjfLxbtH7O7cTMQLP/VTjYTYfqdh8 jpziz6hUXMA4FaMjfzo2eaAunYAAzE8bqfkZWpfwFhfRQKFPjm33z9noXAG2fVam0Z51 VozA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qB/fNDwnGLb6qs+0dG/GBNBuVcqdV7Iu/QDDPgIvNms=; b=sqLH/Yxha+E5JB5W2ZK3bVTKK4Gmscz90q6Yk1bFueOmji5mEIRuLyZHrvfjNnYyQK vlwhflYmG80+ZFnesxTTp3+k0zwNQ/weueSCGmmzZdZ92xbofs/K0s5VCUyAC+71WNU5 s/mnJdukrO+ObJBBLmk5GeSQOto1npmEOjEHXKH6IrZqjSNkfxr8Axut5kHPjbTR93V/ J8fkfA9zjP4vBVqwpVRdAHrBCdvvl6+culUtn7xCU+z47VcHkZhmllhPAYeeqbO9ctwu UVPkSKt/KRwtkZ2TZdatYK/WjaWO8/iB88Bz+ChnokUyFpFutGJR/+K5YiZyUDYgHT/U bYjA== X-Gm-Message-State: APt69E06FnM2yFQCZS+IOyOWd6rm2PrCdgQ+/7P4pIcPMszJg3IELEb7 9PW2C3IdsFfHvHXjB3u3hFBXLQ== X-Google-Smtp-Source: AAOMgpc1Icwh1krgsdht2hjWC9fVdT5Wp0Q5YfvMSwHBFjDA7r6D4dq74GwZ55JCdA9dNsuz82zjHg== X-Received: by 2002:a37:188c:: with SMTP id 12-v6mr23992023qky.72.1531265682241; Tue, 10 Jul 2018 16:34:42 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Tue, 10 Jul 2018 20:30:58 -0300 Message-Id: <20180710233102.28186-2-marcos.souza.org@gmail.com> In-Reply-To: <20180710233102.28186-1-marcos.souza.org@gmail.com> References: <20180710233102.28186-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 10 Jul 2018 23:34:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 10 Jul 2018 23:34:43 +0000 (UTC) for IP:'209.85.220.193' DOMAIN:'mail-qk0-f193.google.com' HELO:'mail-qk0-f193.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.193 mail-qk0-f193.google.com 209.85.220.193 mail-qk0-f193.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Marcos Paulo de Souza Subject: [libvirt] [PATCH v3 1/5] driver.h: Add remoteOnly member to virConnectDriver struct X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 10 Jul 2018 23:35:02 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This new flag will be set when a driver needs a remote URL in order to work, as ESX, HyperV and Phyp. Signed-off-by: Marcos Paulo de Souza --- src/driver.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/driver.h b/src/driver.h index 0b1f7a2269..c4d94ba294 100644 --- a/src/driver.h +++ b/src/driver.h @@ -81,6 +81,8 @@ typedef virConnectDriver *virConnectDriverPtr; struct _virConnectDriver { /* Wether driver permits a server in the URI */ bool localOnly; + /* Wether driver needs a server in the URI */ + bool remoteOnly; /* * NULL terminated list of supported URI schemes. * - Single element { NULL } list indicates no supported schemes --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 03:17:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531265720900107.69980308692413; Tue, 10 Jul 2018 16:35:20 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6040030832E8; Tue, 10 Jul 2018 23:35:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2385E1084380; Tue, 10 Jul 2018 23:35:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B4D5818037F2; Tue, 10 Jul 2018 23:35:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6ANYxCC003965 for ; Tue, 10 Jul 2018 19:34:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2B23C30012C2; Tue, 10 Jul 2018 23:34:59 +0000 (UTC) Received: from mx1.redhat.com (ext-mx19.extmail.prod.ext.phx2.redhat.com [10.5.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F6683001A47; Tue, 10 Jul 2018 23:34:57 +0000 (UTC) Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B53CE307D844; Tue, 10 Jul 2018 23:34:46 +0000 (UTC) Received: by mail-qk0-f193.google.com with SMTP id c192-v6so12546129qkg.12; Tue, 10 Jul 2018 16:34:46 -0700 (PDT) Received: from localhost.localdomain ([179.185.212.58]) by smtp.gmail.com with ESMTPSA id r185-v6sm7918363qkf.53.2018.07.10.16.34.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 16:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VB7daaSczTpwHgQdc8mrsT99sjrW1dCYPbmBds7ZGVo=; b=Cjuo2xyciCrDKIQgg+X/6ZCRU3M0SXdHCCTypXa1F6E5mogjsIXI91MaRKMnL20CPa /t93p2JliM/uG27S7vStBb+e/hYmF9FFMMmIOuW3omUhtN9IexF0b8wGWjQO/v668eZL nAwftpz/k4aiCJcoQMsGLy8AUTdm+RhotJkDjoda9QB8Ogd1Lf1NL71xozV41kFpzXLx wl3k0OFRmd0SzizQXDEVrMyUeGKPkpVxWMQmRTppmHQ+pTCnAVBG7B7PTz2vVcEvdi6b n6QsZrYcxapNgFr7fO7A2gIFKvjyULeR8D+ojn6Lo9btVKPEzacbWZXQuNkXnDTQFVgP pAAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VB7daaSczTpwHgQdc8mrsT99sjrW1dCYPbmBds7ZGVo=; b=UrnsFTdxHRuzSKILogN0zm0Uh5PX0LYpMhHAnaST7IHSbmqKbRXyrvDom80WaBO80u 5AmtpN55RK3H/ibhHcyXX5svaZygTUodJqfezhwGrF4kGqVh5sXx3ADV5nd41vQSgcM5 TxR8KvCuIGz7xhkAYJtqffKykOSW9kdupqNabcpFtouPLlpGsVPimyyHhg8jYQAwTXfF k6Ec8uBHg5f0qFayTXkfNwKGA4ybheoBxW0ycZuYYUlYdOrs2J4zz02Wyq+LqNOk1iX5 O52Td9nEn2hoYsaLxJcCi38t+5EHXkc0Y37jEzj6L0BH2aLs/BXivGcsiWMWDStHd4wP nxBg== X-Gm-Message-State: APt69E2emaF7guZco19T/YQsCBgRtQGysF+fN5YBB1owntVc/TS76WQu 0xEUBRjUYAYAltOv3OJ6MjBknQ== X-Google-Smtp-Source: AAOMgpflfUpWNvHpQpLPlg06jvs0WtKs/Aiv90YQDIkiQEd1EuiDmprxMqy0/cLcauAxPMCqSwPy4g== X-Received: by 2002:a37:28c4:: with SMTP id o65-v6mr23527100qko.251.1531265685535; Tue, 10 Jul 2018 16:34:45 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Tue, 10 Jul 2018 20:30:59 -0300 Message-Id: <20180710233102.28186-3-marcos.souza.org@gmail.com> In-Reply-To: <20180710233102.28186-1-marcos.souza.org@gmail.com> References: <20180710233102.28186-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 10 Jul 2018 23:34:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 10 Jul 2018 23:34:46 +0000 (UTC) for IP:'209.85.220.193' DOMAIN:'mail-qk0-f193.google.com' HELO:'mail-qk0-f193.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.193 mail-qk0-f193.google.com 209.85.220.193 mail-qk0-f193.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.48 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Marcos Paulo de Souza Subject: [libvirt] [PATCH v3 2/5] libvirt.c: Return error when remoteOnly is set but server is empty X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 10 Jul 2018 23:35:20 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Some drivers require a server in order to work, so this flag removes the burden of esach driver to check for an server by doing it in virConnectOpenInternal. Signed-off-by: Marcos Paulo de Souza --- src/libvirt.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 52f4dd2808..aeb8804714 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1029,6 +1029,13 @@ virConnectOpenInternal(const char *name, VIR_DEBUG("Matching any URI scheme for '%s'", ret->uri ? ret->= uri->scheme : ""); } =20 + /* before starting the new connection, check if the driver only wo= rks + * with a server, and so return an error if the server is missing = */ + if (virConnectDriverTab[i]->remoteOnly && ret->uri && !ret->uri->s= erver) { + virReportError(VIR_ERR_INVALID_ARG, "%s", _("URI is missing th= e server part")); + goto failed; + } + ret->driver =3D virConnectDriverTab[i]->hypervisorDriver; ret->interfaceDriver =3D virConnectDriverTab[i]->interfaceDriver; ret->networkDriver =3D virConnectDriverTab[i]->networkDriver; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 03:17:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531265720983711.8133168967828; Tue, 10 Jul 2018 16:35:20 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3ED7A307D865; Tue, 10 Jul 2018 23:35:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECEBB2010CE6; Tue, 10 Jul 2018 23:35:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8D95F4A46C; Tue, 10 Jul 2018 23:35:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6ANZ4BR003982 for ; Tue, 10 Jul 2018 19:35:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3CF7019484; Tue, 10 Jul 2018 23:35:04 +0000 (UTC) Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F62019483; Tue, 10 Jul 2018 23:35:01 +0000 (UTC) Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2ECD28110C; Tue, 10 Jul 2018 23:34:50 +0000 (UTC) Received: by mail-qk0-f194.google.com with SMTP id a132-v6so12545876qkg.3; Tue, 10 Jul 2018 16:34:50 -0700 (PDT) Received: from localhost.localdomain ([179.185.212.58]) by smtp.gmail.com with ESMTPSA id r185-v6sm7918363qkf.53.2018.07.10.16.34.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 16:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hdCriKHXbp97DMPVwqCK2WZwu7y0atrvybYehX2uOg8=; b=D2w1iCg5PNsKQ3aSvYsTDvbny3w2xz0ufPJlcIrvOCTBA2klsdHLCobSuqFg/8paua 8mnxmXBSull6o2jmxSD1MFKjpQcJXiZr0obPEzzN2TImZ81L49VrL3p75H4ya027DbkU JkxUZZcadP4NS5Jme0bSsoNpQnTDG8L84AWQFaA7lm6xsIUDu2e21URDx1Zbe9I7BX8L s5JoTwX4wLY7tnIl7ad+WyBb3M/vspcsXoknpygnJLKhagkNh2OYL7GvSMInbC0S8V2F fO3UBjlf+gVVXP4WXelRjdGvwC3UqqHUNlWvJFGTIt+i2y0VY86nmdXpfVOlWciRH5vH u3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hdCriKHXbp97DMPVwqCK2WZwu7y0atrvybYehX2uOg8=; b=VUSvfCMMRFTzgnto7Z+cKk1w8zN2H3TgGh5/1Jve/WCSxHS1KETqdQ+jtAsWDnRZM+ vpf9nGIUxj2hqWSLP9bnFVfX9I16B8y4axcoItdqU26AGyPiU+kjEAdzaHb13vXbArDC By1/OTO4rd9/ngDwvy0MrpyrAJvwH9yQmedwc5n/QfuY6p5aqPjqMYtQg7Eb2znMpMK1 0NwkVZJYDgPm8DX2TdnN77thykJh5jiAVmUJhr7lj/g7zFFUnjU+0kUEfrnsZhgtTI9D sEwxunu+AXeaTo0p2QvBxIlXUEfbmuR2era01LOw0VBdC/ccpkzEhZB7cZw9xoeyngrR moGg== X-Gm-Message-State: APt69E1FyUDI3043lLvC9ssZX3LvcyticOBTIKW1DA0WJjljvW/Cu6Aw 8sV6SlXBboYhu1oqRX1TooBv1Q== X-Google-Smtp-Source: AAOMgpfWJ580wh6QeTARidvzneGRnPcblaaAc4wcHFuMhCdo3DAys6FJQDuF8q1D+pZ0HcRgCmXFTQ== X-Received: by 2002:a37:9e17:: with SMTP id h23-v6mr22511307qke.269.1531265688983; Tue, 10 Jul 2018 16:34:48 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Tue, 10 Jul 2018 20:31:00 -0300 Message-Id: <20180710233102.28186-4-marcos.souza.org@gmail.com> In-Reply-To: <20180710233102.28186-1-marcos.souza.org@gmail.com> References: <20180710233102.28186-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 Jul 2018 23:34:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 Jul 2018 23:34:50 +0000 (UTC) for IP:'209.85.220.194' DOMAIN:'mail-qk0-f194.google.com' HELO:'mail-qk0-f194.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.194 mail-qk0-f194.google.com 209.85.220.194 mail-qk0-f194.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Marcos Paulo de Souza Subject: [libvirt] [PATCH v3 3/5] esx_driver: Set remoteOnly member of virConnectDriver X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 10 Jul 2018 23:35:19 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" ESX driver can't function without a server being informed, so this flag makes libvirt to check for a valid server before calling connectOpen. Signed-off-by: Marcos Paulo de Souza --- src/esx/esx_driver.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 06e1238385..d937daac83 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -854,13 +854,6 @@ esxConnectOpen(virConnectPtr conn, virConnectAuthPtr a= uth, conn->uri->path, conn->uri->scheme); } =20 - /* Require server part */ - if (!conn->uri->server) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("URI is missing the server part")); - return VIR_DRV_OPEN_ERROR; - } - /* Require auth */ if (!auth || !auth->cb) { virReportError(VIR_ERR_INVALID_ARG, "%s", @@ -5218,6 +5211,7 @@ static virConnectDriver esxConnectDriver =3D { .interfaceDriver =3D &esxInterfaceDriver, .networkDriver =3D &esxNetworkDriver, .storageDriver =3D &esxStorageDriver, + .remoteOnly =3D true, }; =20 int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 03:17:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531265711808132.64691392636007; Tue, 10 Jul 2018 16:35:11 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC0EF4E918; Tue, 10 Jul 2018 23:35:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7AF13001A50; Tue, 10 Jul 2018 23:35:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5599F4A460; Tue, 10 Jul 2018 23:35:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6ANZ7hD003993 for ; Tue, 10 Jul 2018 19:35:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id C27871001F5B; Tue, 10 Jul 2018 23:35:07 +0000 (UTC) Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B847C1001947; Tue, 10 Jul 2018 23:35:04 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7756DC049E37; Tue, 10 Jul 2018 23:34:53 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id f1-v6so19923357qti.3; Tue, 10 Jul 2018 16:34:53 -0700 (PDT) Received: from localhost.localdomain ([179.185.212.58]) by smtp.gmail.com with ESMTPSA id r185-v6sm7918363qkf.53.2018.07.10.16.34.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 16:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=C2QWd9DEv7R44hgJsFy+GkqC5R3v40WkhCOd3s1RWis=; b=WVm/axtinGb1MnDpd1if7HzVqbKzr7A7VZW2ZCFGPfHkTVox44XoNNsVah/i3+rSkm HKtinTKv6RdrjaoGCp6EZ1285JB0HcBBJXhh5GJzzkYHnbrIUMs6pFdU8ZVffcljyNsr XisSBU3e67hv6ZquBAfnBlkTrnQcYbsCqnpqjFmDgYlJVZmR1zB1FrJjesunuAc4IC/q 9tkSEbtiWCuCZQm5OSLrbUMptOCQuOuyW7HJ5aEPFF2TCQSQeU9lP/vLTjN4KGoSlJBz 99Iq47Nu69S9gzqlBMehOCYxtDsdEvh8YER5OZv2mj7VR6FYI9bJU7q5Knxi4lqxN/1Q 5DTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=C2QWd9DEv7R44hgJsFy+GkqC5R3v40WkhCOd3s1RWis=; b=Hs67ssIUHlztyme+oYSIyDl8cp90Fr2soySESokuCCpm7CFVm3XAv9Pl5I2ZtZ33oD SuHKC5UU5QypxWnxk7ZV3jV1+4pZT29lI5EPgmG1oE7qyQDReqnl9ProiAeVZ2UnMF5v 3AdYsCtXdjAgKpvdZfVs86NC4vds4kATbm4vWZ5ZWC6wt58oZInbOC/95qdnpqO1n/vy jgT214vkB0gwT75LICF7ymuQeGXdR6vv9AiWHwHSciCuaErCTt+qfdQC+qf4pagTWCyh JDjrFg1+dTCmJra/ckcOjr7WpUfsYWuLtC7hXjxXKL/qvyCKGMYLEXfJndXLTxazSZy2 UYUA== X-Gm-Message-State: APt69E0e4pr65srMTwNGxn2XvBbEYRCjcDtUgkdjLuxi3Ro2dPPuco7g 52vnnej/BgwZfSgKXQ5R/4ZvlQ== X-Google-Smtp-Source: AAOMgpdHWAs/lmfcN+axrnmkN9eZDmGazFmEPRwsNGVd4Y7feF41l1KAvZasfowocl/lR1rIUNHgDg== X-Received: by 2002:ac8:3274:: with SMTP id y49-v6mr25146029qta.194.1531265692270; Tue, 10 Jul 2018 16:34:52 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Tue, 10 Jul 2018 20:31:01 -0300 Message-Id: <20180710233102.28186-5-marcos.souza.org@gmail.com> In-Reply-To: <20180710233102.28186-1-marcos.souza.org@gmail.com> References: <20180710233102.28186-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 10 Jul 2018 23:34:53 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 10 Jul 2018 23:34:53 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Marcos Paulo de Souza Subject: [libvirt] [PATCH v3 4/5] hyperv_driver: Set remoteOnly member of virConnectDriver X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 10 Jul 2018 23:35:10 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" HyperV driver can't function without a server being informed, so this flag makes libvirt to check for a valid server before calling connectOpen. Signed-off-by: Marcos Paulo de Souza --- src/hyperv/hyperv_driver.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 95496bdf73..8bda334cf9 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -128,13 +128,6 @@ hypervConnectOpen(virConnectPtr conn, virConnectAuthPt= r auth, =20 virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); =20 - /* Require server part */ - if (conn->uri->server =3D=3D NULL) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("URI is missing the server part")); - return VIR_DRV_OPEN_ERROR; - } - /* Require auth */ if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { virReportError(VIR_ERR_INVALID_ARG, "%s", @@ -1664,6 +1657,7 @@ hypervDebugHandler(const char *message, debug_level_e= level, static virConnectDriver hypervConnectDriver =3D { .uriSchemes =3D (const char *[]){ "hyperv", NULL }, .hypervisorDriver =3D &hypervHypervisorDriver, + .remoteOnly =3D true, }; =20 int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Apr 19 03:17:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531265721246518.9993788116609; Tue, 10 Jul 2018 16:35:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 45EC78110C; Tue, 10 Jul 2018 23:35:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 074A45DD6F; Tue, 10 Jul 2018 23:35:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9D00E4A46D; Tue, 10 Jul 2018 23:35:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6ANZAmJ004004 for ; Tue, 10 Jul 2018 19:35:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id F3E1AC683B; Tue, 10 Jul 2018 23:35:09 +0000 (UTC) Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBA08BB907; Tue, 10 Jul 2018 23:35:07 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0E854E90E; Tue, 10 Jul 2018 23:34:56 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id m13-v6so19925423qth.1; Tue, 10 Jul 2018 16:34:56 -0700 (PDT) Received: from localhost.localdomain ([179.185.212.58]) by smtp.gmail.com with ESMTPSA id r185-v6sm7918363qkf.53.2018.07.10.16.34.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 16:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1OcYfDKeqQFR2DKDXc518NAEyUxqxOMuGW+7sdp5N8U=; b=fRt1I1t6pGeYmLMEwlZsycF4duItStx7RvsMIvpSmuQGe3U09csnMwTEyTSDPYDHSd YBVhrBtH+FcIvy7QaXns5UZYvW6LYU59orPpb6sEsQiJBH2QR5ENtGgo+wVa/LtRm7sR q9uJvdcLo1A3iz5pB+ufLMmeI9ynAH3avkdt3eydBc5XZTgNAvJSY1S7Lq4rX6opy5Dl kdS1zL9tw2gnCzMN+G9N/ReHC+OeTuPb15rnUk91THlyOukIww6iO+lzZjDPCsMjWBe5 +iTeIzbyccvZtvlds3+PMBUEctb8H0N/XqTSk9qm5V/p/tQHi6t2ROrIkojyrfNSHPU2 SiKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1OcYfDKeqQFR2DKDXc518NAEyUxqxOMuGW+7sdp5N8U=; b=OQUr5sgTzLDkuWl1bmRPN+0U1JoTlkhqk5LIc3EYmIn0P3vqC337uZm5RVNZWc2iRF qdEbzcEDudm5OapbsTLIXA9uvrUvlaiaHxZFi499bvl1mjoILg5ODVrIB/y+R0P2azX/ CplD2bu2kKKl3nrdPMGFnsdI2zpFAv0Hw2/fWwvoeLFl2+DLaT6hf6IyKiqXkJcrbr/i 3nwlEHF4qquBHmQrfqnwc0sqx98oegASbGYlFMADgVXLgoclugowZxLVlX6WLqFPkZDq eO9x9Qz/pd7r0fHSpdsFH1NB9BGt4bGGX8asSOL7Lgqc5ty3aTc6ID6YwviAp7uF7zTF oshQ== X-Gm-Message-State: APt69E1lkxjL956ewxlt+2dup1rnJOS/1NFDWOJE9h+MISMZ5sXwdVf4 9Nq8g9BEeagckAA4JGBUo6AaQQ== X-Google-Smtp-Source: AAOMgpcqjZKYhGI8+32VHNNNfFcbYm5HwDX3oTQ42cMihtfx2MCoQCFIzk5RDwazL2HW6rNFiu6gdw== X-Received: by 2002:aed:3608:: with SMTP id e8-v6mr25276165qtb.75.1531265695409; Tue, 10 Jul 2018 16:34:55 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Tue, 10 Jul 2018 20:31:02 -0300 Message-Id: <20180710233102.28186-6-marcos.souza.org@gmail.com> In-Reply-To: <20180710233102.28186-1-marcos.souza.org@gmail.com> References: <20180710233102.28186-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 10 Jul 2018 23:34:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 10 Jul 2018 23:34:56 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Marcos Paulo de Souza Subject: [libvirt] [PATCH v3 5/5] phyp_driver: Set remoteOnly member of virConnectDriver X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 Jul 2018 23:35:20 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Phyp driver can't function without a server being informed, so this flag makes libvirt to check for a valid server before calling connectOpen. Signed-off-by: Marcos Paulo de Souza --- src/phyp/phyp_driver.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 67ce7903ba..303a7151b7 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1141,12 +1141,6 @@ phypConnectOpen(virConnectPtr conn, =20 virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); =20 - if (conn->uri->server =3D=3D NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Missing server name in phyp:// URI")); - return VIR_DRV_OPEN_ERROR; - } - if (VIR_ALLOC(phyp_driver) < 0) goto failure; =20 @@ -3764,6 +3758,7 @@ static virConnectDriver phypConnectDriver =3D { .hypervisorDriver =3D &phypHypervisorDriver, .interfaceDriver =3D &phypInterfaceDriver, .storageDriver =3D &phypStorageDriver, + .remoteOnly =3D true, }; =20 int --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list