From nobody Mon Feb 9 00:20:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531153383555697.2534420206027; Mon, 9 Jul 2018 09:23:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F3A3C0587F8; Mon, 9 Jul 2018 16:23:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 576AE100190E; Mon, 9 Jul 2018 16:23:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB34824601; Mon, 9 Jul 2018 16:23:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69GMw8V020173 for ; Mon, 9 Jul 2018 12:22:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD7C91001918; Mon, 9 Jul 2018 16:22:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx19.extmail.prod.ext.phx2.redhat.com [10.5.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B61E0100190E for ; Mon, 9 Jul 2018 16:22:58 +0000 (UTC) Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFCDD307D86B for ; Mon, 9 Jul 2018 16:22:47 +0000 (UTC) Received: by mail-qk0-f193.google.com with SMTP id t79-v6so9985071qke.4 for ; Mon, 09 Jul 2018 09:22:47 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a608:24e1:ab77:9d92:aaf7]) by smtp.gmail.com with ESMTPSA id y21-v6sm2575094qtc.41.2018.07.09.09.22.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 09:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hZ0P8M/OBzth6wkr6SwKNOn+yZuqdMH5ZH3EyhBx1EY=; b=T3kYoY0d8KxXU/WX7zL61urUzZ3eSTwCmcVwV52atZLkzNYS3En6QgABUVsNs6Vwl1 x3vT5ubuZu/CIYfpAEx18L+yUDL6BU9KnovZLEBEi1OYtGGuPqyKcLx9s5wme8kHDcFk M3plDRNrBTx/cUug6f5SkbZ8++ixPyiM2go72OzWKMBpGvNC3m+kvxGcucABInU+ECX6 wQB4LSzEznOg19LjV01XjznPjXTbuoUzbKB8ltBN56Iq5U1xhXj8TE6x6Kguf5rm7Eix 0CmhL3X00CgSZ7fS/2Ewiu26qvoJNdV3Zt/BrAMDFpRg2tOAJSVzGB2mtMso2K1fGlRS AHRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hZ0P8M/OBzth6wkr6SwKNOn+yZuqdMH5ZH3EyhBx1EY=; b=M9f9d2sz103OfBmETJ9SCckH0Qdy6WKnzNgCOuL54R0uKuKTos1vCf+Zruzf065jGN aFMgWSTEjH4A5gG9VbeRXSWnM5N213VbNqXwIUEmJgRGOvO8M8haFA1jbKqxz5RxEqC1 6mI+We/UaabnzbQnRzz6PL7+kivUVYODJYykUYOkiO15oKQP0nmbOnKz0RzLTUUipKHB wfKhypEnot8ARvEphqpb9gTvMA+3IVaX8scZja29FgWs0ccGEHhmz6lkr2RaCyxkR4r4 6xhPySWeWwsMF+A05VAh8xgoBKJJWouYIbdjaUrAjeONxIX+OAo9Kv7SLA88WoULDYuq riXg== X-Gm-Message-State: APt69E1jc7zgoyzOxZ6hp1Yg1Uhr2IzUuaI4PgWrdNdSSAlT+u86YO/d xxVcx63MmglpVgpVQlTMM+bJiQ== X-Google-Smtp-Source: AAOMgpeUpJI0I5q6/CBIVn1CHX9Y1sPS0HZ0s4BzfZFpzzkVVxjXWHlMmKnA+P3ZNjpqtCPw7iyz5w== X-Received: by 2002:a37:d1cc:: with SMTP id o73-v6mr17816354qkl.293.1531153366800; Mon, 09 Jul 2018 09:22:46 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 13:22:20 -0300 Message-Id: <20180709162223.5239-3-marcos.souza.org@gmail.com> In-Reply-To: <20180709162223.5239-1-marcos.souza.org@gmail.com> References: <20180709162223.5239-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 09 Jul 2018 16:22:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 09 Jul 2018 16:22:48 +0000 (UTC) for IP:'209.85.220.193' DOMAIN:'mail-qk0-f193.google.com' HELO:'mail-qk0-f193.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.193 mail-qk0-f193.google.com 209.85.220.193 mail-qk0-f193.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.48 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 2/5] libvirt.c: Return error when remoteOnly is set but server is empty X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 09 Jul 2018 16:23:02 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Some drivers require a server in order to work, so this flag removes the burden of esach driver to check for an server by doing it in virConnectOpenInternal. Signed-off-by: Marcos Paulo de Souza --- src/libvirt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 52f4dd2808..9ae4e774eb 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1005,6 +1005,11 @@ virConnectOpenInternal(const char *name, continue; } =20 + if (virConnectDriverTab[i]->remoteOnly && ret->uri && !ret->uri->s= erver) { + virReportError(VIR_ERR_INVALID_ARG, "%s", _("URI is missing th= e server part")); + goto failed; + } + /* Filter drivers based on declared URI schemes */ if (virConnectDriverTab[i]->uriSchemes) { bool matchScheme =3D false; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list