From nobody Sun Feb 8 10:50:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531012064678502.7723391453045; Sat, 7 Jul 2018 18:07:44 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99D9937F43; Sun, 8 Jul 2018 01:07:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36AEF2015E40; Sun, 8 Jul 2018 01:07:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D60324A465; Sun, 8 Jul 2018 01:07:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6817aTr030071 for ; Sat, 7 Jul 2018 21:07:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1E210308BDA5; Sun, 8 Jul 2018 01:07:36 +0000 (UTC) Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D234308BDA3 for ; Sun, 8 Jul 2018 01:07:33 +0000 (UTC) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24351356C2 for ; Sun, 8 Jul 2018 01:07:23 +0000 (UTC) Received: by mail-qk0-f195.google.com with SMTP id z74-v6so8141398qkb.10 for ; Sat, 07 Jul 2018 18:07:23 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a19b:75f1:49c8:66b0:6e4d]) by smtp.gmail.com with ESMTPSA id e11-v6sm8007287qkb.4.2018.07.07.18.07.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jul 2018 18:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=06rNA5vkfooMUHP2Yuds0qxwk1YCwTnuGgyLAFrektE=; b=nNCrTiAE91p3WMM+gY2LlE0OKpQmp2AqJ4UT9ooW7qUaeeu7LW1qzEzx1wyHaGlMJ7 Qe4DaiWawc0ievhAXxydOR+yAaRGQ6wTiysWq9oLt3H6JJNr0NU5XFjE8/J04RW/v+oG TGV3MkAcQ3eJiMwpxmjAPIeByFFH4t/RA+ps8VYMIqX34CAs1xgvBs41KhZ/tlJBkjFf dYP9vJAINI1hS9SmRQbA70s1sIK01VaK5FGyPawbeF2buWaql+15aRxnqqoLsGL3bd/8 xIfWJK9HpUm5hv/qwqmAqH/Ic5mg/i0QgHcsRvNZNL8b+wgHH2yUNVF0tbtQQRX3gc7h Vs+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=06rNA5vkfooMUHP2Yuds0qxwk1YCwTnuGgyLAFrektE=; b=a6snyv5upZSae76RHUG0vnjM6ko86RwM1EvkDYiPlJF0Y16J8t/4mB5zjP07LA2CZI 4kEvOHUeUIRB15SpDNj//KbtqaOSuX7HbDAXhewFzwTE9pw7KWo1nMbXzX+LdLuInAMw 6Tf0356DegNPjsBftRzyZGidSMQFFSJd0q4UN9bknrDkV9EaFyRqcKyDsHfTwUAK1OSo dJWdiqo1l60Y7rbLcA9MWF2EP+Y5vhGhhaHdCs5MmAohNGJ3r6Ix0Aej9EXMRuZxD/8z hvSg6RDd9KHu+0vQecg12NPJMxI0/BoaGvJgFWChalH7fPROQsywAVDRUU6Markd1tZk m8XQ== X-Gm-Message-State: APt69E25TEbm4SuzHkf2lO7zv6QaTyTDqYdYG91hYT+/R2g5kLefn0R9 PEf3qK+9aR4o5nu9lC1oo3vQXw== X-Google-Smtp-Source: AAOMgpfcAuA5Qlziz7vBfZASs2BWwyt9SWAYs3Rp9pD3edSFdYzbosNhO7XNEweJ+OtrpKSzCT35tw== X-Received: by 2002:ae9:e118:: with SMTP id g24-v6mr13045992qkm.306.1531012041870; Sat, 07 Jul 2018 18:07:21 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Sat, 7 Jul 2018 22:06:56 -0300 Message-Id: <20180708010656.9047-5-marcos.souza.org@gmail.com> In-Reply-To: <20180708010656.9047-1-marcos.souza.org@gmail.com> References: <20180708010656.9047-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 08 Jul 2018 01:07:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 08 Jul 2018 01:07:23 +0000 (UTC) for IP:'209.85.220.195' DOMAIN:'mail-qk0-f195.google.com' HELO:'mail-qk0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.195 mail-qk0-f195.google.com 209.85.220.195 mail-qk0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [RFC PATCH 4/4] phyp_driver: Use VIR_DRV_CONN_CHECK_SERVER macro X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sun, 08 Jul 2018 01:07:40 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" phyp needs a server to connect to, so use this macro in order to reuse code. Signed-off-by: Marcos Paulo de Souza --- src/phyp/phyp_driver.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 67ce7903ba..beca1c6fc7 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1141,11 +1141,7 @@ phypConnectOpen(virConnectPtr conn, =20 virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); =20 - if (conn->uri->server =3D=3D NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Missing server name in phyp:// URI")); - return VIR_DRV_OPEN_ERROR; - } + VIR_DRV_CONN_CHECK_SERVER; =20 if (VIR_ALLOC(phyp_driver) < 0) goto failure; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list