From nobody Mon Feb 9 23:44:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531012088627996.9309347169885; Sat, 7 Jul 2018 18:08:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6EBEDC049D4B; Sun, 8 Jul 2018 01:08:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CE6610694C3; Sun, 8 Jul 2018 01:08:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D6C6518037EF; Sun, 8 Jul 2018 01:08:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6817Vbo030050 for ; Sat, 7 Jul 2018 21:07:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 07487764EF; Sun, 8 Jul 2018 01:07:31 +0000 (UTC) Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1592173EA for ; Sun, 8 Jul 2018 01:07:28 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1E443084023 for ; Sun, 8 Jul 2018 01:07:17 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id z6-v6so12906677qti.2 for ; Sat, 07 Jul 2018 18:07:17 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:a19b:75f1:49c8:66b0:6e4d]) by smtp.gmail.com with ESMTPSA id e11-v6sm8007287qkb.4.2018.07.07.18.07.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jul 2018 18:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CI72SowUfvNHcTvPvi4k0oRWZsssnnkkYQlaAimN2Uw=; b=Rw0il6jccyNmoBh1/GK17ZqcBSLMMVwJrJqD/S76vJYAfyF83yhpbrM7q17xV3+i5m 1pkEXHGwBfZ4+9ARkDPZxoZnsMRAwtYTguvq+q24ZmsuuIc6t82Ufv4IZck2ggyZy2wB Sgh3FlwIkyVBq3zTstIQgEp2AhZ6SlJIB+Q1QO0Sdmk8OJrdw4mTcUfUT5wCr3CK66HF dtzh7sGxwE0jMVTsA0ui1Rha5C1LpCrVYHJrZSsuNH0w5W8dlXBXMbKIs4pjHwV0Z9W3 80pSSZM788qzZI5S28+7zx72bZAAFaErL0kBqkGDT5Ul2Ch+RDijvPrRxaDQZ4DPhp7k pGFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CI72SowUfvNHcTvPvi4k0oRWZsssnnkkYQlaAimN2Uw=; b=ZP4yUuKf9d7OFB/do/jTpfX7W1OypwaL/XyuJNPhJv2ENMa9n+FmHSZExonayPLR2a ZWZSuVKVOpJWFpguiixX+orF8I6iZwHJmNaAsxoZbVT6YWxBcrjdR8GQ0zuiXbQ1rZWh zW/Jv5R4OfwiMiK6feReQcL0lclNqhGPHbcB4BcvIduypTJRJqw9oGo3mWkIsLmt/Rft wGBOTbnuIJiYNrGWr1kCxDKPvNtcv37hpDgjXqZ3lprJh8e4uZVSUwtB6dpcEfyWW9eM p0uoeo2uP8PO0sTE4hljVm2txOzJFj/oCgU1NfihA+WMq9//XeJZkyZZ9CIPsdGBGJ1a e9Yw== X-Gm-Message-State: APt69E2OnV92oHA8FJbrGHlEGQc3kW+MSIZ4TEn/9hSB8SBTrhAgOAaZ 8uLMhQvD/5TsV7AyQp9+TRUvgA== X-Google-Smtp-Source: AAOMgpc4IbEzlqK/wHv7F6DnKmLqyjCUm2CECf3lhJ7at7PVkcuFGCQqG23QLbk5SIc2E14XkPsCQQ== X-Received: by 2002:a0c:dc0c:: with SMTP id s12-v6mr13487627qvk.155.1531012036574; Sat, 07 Jul 2018 18:07:16 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Sat, 7 Jul 2018 22:06:54 -0300 Message-Id: <20180708010656.9047-3-marcos.souza.org@gmail.com> In-Reply-To: <20180708010656.9047-1-marcos.souza.org@gmail.com> References: <20180708010656.9047-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Sun, 08 Jul 2018 01:07:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Sun, 08 Jul 2018 01:07:17 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.40 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [RFC PATCH 2/4] esx_driver: Use VIR_DRV_CONN_CHECK_SERVER macro X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 08 Jul 2018 01:08:08 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" ESX needs a server to connect to, so use this macro in order to reuse code. Signed-off-by: Marcos Paulo de Souza --- src/esx/esx_driver.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 06e1238385..89ac7c430f 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -854,12 +854,7 @@ esxConnectOpen(virConnectPtr conn, virConnectAuthPtr a= uth, conn->uri->path, conn->uri->scheme); } =20 - /* Require server part */ - if (!conn->uri->server) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("URI is missing the server part")); - return VIR_DRV_OPEN_ERROR; - } + VIR_DRV_CONN_CHECK_SERVER; =20 /* Require auth */ if (!auth || !auth->cb) { --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list