From nobody Sat May 11 11:13:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15301120224301002.2364101621744; Wed, 27 Jun 2018 08:07:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4524F369CF; Wed, 27 Jun 2018 15:06:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8889410018F9; Wed, 27 Jun 2018 15:06:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 16A784A460; Wed, 27 Jun 2018 15:06:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5RF6toS013456 for ; Wed, 27 Jun 2018 11:06:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id 229902AE62; Wed, 27 Jun 2018 15:06:55 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A4592B21F for ; Wed, 27 Jun 2018 15:06:55 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E3A9820FD for ; Wed, 27 Jun 2018 15:06:43 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id a18-v6so1922219qtj.4 for ; Wed, 27 Jun 2018 08:06:43 -0700 (PDT) Received: from localhost.localdomain ([186.223.99.201]) by smtp.gmail.com with ESMTPSA id r13-v6sm3480856qti.70.2018.06.27.08.06.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 08:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=BYLwBB8B3eI+ek+DOXomsKqJCUW0Qyxn8ro6q7+wJB8=; b=N1TaT3FNFA9jUkUtTC3Z3NAcVNEuxVSFVGDm3tH14YH5JbFeYi3203f9fUh2/dm0cD FaosmGJNsVJ0PYnpMdR6cvXu7muF6LZL5KlicjxIUWNq1KmxNLBdh768CZMbB9JlktfV QhawArAAYDm8EMCf50tBhVumBSNo5n4nuK5/lTU4ro/33U23xzdHC62ryxCk8veVW6DH 5FtlEhkJwXMgUGXh/YfyJf0ynBTM9g2MzOTixIns9gw5Oh/XYJv3/BSa0Hb9Dym7iJbU Dgt37eayaCNllTHbCE4y3X9uURR/n10Q9Nmq/BQGa0Zlm9y/DsFup2G95atTfu5c8D8w LJ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=BYLwBB8B3eI+ek+DOXomsKqJCUW0Qyxn8ro6q7+wJB8=; b=gIbeDdBFin8/W69rEaRsht7YZjv9UQbax1/pkj/ufV+bdZm0VoJGbOKDLBp9WinKh1 aC57KIFLirnnfASDpv5AZo5eB55BFz/ed82D5Xe9W1VXkKEtPmXeqG6pKF++Uexm9zLD ZAuhdCSaaU3Qoos2VUko0myNKJ/WTCaWIuIxl/k9FkjXD1iezP3LQruixYVF/gDkEOF9 IE1BPr6dwFfyoVppTAen2MoZGK4B4hVigC3yrOBCPZVJE+iLoMG61aNW79g6tmaNpRYf c7ANuuI6Ckuos/O//JJrRD8yTtf/knyLtQzpWI5swfXzpdyqURxeI9ItklYwDR7MGYEv 7uFw== X-Gm-Message-State: APt69E19dY12cYwH4/0SNoulBXIaVIlXkDW2SVzth+oJObrjsMBWTxwZ zofI0je0eEPOXgCA9qje5UuQkA== X-Google-Smtp-Source: AAOMgpdIM0rmLUh4Y3U7HDTNa7N85BYK36GcqJ+k2UxmXhXPZj4ofwmcD5R4Kumrb1RYuoKd8h59Xg== X-Received: by 2002:a0c:fa89:: with SMTP id o9-v6mr5758104qvn.160.1530112002122; Wed, 27 Jun 2018 08:06:42 -0700 (PDT) From: Julio Faracco To: libvir-list@redhat.com Date: Wed, 27 Jun 2018 12:06:25 -0300 Message-Id: <20180627150626.19343-2-jcfaracco@gmail.com> In-Reply-To: <20180627150626.19343-1-jcfaracco@gmail.com> References: <20180627150626.19343-1-jcfaracco@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 27 Jun 2018 15:06:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 27 Jun 2018 15:06:43 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 1/2] lxc: moving 'type' argument to avoid issues with mount() syscall. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 27 Jun 2018 15:07:00 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This commit fixes a lots of mount calls inside lxc_container.c file. The NULL value into 'type' argument is causing a valgrind issue. See commit 794b576c2b for more details. The best approach to fix it is moving NULL to "none" filesytem. Signed-off-by: Julio Faracco --- src/lxc/lxc_container.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 665b93a0ac..3a1b2d6819 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -720,7 +720,7 @@ static int lxcContainerPivotRoot(virDomainFSDefPtr root) VIR_DEBUG("Pivot via %s", root->src->path); =20 /* root->parent must be private, so make / private. */ - if (mount("", "/", NULL, MS_PRIVATE|MS_REC, NULL) < 0) { + if (mount("", "/", "none", MS_PRIVATE|MS_REC, NULL) < 0) { virReportSystemError(errno, "%s", _("Failed to make root private")); goto err; @@ -757,7 +757,7 @@ static int lxcContainerPivotRoot(virDomainFSDefPtr root) } =20 /* ... and mount our root onto it */ - if (mount(root->src->path, newroot, NULL, MS_BIND|MS_REC, NULL) < 0) { + if (mount(root->src->path, newroot, "none", MS_BIND|MS_REC, NULL) < 0)= { virReportSystemError(errno, _("Failed to bind %s to new root %s"), root->src->path, newroot); @@ -765,7 +765,7 @@ static int lxcContainerPivotRoot(virDomainFSDefPtr root) } =20 if (root->readonly) { - if (mount(root->src->path, newroot, NULL, MS_BIND|MS_REC|MS_RDONLY= |MS_REMOUNT, NULL) < 0) { + if (mount(root->src->path, newroot, "none", MS_BIND|MS_REC|MS_RDON= LY|MS_REMOUNT, NULL) < 0) { virReportSystemError(errno, _("Failed to make new root %s readonly"), root->src->path); @@ -815,9 +815,9 @@ typedef struct { =20 static const virLXCBasicMountInfo lxcBasicMounts[] =3D { { "proc", "/proc", "proc", MS_NOSUID|MS_NOEXEC|MS_NODEV, false, false,= false }, - { "/proc/sys", "/proc/sys", NULL, MS_BIND|MS_NOSUID|MS_NOEXEC|MS_NODEV= |MS_RDONLY, false, false, false }, - { "/.oldroot/proc/sys/net/ipv4", "/proc/sys/net/ipv4", NULL, MS_BIND, = false, false, true }, - { "/.oldroot/proc/sys/net/ipv6", "/proc/sys/net/ipv6", NULL, MS_BIND, = false, false, true }, + { "/proc/sys", "/proc/sys", "none", MS_BIND|MS_NOSUID|MS_NOEXEC|MS_NOD= EV|MS_RDONLY, false, false, false }, + { "/.oldroot/proc/sys/net/ipv4", "/proc/sys/net/ipv4", "none", MS_BIND= , false, false, true }, + { "/.oldroot/proc/sys/net/ipv6", "/proc/sys/net/ipv6", "none", MS_BIND= , false, false, true }, { "sysfs", "/sys", "sysfs", MS_NOSUID|MS_NOEXEC|MS_NODEV|MS_RDONLY, fa= lse, false, false }, { "securityfs", "/sys/kernel/security", "securityfs", MS_NOSUID|MS_NOE= XEC|MS_NODEV|MS_RDONLY, true, true, false }, #if WITH_SELINUX @@ -876,7 +876,7 @@ static int lxcContainerSetReadOnly(void) =20 for (i =3D 0; i < nmounts; i++) { VIR_DEBUG("Bind readonly %s", mounts[i]); - if (mount(mounts[i], mounts[i], NULL, MS_BIND|MS_REC|MS_RDONLY|MS_= REMOUNT, NULL) < 0) { + if (mount(mounts[i], mounts[i], "none", MS_BIND|MS_REC|MS_RDONLY|M= S_REMOUNT, NULL) < 0) { virReportSystemError(errno, _("Failed to make mount %s readonly"), mounts[i]); @@ -994,7 +994,7 @@ static int lxcContainerMountBasicFS(bool userns_enabled, } =20 if (bindOverReadonly && - mount(mnt_src, mnt->dst, NULL, + mount(mnt_src, mnt->dst, "none", MS_BIND|MS_REMOUNT|mnt_mflags|MS_RDONLY, NULL) < 0) { virReportSystemError(errno, _("Failed to re-mount %s on %s flags=3D0x= %x"), @@ -1069,7 +1069,7 @@ static int lxcContainerMountFSDev(virDomainDefPtr def, VIR_DEBUG("Trying to %s %s to /dev", def->idmap.nuidmap ? "bind" : "move", path); =20 - if (mount(path, "/dev", NULL, flags, NULL) < 0) { + if (mount(path, "/dev", "none", flags, NULL) < 0) { virReportSystemError(errno, _("Failed to mount %s on /dev"), path); @@ -1105,7 +1105,7 @@ static int lxcContainerMountFSDevPTS(virDomainDefPtr = def, VIR_DEBUG("Trying to %s %s to /dev/pts", def->idmap.nuidmap ? "bind" : "move", path); =20 - if (mount(path, "/dev/pts", NULL, flags, NULL) < 0) { + if (mount(path, "/dev/pts", "none", flags, NULL) < 0) { virReportSystemError(errno, _("Failed to mount %s on /dev/pts"), path); @@ -1215,7 +1215,7 @@ static int lxcContainerMountFSBind(virDomainFSDefPtr = fs, } } =20 - if (mount(src, fs->dst, NULL, MS_BIND, NULL) < 0) { + if (mount(src, fs->dst, "none", MS_BIND, NULL) < 0) { virReportSystemError(errno, _("Failed to bind mount directory %s to %s"), src, fs->dst); @@ -1224,7 +1224,7 @@ static int lxcContainerMountFSBind(virDomainFSDefPtr = fs, =20 if (fs->readonly) { VIR_DEBUG("Binding %s readonly", fs->dst); - if (mount(src, fs->dst, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY, NULL) = < 0) { + if (mount(src, fs->dst, "none", MS_BIND|MS_REMOUNT|MS_RDONLY, NULL= ) < 0) { virReportSystemError(errno, _("Failed to make directory %s readonly"), fs->dst); @@ -1549,7 +1549,7 @@ static int lxcContainerMountFSTmpfs(virDomainFSDefPtr= fs, =20 if (fs->readonly) { VIR_DEBUG("Binding %s readonly", fs->dst); - if (mount(fs->dst, fs->dst, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY, NU= LL) < 0) { + if (mount(fs->dst, fs->dst, "none", MS_BIND|MS_REMOUNT|MS_RDONLY, = NULL) < 0) { virReportSystemError(errno, _("Failed to make directory %s readonly"), fs->dst); --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 11:13:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530112034524158.68296791420028; Wed, 27 Jun 2018 08:07:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C927E8553F; Wed, 27 Jun 2018 15:07:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6CE022AE62; Wed, 27 Jun 2018 15:07:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BEAEE1800B68; Wed, 27 Jun 2018 15:07:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5RF6u4V013464 for ; Wed, 27 Jun 2018 11:06:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id AB6232010D76; Wed, 27 Jun 2018 15:06:56 +0000 (UTC) Received: from mx1.redhat.com (ext-mx18.extmail.prod.ext.phx2.redhat.com [10.5.110.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A29182010D75 for ; Wed, 27 Jun 2018 15:06:56 +0000 (UTC) Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7AF383001C28 for ; Wed, 27 Jun 2018 15:06:45 +0000 (UTC) Received: by mail-qt0-f196.google.com with SMTP id h5-v6so1900638qtm.13 for ; Wed, 27 Jun 2018 08:06:45 -0700 (PDT) Received: from localhost.localdomain ([186.223.99.201]) by smtp.gmail.com with ESMTPSA id r13-v6sm3480856qti.70.2018.06.27.08.06.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 08:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=bq/5srGHz5QlEuXL9H00E23He3mrePzsi3FTlNbRJWY=; b=lna2RtUmk1C9ASa8mCJaAiIKLx5aK6wT8nWNwo2zMgDoJAkeVqUlH0jXMnjE86voC8 NRWhGakuKrMAVmqrsUyeAPieiONm+Z4vMGIPYyOnTqudREFhmxoNCblinoPQ5haPNd7n jHmv5mjBdoc/dAqCn+DQGohWIZgvCjf17bjxLYkDinsP/j/6BHv54GhpXY7J1QQHqHV/ kipw+8eU//g/QGt8bwduPMkpBABVDxGjajpUAEYqbW+lA6cjP43D3pt84XhACX06GScb 4EsU1ByoK6fD67O3L5SHCQWVljllTAf3pTSLNIpVvG0S/ag6iHu5R/UBsKnNA34Cel4V Sb6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=bq/5srGHz5QlEuXL9H00E23He3mrePzsi3FTlNbRJWY=; b=kmMV/hY6FBtUYiYW9nZvqZUbDZAhIqcL/ww5ouqosAOVlDcGmk5gWEipob75UsqteL Noql5hRaUf05paiJS7I/FytZjbm9Xvbr7SLx6GMKoDh5jewr4w6g3IR9LZ63A2iNHneA 2JRp25pzq1PxXmMpk+OMCmFh7Zx+Y15wjVqWjPDO/7Ketpm7lVqD4asbiJVU5jxCVVYH vAGUn4w4O4LhuKAjSthf/dQIfN6Nc4FoEx3/rAKwP+6DZzNnrM0V2ZJO3/iAlkpSGN12 mV5W1XyT6Kr1lRcVVZaxqdwnAw69wlXmDt/jR2MWra4cTSidxSgNxjnoTKPt1dMz6bt7 MW/Q== X-Gm-Message-State: APt69E12psQ5IZSMraq3VGLdtu1kecemSV5YocTosjq/Mxx9qIkf60p8 q4+/BaWYOiF8U3ICg026EeohAw== X-Google-Smtp-Source: AAOMgpc8rNSZ3OYZy1jQJH6ZFImI1TX7lgwyD5PvXAjRybFbitlGffmuVimKVEwBaBquPzlEHEEV4g== X-Received: by 2002:a0c:a90b:: with SMTP id y11-v6mr5763110qva.179.1530112004315; Wed, 27 Jun 2018 08:06:44 -0700 (PDT) From: Julio Faracco To: libvir-list@redhat.com Date: Wed, 27 Jun 2018 12:06:26 -0300 Message-Id: <20180627150626.19343-3-jcfaracco@gmail.com> In-Reply-To: <20180627150626.19343-1-jcfaracco@gmail.com> References: <20180627150626.19343-1-jcfaracco@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 27 Jun 2018 15:06:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 27 Jun 2018 15:06:45 +0000 (UTC) for IP:'209.85.216.196' DOMAIN:'mail-qt0-f196.google.com' HELO:'mail-qt0-f196.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.775 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, FUZZY_VPILL, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.196 mail-qt0-f196.google.com 209.85.216.196 mail-qt0-f196.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.47 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 2/2] util: moving 'type' argument to avoid issues with mount() syscall. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 27 Jun 2018 15:07:13 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This commit fixes a mount call inside virgroup.c file. The NULL value into 'type' argument is causing a valgrind issue. See commit 794b576c for more details. The best approach to fix it is moving NULL to "none" filesytem. Signed-off-by: Julio Faracco --- src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 0a31947b0d..e810a3d81d 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3962,7 +3962,7 @@ virCgroupBindMount(virCgroupPtr group, const char *ol= droot, goto cleanup; } =20 - if (mount(src, group->controllers[i].mountPoint, NULL, MS_BIND, + if (mount(src, group->controllers[i].mountPoint, "none", MS_BI= ND, NULL) < 0) { virReportSystemError(errno, _("Failed to bind cgroup '%s' on '%s'= "), --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list