From nobody Mon Feb 9 17:22:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15300665114911018.6522647342771; Tue, 26 Jun 2018 19:28:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B394781DEA; Wed, 27 Jun 2018 02:28:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A5A44A6; Wed, 27 Jun 2018 02:28:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C49A418037ED; Wed, 27 Jun 2018 02:28:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5R2SP9d012436 for ; Tue, 26 Jun 2018 22:28:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 41B1790C40; Wed, 27 Jun 2018 02:28:25 +0000 (UTC) Received: from mx1.redhat.com (ext-mx17.extmail.prod.ext.phx2.redhat.com [10.5.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 393388F6F5 for ; Wed, 27 Jun 2018 02:28:25 +0000 (UTC) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DF80300175C for ; Wed, 27 Jun 2018 02:28:14 +0000 (UTC) Received: by mail-qk0-f195.google.com with SMTP id t79-v6so267370qke.4 for ; Tue, 26 Jun 2018 19:28:14 -0700 (PDT) Received: from localhost.localdomain ([186.223.10.156]) by smtp.gmail.com with ESMTPSA id u40-v6sm1201346qth.24.2018.06.26.19.28.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jun 2018 19:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=WY4wxRq0DtgHuqCyDP74VLfBvHTWnWFp9ET36U7PNS4=; b=unk/g/txPSJDdlC6AjJJWEZkp+AfJjBJifQnjGCA14ETcU2on+QlM9YAUurer1XJrI XMaqA+IMLvlkjUjTuhv+yY6oFacFjoRccOrxsfnf1TRcs6TYtfAb6ljiiQFQSse0mLYG 9I/KinOOFjvkdqIrbocxninRbQYOOY7Jy5Ojqs5/xZ5DwdXGwd4q4z571/7QSuhTmfGw 3kgkGo6I0p6qMoniDenwD7JHrNpy3LPwetRWC+awQB+Hq8WJg1xM1m+lUd32K9LgvgUE vSEUQEnuypNBR1KqhN63LxxFdFy1JqnRcosE+RrV6Fj7WwtoS4EE16mCRwIFIe/8wfnr rKpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=WY4wxRq0DtgHuqCyDP74VLfBvHTWnWFp9ET36U7PNS4=; b=MUSYX4q/05P6FWKc+EIuQ/KhGM+Ps0gqd825uBQUYkcRoCy/mMZtQS+P/6awmd0/hO LXEi+MPbMqPQ9UlWxuSa/XIb+BrSujtmcwe4I7RuiZ3dEAzGsLcx6WBUhdwIioXUDOKK H/G2wxY/1CBqPqmQuKrXO1EdIv0WQEJkSHZQiLDCOoPS6ykznB2Iw8mDc522uI5BCc80 m8c0UWWYRpFh9XyF7F1/Ifl3aqnFj1IPfludZ/xYbhxQfNw6bCPhAX+9ZDxxIHDt052X I5/stlTWJqf+hBH+hGVZbdHBsTy3mLItwtSqN0g/s3N75nwYNhZzdSATBIcxz7BKK8oK svnA== X-Gm-Message-State: APt69E3kU3PZfkM3ypGL1CaVIR2det6DijzD7R8ORsVUTj3Q/94kHYND CphV4Acj4Bfn1lFEB24CDbsxxw== X-Google-Smtp-Source: AAOMgpdof7Nu6dzW1AAq40Rznkl2Riyg57M1P+oWfxNF32/X5ycfoNh/WbeBOA717/nHAc8pwDIqOA== X-Received: by 2002:a37:8f45:: with SMTP id r66-v6mr3562157qkd.47.1530066493549; Tue, 26 Jun 2018 19:28:13 -0700 (PDT) From: Julio Faracco To: libvir-list@redhat.com Date: Tue, 26 Jun 2018 23:27:57 -0300 Message-Id: <20180627022757.2669-3-jcfaracco@gmail.com> In-Reply-To: <20180627022757.2669-1-jcfaracco@gmail.com> References: <20180627022757.2669-1-jcfaracco@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 27 Jun 2018 02:28:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 27 Jun 2018 02:28:14 +0000 (UTC) for IP:'209.85.220.195' DOMAIN:'mail-qk0-f195.google.com' HELO:'mail-qk0-f195.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.775 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, FUZZY_VPILL, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.220.195 mail-qk0-f195.google.com 209.85.220.195 mail-qk0-f195.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.46 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] util: moving 'type' argument to avoid issues with mount() syscall. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 27 Jun 2018 02:28:30 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This commit fixes a mount call inside virgroup.c file. The NULL value into 'type' argument is causing a memory issue. See commit 794b576c2b for more details. The best approach to fix it is moving NULL to "none" filesytem. Signed-off-by: Julio Faracco --- src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 0a31947b0d..e810a3d81d 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3962,7 +3962,7 @@ virCgroupBindMount(virCgroupPtr group, const char *ol= droot, goto cleanup; } =20 - if (mount(src, group->controllers[i].mountPoint, NULL, MS_BIND, + if (mount(src, group->controllers[i].mountPoint, "none", MS_BI= ND, NULL) < 0) { virReportSystemError(errno, _("Failed to bind cgroup '%s' on '%s'= "), --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list