From nobody Mon Feb 9 17:05:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1529579124083892.1040088498164; Thu, 21 Jun 2018 04:05:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E18C281DE6; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91F3B70133; Thu, 21 Jun 2018 11:05:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5C1C4A46C; Thu, 21 Jun 2018 11:05:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5LB59MH010640 for ; Thu, 21 Jun 2018 07:05:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4DC821117638; Thu, 21 Jun 2018 11:05:09 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E66A61117639 for ; Thu, 21 Jun 2018 11:05:08 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 21 Jun 2018 13:04:59 +0200 Message-Id: <20180621110459.27511-6-abologna@redhat.com> In-Reply-To: <20180621110459.27511-1-abologna@redhat.com> References: <20180621110459.27511-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH v2 5/5] tests: Use AM_TESTS_ENVIRONMENT X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 21 Jun 2018 11:05:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" According to the documentation[1], TESTS_ENVIRONMENT is reserved for the user, which means we shouldn't be using it. AM_TESTS_ENVIRONMENT needs to be terminated with a semicolon, which in turn requires exporting the variables instead of merely declaring them, so do both of those things; since we're rewriting the whole hunk anyway, we also take the opportunity use proper quoting. [1] https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbase= d-Testsuites.html Signed-off-by: Andrea Bolognani --- tests/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3872d7b..1fc240b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -37,6 +37,6 @@ EXTRA_DIST =3D \ =20 TESTS =3D $(test_programs) =20 -TESTS_ENVIRONMENT =3D \ - abs_top_builddir=3D$(abs_top_builddir) \ - VIRT_DBUS_INTERFACES_DIR=3D$(abs_top_srcdir)/data +AM_TESTS_ENVIRONMENT =3D \ + export abs_top_builddir=3D"$(abs_top_builddir)"; \ + export VIRT_DBUS_INTERFACES_DIR=3D"$(abs_top_srcdir)/data"; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list